Re: Review Request 59317: SENTRY-1736 Generic service client should support Kerberos

2017-05-17 Thread Vamsee Yarlagadda
> On May 18, 2017, 12:37 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientDefaultImpl.java > > Line 74 (original), 69 (patched) > >

Re: Review Request 59317: SENTRY-1736 Generic service client should support Kerberos

2017-05-17 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59317/#review175341 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: Review Request 59356: SENTRY-1770 Avoid more detaches on commit

2017-05-17 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59356/#review175340 --- Ship it! Ship It! - Vamsee Yarlagadda On May 18, 2017, 12:26

Review Request 59356: SENTRY-1770 Avoid more detaches on commit

2017-05-17 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59356/ --- Review request for sentry, Brian Towles, Hao Hao, kalyan kumar kalvagadda, Na Li

Re: Review Request 59317: SENTRY-1736 Generic service client should support Kerberos

2017-05-17 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59317/#review175339 --- Ship it! Ship It! - Vamsee Yarlagadda On May 18, 2017, 12:06

Re: Review Request 59317: SENTRY-1736 Generic service client should support Kerberos

2017-05-17 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59317/ --- (Updated May 18, 2017, 12:06 a.m.) Review request for sentry, Alexander Kolbaso

Re: [DISCUSS] Having an interactive chat account for Apache Sentry

2017-05-17 Thread Alexander Kolbasov
So far I only saw comments from people working at Cloudera. We do have tools to talk to each other within the company - so far it isn’t clear whether this is beneficial for others as well. It would be good to hear opinions of other developers/users in the community. - Alex > On May 11, 2017, a

Re: [DISCUSS] Having an interactive chat account for Apache Sentry

2017-05-17 Thread Alexander Kolbasov
> On May 12, 2017, at 7:38 AM, Sergio Pena wrote: > > > Some projects, such as Hive, use an IRC channel on the irc.freenode.net > server. This should be free and unlimited. However, I would like to try > Slack while the community is small. IRC/freenode is fine as well. > > Btw, I'm not awar

Re: Review Request 59317: SENTRY-1736 Generic service client should support Kerberos

2017-05-17 Thread Vamsee Yarlagadda
> On May 16, 2017, 6:32 p.m., Vamsee Yarlagadda wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java > > Lines 77-79 (original) > > > > > > I thin

Re: Review Request 59317: SENTRY-1736 Generic service client should support Kerberos

2017-05-17 Thread kalyan kumar kalvagadda
> On May 16, 2017, 6:32 p.m., Vamsee Yarlagadda wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java > > Lines 77-79 (original) > > > > > > I thin

Re: Review Request 59317: SENTRY-1736 Generic service client should support Kerberos

2017-05-17 Thread kalyan kumar kalvagadda
> On May 16, 2017, 6:41 p.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientDefaultImpl.java > > Line 67 (original), 69 (patched) > >

Re: Review Request 59317: SENTRY-1736 Generic service client should support Kerberos

2017-05-17 Thread Vamsee Yarlagadda
> On May 16, 2017, 6:32 p.m., Vamsee Yarlagadda wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java > > Lines 77-79 (original) > > > > > > I thin

Re: Review Request 59317: SENTRY-1736 Generic service client should support Kerberos

2017-05-17 Thread Vamsee Yarlagadda
> On May 16, 2017, 6:41 p.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientDefaultImpl.java > > Line 67 (original), 69 (patched) > >

Re: Permissions on URI are not propagated to namenode plugin

2017-05-17 Thread Sergio Pena
Hey Quianbo, This issue seems it is by design as you mentioned. I was reading the design doc on SENTRY-432 and it has this line in the assumptions section: 3. If the HDFS URI matches a prefix but it does not belong to a > HiveMetaStore table, the > regular HDFS user/group/permissions/ACLs are use

Re: Review Request 59084: SENTRY-1516 - Add gpg configuration to the root pom to enable deployment to Maven Central

2017-05-17 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59084/#review175314 --- Ship it! Cool. It worked!. After running 'mvn clean install -P

Re: Review Request 59350: SENTRY-1743: Two SentrySTore instances are one too many

2017-05-17 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59350/#review175311 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 59350: SENTRY-1743: Two SentrySTore instances are one too many

2017-05-17 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59350/#review175305 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 59350: SENTRY-1743: Two SentrySTore instances are one too many

2017-05-17 Thread Alexander Kolbasov
> On May 17, 2017, 7:37 p.m., Vamsee Yarlagadda wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 145 (patched) > > > > > > Shou

Re: Review Request 59120: SENTRY-1757: Avoid using local hive meta store using wrong configuration

2017-05-17 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59120/#review175304 --- Ship it! Ship It! - Alexander Kolbasov On May 17, 2017, 2:14

Re: Review Request 59350: SENTRY-1743: Two SentrySTore instances are one too many

2017-05-17 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59350/#review175302 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 59330: SENTRY-1768 Avoid detaching object on transaction exit when it isn't needed

2017-05-17 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59330/#review175301 --- Ship it! Ship It! - Na Li On May 17, 2017, 7:37 a.m., Alexan

Re: Review Request 59330: SENTRY-1768 Avoid detaching object on transaction exit when it isn't needed

2017-05-17 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59330/#review175300 --- Ship it! Ship It! - Vamsee Yarlagadda On May 17, 2017, 7:37

Review Request 59350: SENTRY-1743: Two SentrySTore instances are one too many

2017-05-17 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59350/ --- Review request for sentry, Brian Towles, Hao Hao, kalyan kumar kalvagadda, Na Li

Re: Review Request 58975: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs

2017-05-17 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58975/ --- (Updated May 17, 2017, 6:37 p.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 58975: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs

2017-05-17 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58975/#review175298 --- Ship it! Go ahead the commit the patch. It would be good to hav

Re: Review Request 58975: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs

2017-05-17 Thread kalyan kumar kalvagadda
> On May 16, 2017, 9:23 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 429-441 (original), 428-442 (patched) > > > > > > I f

Re: Review Request 59330: SENTRY-1768 Avoid detaching object on transaction exit when it isn't needed

2017-05-17 Thread Alexander Kolbasov
> On May 17, 2017, 2:52 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 2393 (original), 2394 (patched) > > > > > >

Re: Review Request 59330: SENTRY-1768 Avoid detaching object on transaction exit when it isn't needed

2017-05-17 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59330/#review175250 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 59120: SENTRY-1757: Avoid using local hive meta store using wrong configuration

2017-05-17 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59120/ --- (Updated May 17, 2017, 2:14 p.m.) Review request for sentry, Alexander Kolbasov

Review Request 59330: SENTRY-1768 Avoid detaching object on transaction exit when it isn't needed

2017-05-17 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59330/ --- Review request for sentry, Brian Towles, Hao Hao, kalyan kumar kalvagadda, Na Li