Re: Review Request 60669: SENTRY-1762 notification id's in SENTRY_HMS_NOTIFICATION_ID should be purged periodically

2017-07-10 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60669/#review180122 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 60502: SENTRY-1817: Deprecate SENTRY_HA_ENABLED and all tests that use it

2017-07-10 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60502/#review180109 --- sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry

Re: Review Request 60727: SENTRY-1828 Rename version in sentry-ha-redesign branch to 2.0.0-SNAPSHOT

2017-07-10 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60727/#review180118 --- Ship it! Ship It! - Alexander Kolbasov On July 10, 2017, 8:4

Re: Review Request 60752: SENTRY-1831 - The MetastorePlugin SyncTask is leaking connection threads when read timed out issues are thrown

2017-07-10 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60752/#review180113 --- Ship it! Ship It! - Na Li On July 10, 2017, 7:57 p.m., Arjun

Re: Review Request 60518: SENTRY-1815: Send new HMS snapshots to HDFS requesting an old generation ID

2017-07-10 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60518/#review180103 --- Ship it! Ship It! - Alexander Kolbasov On July 10, 2017, 9:1

Sentry-jdk-1.7-v2 - Build # 92 - Still Failing

2017-07-10 Thread Apache Jenkins Server
The Apache Jenkins build system has built Sentry-jdk-1.7-v2 (build #92) Status: Still Failing Check console output at https://builds.apache.org/job/Sentry-jdk-1.7-v2/92/ to view the results.

Re: Review Request 60669: SENTRY-1762 notification id's in SENTRY_HMS_NOTIFICATION_ID should be purged periodically

2017-07-10 Thread Sergio Pena
> On July 7, 2017, 9:32 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > > Lines 241 (patched) > > > > > > This seems a duplicatio

Re: Review Request 60727: SENTRY-1828 Rename version in sentry-ha-redesign branch to 2.0.0-SNAPSHOT

2017-07-10 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60727/#review180100 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 60502: SENTRY-1817: Deprecate SENTRY_HA_ENABLED and all tests that use it

2017-07-10 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60502/#review180098 --- Ship it! Ship It! - Sergio Pena On July 10, 2017, 7:17 p.m.,

Re: Review Request 60518: SENTRY-1815: Send new HMS snapshots to HDFS requesting an old generation ID

2017-07-10 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60518/#review180090 --- Fix it, then Ship it! Ship It! sentry-hdfs/sentry-hdfs-nameno

Re: Review Request 60518: SENTRY-1815: Send new HMS snapshots to HDFS requesting an old generation ID

2017-07-10 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60518/ --- (Updated July 10, 2017, 9:12 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 60727: SENTRY-1828 Rename version in sentry-ha-redesign branch to 2.0.0-SNAPSHOT

2017-07-10 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60727/#review180096 --- Ship it! Ship It! - Na Li On July 10, 2017, 8:45 p.m., kalya

Re: Review Request 60727: SENTRY-1828 Rename version in sentry-ha-redesign branch to 2.0.0-SNAPSHOT

2017-07-10 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60727/ --- (Updated July 10, 2017, 8:45 p.m.) Review request for sentry, Alexander Kolbaso

Review Request 60752: SENTRY-1831 - The MetastorePlugin SyncTask is leaking connection threads when read timed out issues are thrown

2017-07-10 Thread Arjun Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60752/ --- Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and Na L

Re: Review Request 60518: SENTRY-1815: Send new HMS snapshots to HDFS requesting an old generation ID

2017-07-10 Thread Alexander Kolbasov
> On July 6, 2017, 3:25 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > > Lines 72 (patched) > > > > > > You don't need an "else" claus

Re: Review Request 60502: SENTRY-1817: Deprecate SENTRY_HA_ENABLED and all tests that use it

2017-07-10 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60502/ --- (Updated July 10, 2017, 7:17 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 59508: SENTRY-1769 Refactor HMSFollower Class

2017-07-10 Thread Na Li
> On July 10, 2017, 6:31 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 627 (original), 213 (patched) > > > > > > Hmm -

Re: Review Request 60518: SENTRY-1815: Send new HMS snapshots to HDFS requesting an old generation ID

2017-07-10 Thread Alexander Kolbasov
> On July 6, 2017, 5:06 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java > > Line 139 (original), 139 (patched) > > > > > >

Re: Review Request 59508: SENTRY-1769 Refactor HMSFollower Class

2017-07-10 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59508/#review180042 --- I still see a lot of issues with code style even after you applied

Re: Review Request 60518: SENTRY-1815: Send new HMS snapshots to HDFS requesting an old generation ID

2017-07-10 Thread Sergio Pena
> On July 6, 2017, 5:06 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java > > Line 139 (original), 139 (patched) > > > > > >

Re: Review Request 60727: SENTRY-1828 Rename version in sentry-ha-redesign branch to 2.0.0-SNAPSHOT

2017-07-10 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60727/#review180058 --- Are there any SQL changes that should be in 1.8? sentry-provider

Re: Review Request 60727: SENTRY-1828 Rename version in sentry-ha-redesign branch to 2.0.0-SNAPSHOT

2017-07-10 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60727/#review180053 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 59508: SENTRY-1769 Refactor HMSFollower Class

2017-07-10 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59508/ --- (Updated July 10, 2017, 3:14 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 60502: SENTRY-1817: Deprecate SENTRY_HA_ENABLED and all tests that use it

2017-07-10 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60502/ --- (Updated July 10, 2017, 3:02 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 60275: SENTRY-1810 - Add kerberos tests for Kafka

2017-07-10 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60275/ --- (Updated July 10, 2017, 3 p.m.) Review request for sentry. Bugs: SENTRY-1810

Work on Sentry 1.8.0 release has started

2017-07-10 Thread Sergio Pena
Hi, I created the tracking jira (SENTRY-1829) for the Sentry 1.8.0 release and plan to branch tentatively on July/24, 2017. Here's the link to all 'in progress' and 'to do' items that are targeted for 1.8.0: https://issues.apache.org/jira/projects/SENTRY/versions/12335076 I will start looking at

Re: [DISCUSS] Sentry 1.8.0 release

2017-07-10 Thread Sergio Pena
Great, I'm gonna go ahead and create an umbrella jira. I will take a look at the priority of those jiras meant for 1.8.0, and link them to the umbrella jira as blockers if they have to be there. On Mon, Jul 10, 2017 at 9:39 AM, Colm O hEigeartaigh wrote: > +1 on going ahead with the release. How

Re: [DISCUSS] Sentry 1.8.0 release

2017-07-10 Thread Colm O hEigeartaigh
+1 on going ahead with the release. However, first I'd like to see some work done on clearing up what the remaining tasks are for the release. In JIRA, there are currently 11 issues "in progress" and 59 issues "to do" for 1.8.0: https://issues.apache.org/jira/projects/SENTRY/versions/12335076 Col

Re: Code style and checkstyle

2017-07-10 Thread Alexander Kolbasov
Interesting - I didn't know that I could configure IntelliJ to use the Google style and automatically format according to it. Will try. On Mon, Jul 10, 2017 at 7:17 AM, Kalyan Kumar Kalvagadda < kkal...@cloudera.com> wrote: > Sasha, > > I have downloaded the google style xml file and added it to