Re: Review Request 60955: SENTRY-1853: Add the log level access mechanism

2017-07-26 Thread Alexander Kolbasov
> On July 24, 2017, 3:54 p.m., Alexander Kolbasov wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/LogLevelServlet.java > > Lines 32 (patched) > > > > > > Why

Re: Review Request 60955: SENTRY-1853: Add the log level access mechanism

2017-07-26 Thread Donghui Xu
> On 七月 24, 2017, 3:54 p.m., Alexander Kolbasov wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/LogLevelServlet.java > > Lines 32 (patched) > > > > > > Why is

Re: Review Request 61047: SENTRY-1854 HMSFollower should handle notifications even if HDFS sync is disabled.

2017-07-26 Thread Na Li
> On July 27, 2017, 3:19 a.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 4097 (original), 4098 (patched) > >

Re: Review Request 61047: SENTRY-1854 HMSFollower should handle notifications even if HDFS sync is disabled.

2017-07-26 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61047/#review181525 --- Fix it, then Ship it! LGTM otherwise. sentry-provider/sentry-

Re: Review Request 61047: SENTRY-1854 HMSFollower should handle notifications even if HDFS sync is disabled.

2017-07-26 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61047/ --- (Updated July 27, 2017, 3:04 a.m.) Review request for sentry, Alexander Kolbaso

Re: SENTRY-1855: PERM/PATH transactions can fail to commit to the sentry database under load

2017-07-26 Thread Na Li
Hi, Based on testing result, we found transactions fail to commit when running 2 sentry servers with 15 concurrent clients issuing 200 GRANTS/REVOKES each. So the current approach of manually increasing changeID has serious performance issue. We need to develop a solution that has good performanc

Re: DISCUSSION: Prepare master for next release (2.0.0)

2017-07-26 Thread Vamsee Yarlagadda
+1 Thanks, Vamsee On Wed, Jul 26, 2017 at 2:11 PM, Na Li wrote: > Sergio, > > I agree we should do it soon. Can you send out a notice right before it? So > we will submit the changes to master instead of sentry-ha-redesign for 2.0 > > Thanks, > > Lina > > On Wed, Jul 26, 2017 at 3:57 PM, Sergio

Re: DISCUSSION: Prepare master for next release (2.0.0)

2017-07-26 Thread Na Li
Sergio, I agree we should do it soon. Can you send out a notice right before it? So we will submit the changes to master instead of sentry-ha-redesign for 2.0 Thanks, Lina On Wed, Jul 26, 2017 at 3:57 PM, Sergio Pena wrote: > Hi, > > Now that branch-1.8 has been created, we need to prepare th

Re: DISCUSSION: Prepare master for next release (2.0.0)

2017-07-26 Thread Kalyan Kumar Kalvagadda
+1 -Kalyan On Wed, Jul 26, 2017 at 4:05 PM, Alexander Kolbasov wrote: > +1. Important note - anyone who is working on Sentry will need to get a > fresh clone. > > On Wed, Jul 26, 2017 at 10:57 PM, Sergio Pena > wrote: > > > Hi, > > > > Now that branch-1.8 has been created, we need to prepare t

Re: Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query INFO level logging spams Sentry log files

2017-07-26 Thread Arjun Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61138/ --- (Updated July 26, 2017, 9:06 p.m.) Review request for sentry, Alexander Kolbaso

Re: DISCUSSION: Prepare master for next release (2.0.0)

2017-07-26 Thread Alexander Kolbasov
+1. Important note - anyone who is working on Sentry will need to get a fresh clone. On Wed, Jul 26, 2017 at 10:57 PM, Sergio Pena wrote: > Hi, > > Now that branch-1.8 has been created, we need to prepare the current master > branch for the next major release. However, the current master won't b

Re: Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query INFO level logging spams Sentry log files

2017-07-26 Thread Arjun Mishra
> On July 26, 2017, 6:47 p.m., Alexander Kolbasov wrote: > > I think the right way to fix it is by applying SENTRY-1868 rather then > > modifying DataNucleus debug levels. Works. I will close this ticket. - Arjun --- This is an automat

DISCUSSION: Prepare master for next release (2.0.0)

2017-07-26 Thread Sergio Pena
Hi, Now that branch-1.8 has been created, we need to prepare the current master branch for the next major release. However, the current master won't be used for that, and the new sentry-ha-redesign branch will become master. We'd like to do this as soon as possible. This change will be disruptive

Sentry-jdk-1.7-v2 - Build # 104 - Still Unstable

2017-07-26 Thread Apache Jenkins Server
The Apache Jenkins build system has built Sentry-jdk-1.7-v2 (build #104) Status: Still Unstable Check console output at https://builds.apache.org/job/Sentry-jdk-1.7-v2/104/ to view the results.

Re: Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query INFO level logging spams Sentry log files

2017-07-26 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61138/#review181477 --- I think the right way to fix it is by applying SENTRY-1868 rather

Review Request 61144: SENTRY-1869 Try to use pool with idle connections first

2017-07-26 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61144/ --- Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, Sergio

Re: Review Request 61141: SENTRY-1867 - DataNucleus.Query INFO level logging spams Sentry log files

2017-07-26 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61141/#review181471 --- Ship it! Ship It! - Vamsee Yarlagadda On July 26, 2017, 4:07

Re: Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query INFO level logging spams Sentry log files

2017-07-26 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61138/#review181470 --- Ship it! Ship It! - Vamsee Yarlagadda On July 26, 2017, 2:44

Review Request 61141: SENTRY-1867 - DataNucleus.Query INFO level logging spams Sentry log files

2017-07-26 Thread Arjun Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61141/ --- Review request for sentry, Alexander Kolbasov and Vadim Spector. Repository: se

Re: Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query INFO level logging spams Sentry log files

2017-07-26 Thread Mat Crocker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61138/#review181463 --- Ship it! Ship It! - Mat Crocker On July 26, 2017, 2:44 p.m.,

Re: Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query INFO level logging spams Sentry log files

2017-07-26 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61138/#review181458 --- Ship it! Ship It! - kalyan kumar kalvagadda On July 26, 2017

Re: Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query INFO level logging spams Sentry log files

2017-07-26 Thread Arjun Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61138/ --- (Updated July 26, 2017, 2:44 p.m.) Review request for sentry, Alexander Kolbaso

Review Request 61139: SENTRY-1867 - DataNucleus.Query INFO level logging spams Sentry log files

2017-07-26 Thread Arjun Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61139/ --- Review request for sentry, Alexander Kolbasov and Vadim Spector. Repository: se

Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query INFO level logging spams Sentry log files

2017-07-26 Thread Arjun Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61138/ --- Review request for sentry, Alexander Kolbasov and Vadim Spector. Repository: se