Re: Review Request 62177: SENTRY-1931: NameNode only gets full snapshot once

2017-09-07 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62177/#review184941 --- Ship it! Ship It! - Na Li On Sept. 7, 2017, 10:23 p.m.,

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

2017-09-07 Thread Na Li
> On Sept. 7, 2017, 4:34 p.m., Sergio Pena wrote: > > The SQL files for derby and DB2 do have 4000 characters long on the fields > > you just modified. Should we change those as well? I know that. Changing those will require changing sql files. Since they are not causing any issue, I will

Sentry-jdk-1.7 - Build # 843 - Fixed

2017-09-07 Thread Apache Jenkins Server
The Apache Jenkins build system has built Sentry-jdk-1.7 (build #843) Status: Fixed Check console output at https://builds.apache.org/job/Sentry-jdk-1.7/843/ to view the results.

Sentry-jdk-1.7-v2 - Build # 144 - Still Failing

2017-09-07 Thread Apache Jenkins Server
The Apache Jenkins build system has built Sentry-jdk-1.7-v2 (build #144) Status: Still Failing Check console output at https://builds.apache.org/job/Sentry-jdk-1.7-v2/144/ to view the results.

Re: Review Request 62177: SENTRY-1931: NameNode only gets full snapshot once

2017-09-07 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62177/#review184914 --- Ship it! Verified this on actual cluster. - Vamsee Yarlagadda

Re: Review Request 62177: SENTRY-1931: NameNode only gets full snapshot once

2017-09-07 Thread Sergio Pena
> On Sept. 7, 2017, 10:43 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPaths.java > > Lines 89 (patched) > > > > > > Nit: why do we need to

Re: Review Request 62177: SENTRY-1931: NameNode only gets full snapshot once

2017-09-07 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62177/#review184902 --- Ship it! Ship It!

Review Request 62177: SENTRY-1931: NameNode only gets full snapshot once

2017-09-07 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62177/ --- Review request for sentry, Alexander Kolbasov and Vamsee Yarlagadda. Bugs:

Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged

2017-09-07 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62146/#review184887 --- Ship it! Ship It! - Na Li On Sept. 7, 2017, 8:06 a.m.,

Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged

2017-09-07 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62146/#review184885 --- Ship it! Ship It! - Vamsee Yarlagadda On Sept. 7, 2017,

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

2017-09-07 Thread Brian Towles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/ --- (Updated Sept. 7, 2017, 3:43 p.m.) Review request for sentry, Alexander

Re: Review Request 62043: SENTRY-1914: Update field size in Sentry to Match Hive definition

2017-09-07 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62043/#review184840 --- The SQL files for derby and DB2 have 4000 characters long. Should

Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged

2017-09-07 Thread Alexander Kolbasov
> On Sept. 7, 2017, 4:03 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 402 (patched) > > > > > > I don't see CounterWait has the

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

2017-09-07 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61793/#review184838 --- The SQL files for derby and DB2 do have 4000 characters long on

Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged

2017-09-07 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62146/#review184824 ---

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

2017-09-07 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/#review184796 --- This is becoming quite big fix. I think it is better to split it

Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged

2017-09-07 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62146/#review184795 --- Fix it, then Ship it!

Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged

2017-09-07 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62146/ --- (Updated Sept. 7, 2017, 7:06 a.m.) Review request for sentry, Arjun Mishra,