Re: Review Request 62202: SENTRY-1939: Resetting the CounterWait during full snapshot has to be handled across all sentry servers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62202/ --- (Updated Sept. 9, 2017, 4:09 a.m.) Review request for sentry, Alexander Kolbaso

Review Request 62202: SENTRY-1939: Resetting the CounterWait during full snapshot has to be handled across all sentry servers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62202/ --- Review request for sentry, Alexander Kolbasov, Na Li, and Sergio Pena. Reposito

Re: Review Request 62194: SENTRY-1933: hive-authz2 build fails because SentryJSONAlterPartitionMessage is not compatible

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62194/#review185034 --- Ship it! Ship It! - Alexander Kolbasov On Sept. 8, 2017, 9:2

Re: Review Request 62192: SENTRY-1932: Improve logging for HMSPath

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62192/#review185033 --- Ship it! Ship It! - Alexander Kolbasov On Sept. 8, 2017, 10:

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

> On Sept. 7, 2017, 4:34 p.m., Sergio Pena wrote: > > The SQL files for derby and DB2 do have 4000 characters long on the fields > > you just modified. Should we change those as well? > > Na Li wrote: > I know that. Changing those will require changing sql files. Since they > are not causi

Re: Review Request 62192: SENTRY-1932: Improve logging for HMSPath

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62192/ --- (Updated Sept. 8, 2017, 10:37 p.m.) Review request for sentry, Alexander Kolbas

Sentry-jdk-1.7-v2 - Build # 145 - Still Failing

The Apache Jenkins build system has built Sentry-jdk-1.7-v2 (build #145) Status: Still Failing Check console output at https://builds.apache.org/job/Sentry-jdk-1.7-v2/145/ to view the results.

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/#review185027 --- Ship it! Ship It! - Sergio Pena On Sept. 8, 2017, 10:19 p.m.

Re: Review Request 62192: SENTRY-1932: Improve logging for HMSPath

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62192/#review185026 --- Fix it, then Ship it! Do we need both of these logs? May be one

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/ --- (Updated Sept. 8, 2017, 5:19 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 62195: SENTRY-1934: SQL Index name is too long for Oracle 11.2

> On Sept. 8, 2017, 10:03 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > > Line 323 (original), 323 (patched) > > > > > >

Re: Review Request 62195: SENTRY-1934: SQL Index name is too long for Oracle 11.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62195/#review185023 --- Ship it! Ship It! - Alexander Kolbasov On Sept. 8, 2017, 9:5

Re: Review Request 62195: SENTRY-1934: SQL Index name is too long for Oracle 11.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62195/#review185022 --- This is fine, but better would be to remove SENTRY from the name.

Review Request 62195: SENTRY-1934: SQL Index name is too long for Oracle 11.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62195/ --- Review request for sentry, Alexander Kolbasov, Sergio Pena, and Vamsee Yarlagadd

Review Request 62194: SENTRY-1933: hive-authz2 build fails because SentryJSONAlterPartitionMessage is not compatible

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62194/ --- Review request for sentry, Alexander Kolbasov and Na Li. Bugs: sentry-1933

Re: Review Request 62192: SENTRY-1932: Improve logging for HMSPath

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62192/ --- (Updated Sept. 8, 2017, 9:19 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 62192: SENTRY-1932: Improve logging for HMSPath

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62192/#review185015 --- sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hd

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/#review185014 --- Ship it! Ship It! - Na Li On Sept. 8, 2017, 8:28 p.m., Brian

Re: Review Request 62192: SENTRY-1932: Improve logging for HMSPath

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62192/#review185013 --- Ship it! Ship It! - Brian Towles On Sept. 8, 2017, 2:23 p.m.

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

> On Sept. 8, 2017, 6:05 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > > Line 122 (original) > > > > > > This change ma

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/ --- (Updated Sept. 8, 2017, 3:28 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

> On Sept. 8, 2017, 3:03 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollowerState.java > > Lines 20 (patched) > > > > > > Where is this class used? I ca

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/#review185004 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/ --- (Updated Sept. 8, 2017, 2:58 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/#review185002 --- sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/h

Review Request 62192: SENTRY-1932: Improve logging for HMSPath

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62192/ --- Review request for sentry, Alexander Kolbasov, Na Li, and Vamsee Yarlagadda. Re

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/#review184999 --- sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hd

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

> On Sept. 8, 2017, 1:04 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryStateBank.java > > Lines 31 (patched) > > > > > > Someone may think

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

> On Sept. 8, 2017, 1:55 p.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > > Lines 123 (patched) > > > > > > Previous log messages have INFO le

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

> On Sept. 8, 2017, 1:55 p.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > > Line 105 (original), 107 (patched) > > > > > > Why did you change

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/#review184996 --- Fix it, then Ship it! The code looks good. I just have a couple

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/ --- (Updated Sept. 8, 2017, 11:29 a.m.) Review request for sentry, Alexander Kolbas