Re: Review Request 62496: SENTRY-1963: Sentry JSON reporter should use regular implementation for local file system

2017-10-02 Thread Alexander Kolbasov
> On Oct. 2, 2017, 3:11 p.m., kalyan kumar kalvagadda wrote: > > Sasha, Could you please explain "what does regular implementation for local > > file system" mean? That will help get the conetxt what you are trying to do. The original implementation uses Hadoop local filesystem interface which

Re: Review Request 62496: SENTRY-1963: Sentry JSON reporter should use regular implementation for local file system

2017-10-02 Thread Alexander Kolbasov
> On Sept. 22, 2017, 3:55 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java > > Line 319 (original), 337 (patched) > > > > > >

Re: Concerns about Hive authz2 support

2017-10-02 Thread Sergio Pena
Sure. First, here's what Hive Wiki says about authz1 limitations: The default authorization in Hive is *not designed* with the intent to protect

Re: Concerns about Hive authz2 support

2017-10-02 Thread Sergio Pena
Colm, I haven't finished the last email, I pressed a button that sent the partial email :), sorry. I'm still writing. On Mon, Oct 2, 2017 at 12:34 PM, Sergio Pena wrote: > Sure. > > First, here's what Hive Wiki says about authz1 limitations: > > The default

Re: Concerns about Hive authz2 support

2017-10-02 Thread Sergio Pena
Sure. First, here's what Hive Wiki says about authz1 limitations: The default authorization in Hive is *not designed* with the intent to protect

Code consolidation query

2017-10-02 Thread Colm O hEigeartaigh
Hi all, I'm preparing a patch to consolidate some duplicate code in sentry-provider-db, and have a question: CommandUtil.convertToTSentryPrivilege:

Re: Sentry CLI

2017-10-02 Thread Colm O hEigeartaigh
Hi Alex, Yes I can take a look at this task. Colm. On Wed, Sep 27, 2017 at 7:33 PM, Alexander Kolbasov wrote: > I put current code for sentry CLI into akolb-cli branch. So far it supports > Hive privileges only. It would be great of some can add support for > Solr/Kafka

Re: Review Request 62496: SENTRY-1963: Sentry JSON reporter should use regular implementation for local file system

2017-10-02 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62496/#review186848 --- Sasha, Could you please explain "what does regular implementation

Re: Concerns about Hive authz2 support

2017-10-02 Thread Colm O hEigeartaigh
Hi Sergio, Could you give some background as to what the differences are between "authz1" and "authz2"? Sorry if this is an obvious question :-) For the 1.8.0 release, authz1 was supported with Hive 1 and authz2 with Hive 2, so I assumed the separate bindings were related to the Hive versions

Re: Review Request 62654: SENTRY-1957: Do not parse hive sql string in Sentry

2017-10-02 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62654/#review186843 --- I need to have closer look at your code. I found it in my first