Re: Review Request 62990: SENTRY-1988: Bump slf4j version from 1.6.0 to 1.7.25 (latest version)

2017-10-13 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62990/#review188048 --- Ship it! Ship It! - kalyan kumar kalvagadda On Oct. 13, 2017

Re: Review Request 62992: SENTRY-1990: Use same hadoop.version to hadoop-aws dependencies

2017-10-13 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62992/#review188047 --- Ship it! Ship It! - Alexander Kolbasov On Oct. 13, 2017, 10:

Re: Review Request 62990: SENTRY-1988: Bump slf4j version from 1.6.0 to 1.7.25 (latest version)

2017-10-13 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62990/#review188046 --- Ship it! Ship It! - Alexander Kolbasov On Oct. 13, 2017, 9:0

Re: Proposal to release Sentry 2.0.0

2017-10-13 Thread Kalyan Kumar Kalvagadda
Sasha, See my response in-line below -Kalyan On Fri, Oct 13, 2017 at 1:09 PM, Alexander Kolbasov wrote: > Kalyan, > > Thank you for pushing forward 2.0 release! > > > On Oct 13, 2017, at 7:20 AM, Kalyan Kumar Kalvagadda < > kkal...@cloudera.com> wrote: > > > > Hello all, > > > > We need to rel

Sentry-jdk-1.7-v2 - Build # 167 - Failure

2017-10-13 Thread Apache Jenkins Server
The Apache Jenkins build system has built Sentry-jdk-1.7-v2 (build #167) Status: Failure Check console output at https://builds.apache.org/job/Sentry-jdk-1.7-v2/167/ to view the results.

Review Request 62992: SENTRY-1990: Use same hadoop.version to hadoop-aws dependencies

2017-10-13 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62992/ --- Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and Na L

Re: Proposal to release Sentry 2.0.0

2017-10-13 Thread Sergio Pena
Thanks Kalyan. I like the proposal. The original idea was to switch to hive-authz2 on Sentry 2.0, but we can have this mix for now. It won't be incompatible to switch completely to checkPrivileges() in the future once we understand hive and sentry relationship on this area. +1 On Fri, Oct 13,

Re: Review Request 62902: SENTRY-1978: Move the hive-authz2 grant/revoke implementation into the sentry-binding-hive module

2017-10-13 Thread Sergio Pena via Review Board
> On Oct. 13, 2017, 9:09 p.m., Na Li wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/util/SentryAuthorizerUtil.java > > Lines 129 (patched) > > > > > > Can you add the following

Re: Review Request 62902: SENTRY-1978: Move the hive-authz2 grant/revoke implementation into the sentry-binding-hive module

2017-10-13 Thread Sergio Pena via Review Board
> On Oct. 13, 2017, 8:57 p.m., Na Li wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizerImpl.java > > Line 52 (original), 64 (patched) > > > > > > shou

Re: Review Request 62942: Bump the minimum java version to 8

2017-10-13 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62942/#review188032 --- Ship it! Ship It! - Alexander Kolbasov On Oct. 13, 2017, 6:3

Re: Review Request 62990: SENTRY-1988: Bump slf4j version from 1.6.0 to 1.7.25 (latest version)

2017-10-13 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62990/#review188030 --- Ship it! Ship It! - Na Li On Oct. 13, 2017, 9:03 p.m., Sergi

Re: Review Request 62902: SENTRY-1978: Move the hive-authz2 grant/revoke implementation into the sentry-binding-hive module

2017-10-13 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62902/#review188022 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Review Request 62990: SENTRY-1988: Bump slf4j version from 1.6.0 to 1.7.25 (latest version)

2017-10-13 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62990/ --- Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and Na L

Re: Review Request 62902: SENTRY-1978: Move the hive-authz2 grant/revoke implementation into the sentry-binding-hive module

2017-10-13 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62902/#review188013 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Re: Review Request 62987: SENTRY-1987: Remove pom code related to non-existing TestSentryAuthorizationProvider class

2017-10-13 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62987/#review188010 --- Ship it! Ship It! - Na Li On Oct. 13, 2017, 8:12 p.m., Sergi

Review Request 62987: SENTRY-1987: Remove pom code related to non-existing TestSentryAuthorizationProvider class

2017-10-13 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62987/ --- Review request for sentry, Alexander Kolbasov and kalyan kumar kalvagadda. Bugs

Re: Review Request 62942: Bump the minimum java version to 8

2017-10-13 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62942/ --- (Updated Oct. 13, 2017, 6:30 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 62983: SENTRY-1986: Fix NPE on createGrantTask from SentryHiveAuthorizationTaskFactoryImpl.java

2017-10-13 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62983/#review187993 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Review Request 62983: SENTRY-1986: Fix NPE on createGrantTask from SentryHiveAuthorizationTaskFactoryImpl.java

2017-10-13 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62983/ --- Review request for sentry and kalyan kumar kalvagadda. Bugs: sentry-1986 ht

Re: Proposal to release Sentry 2.0.0

2017-10-13 Thread Alexander Kolbasov
Kalyan, Thank you for pushing forward 2.0 release! > On Oct 13, 2017, at 7:20 AM, Kalyan Kumar Kalvagadda > wrote: > > Hello all, > > We need to release sentry HA functionality so that community can start > using it. In this regard I proposed to have a sentry 1.9.0 release as there > were som

Re: Review Request 62979: SENTRY-1985: Sentry should log in stdout when it is ready to serve requests

2017-10-13 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62979/#review187979 --- should SentryService log the sentry service is ready? You only log

Re: Review Request 62977: SENTRY-1984: Decrease number of max idle connections for Sentry clients

2017-10-13 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62977/#review187978 --- Ship it! Ship It! - Na Li On Oct. 13, 2017, 3:21 p.m., Sergi

Review Request 62979: SENTRY-1985: Sentry should log in stdout when it is ready to serve requests

2017-10-13 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62979/ --- Review request for sentry, Alexander Kolbasov and kalyan kumar kalvagadda. Bugs

Review Request 62977: SENTRY-1984: Decrease number of max idle connections for Sentry clients

2017-10-13 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62977/ --- Review request for sentry, Alexander Kolbasov and kalyan kumar kalvagadda. Bugs

Proposal to release Sentry 2.0.0

2017-10-13 Thread Kalyan Kumar Kalvagadda
Hello all, We need to release sentry HA functionality so that community can start using it. In this regard I proposed to have a sentry 1.9.0 release as there were some outstanding issues integrating with Hive. Community was not positive on this proposal for various reasons. With recent findings w