Re: Review Request 63509: SENTRY-2028: Avoid datanucleus to create/update database schema

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63509/ --- (Updated Nov. 3, 2017, 10:52 p.m.) Review request for sentry, Alexander

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63250/#review190068 --- There are couple of missing pieces 1. AuditLogger does not

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

> On Nov. 1, 2017, 8:42 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SentrySolrPluginImpl.java > > Lines 232 (patched) > > > > > >

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

> On Nov. 1, 2017, 8:42 p.m., kalyan kumar kalvagadda wrote: > > sentry-core/sentry-core-model-solr/src/main/java/org/apache/sentry/core/model/solr/Admin.java > > Lines 26 (patched) > > > > > > Here name Admin

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

> On Nov. 1, 2017, 8:42 p.m., kalyan kumar kalvagadda wrote: > > sentry-core/sentry-core-model-solr/src/main/java/org/apache/sentry/core/model/solr/Admin.java > > Lines 26 (patched) > > > > > > Here name Admin

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

> On Nov. 1, 2017, 8:42 p.m., kalyan kumar kalvagadda wrote: > > sentry-core/sentry-core-model-solr/src/main/java/org/apache/sentry/core/model/solr/Admin.java > > Lines 26 (patched) > > > > > > Here name Admin

Re: Inconsistent commit messages

Sounds like we have a consensus - use the format SENTRY-123: Fix important feature (Hacker Master, reviewed by Foo Bar and Ben Hur) Any other comments On Fri, Nov 3, 2017 at 11:36 AM, Sergio Pena wrote: > Agree. > > I've seen the following format repeated in other

Re: Broken master

It is done. The following commit was causing the test to fail: commit 99efc7fc960d5680fc7605400e0375a7883bae37 Author: Kalyan Kumar Kalvagadda Date: Mon Oct 23 15:37:10 2017 -0500 SENTRY-2017: Fix Sentry e2e tests to use

Re: Review Request 63488: SENTRY-2029: Unit test fails consistently for org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeCleanupOnDrop

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63488/#review190027 --- Ship it! Look's like adeeper issue. please proceed with the