Re: Review Request 63874: SENTRY-1812 - Provide interactive Sentry CLI

2017-11-20 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63874/ --- (Updated Nov. 20, 2017, 3:05 p.m.) Review request for sentry. Bugs: SENTRY-18

Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

2017-11-20 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2034 https:/

Re: Interesting coincedence

2017-11-20 Thread Kalyan Kumar Kalvagadda
Yes, it is. :-) -Kalyan On Fri, Nov 17, 2017 at 7:50 PM, Alexander Kolbasov wrote: >1. SENTRY-2000 > is"Cut >2.0.0 branch" ! >

Re: Review Request 63896: SENTRY-2052: Reduce TestSentryStore time by setting transaction retries to 1 and other refactors

2017-11-20 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63896/#review191522 --- Ship it! Ship It! - Na Li On Nov. 17, 2017, 10:29 p.m., Serg

Re: Review Request 63928: SENTRY-2054: Unit tests must create temporary files under the Maven target directory

2017-11-20 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63928/#review191523 --- Ship it! Ship It! - Na Li On Nov. 17, 2017, 11:10 p.m., Serg

Re: Several unit tests failing on Sentry

2017-11-20 Thread Sergio Pena
We finally deciphered the reason for the Jenkins test failures, and they were not related to the Sentry codebase. For some unknown reason, the /tmp directory was cleaned up at some point causing the Sentry hive tests to fail on MR jobs because files on the /tmp weren't found. The fixes were done t

Re: Several unit tests failing on Sentry

2017-11-20 Thread Kalyan Kumar Kalvagadda
Sergio, I resolved SENTRY-2050. -Kalyan On Mon, Nov 20, 2017 at 12:40 PM, Sergio Pena wrote: > We finally deciphered the reason for the Jenkins test failures, and they > were not related to the Sentry codebase. For some unknown reason, the /tmp > directory was cleaned up at some point causing

Review Request 63964: SENTRY-2049: Remove hive-authz2 profile from the sentry-dist module

2017-11-20 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63964/ --- Review request for sentry. Bugs: SENTRY-2049 https://issues.apache.org/jira

Re: Several unit tests failing on Sentry

2017-11-20 Thread Na Li
Sergio, It's great you found the cause. How did you figure it out? Thanks, Lina On Mon, Nov 20, 2017 at 12:46 PM, Kalyan Kumar Kalvagadda < kkal...@cloudera.com> wrote: > Sergio, > > I resolved SENTRY-2050. > > -Kalyan > > On Mon, Nov 20, 2017 at 12:40 PM, Sergio Pena > wrote: > > > We finall

Re: Review Request 63964: SENTRY-2049: Remove hive-authz2 profile from the sentry-dist module

2017-11-20 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63964/#review191545 --- sentry-dist/pom.xml Lines 105-108 (original), 105-108 (patched) <

Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

2017-11-20 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/#review191546 --- I see you have different test cases per file and not per method, a

Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

2017-11-20 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/ --- (Updated Nov. 21, 2017, 12:27 a.m.) Review request for sentry, Na Li and Sergio

Review Request 63974: SENTRY-2062: Support the new Hive 2.3.2 DbNotificationListener

2017-11-20 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63974/ --- Review request for sentry. Bugs: sentry-2062 https://issues.apache.org/jira

Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

2017-11-20 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63975/ --- Review request for sentry, Arjun Mishra, Brian Towles, kalyan kumar kalvagadda,

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

2017-11-20 Thread Vadim Spector via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63975/#review191564 --- sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/te

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

2017-11-20 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63975/#review191566 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr