----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63975/#review191566 -----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java Lines 283 (patched) <https://reviews.apache.org/r/63975/#comment269413> Why do we need an extra boolean Can we just check for currDB == null ? Or it isn't null in this case? - Alexander Kolbasov On Nov. 21, 2017, 3:32 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63975/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 3:32 a.m.) > > > Review request for sentry, Arjun Mishra, Brian Towles, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > if db name is not set in "case HiveParser.TOK_ALTERTABLE" at > HiveAuthzBindingHook.preAnalyze, make sure it is set > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > e4620ea > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java > aa99595 > > > Diff: https://reviews.apache.org/r/63975/diff/1/ > > > Testing > ------- > > unit test > > > Thanks, > > Na Li > >
