Re: Review Request 64179: SENTRY-2079: Sentry HA leader monitor does not work due to a mix of curator versions in the classpath

2017-11-30 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64179/#review192434 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 29, 2017

Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

2017-11-30 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64241/ --- Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O hEigeartaigh

Re: Review Request 64230: SENTRY-2082: Exclude javax.servlet-3.0.0.v201112011016.jar from Sentry dist

2017-11-30 Thread kalyan kumar kalvagadda via Review Board
> On Dec. 1, 2017, 1:23 a.m., kalyan kumar kalvagadda wrote: > > Ship It! Sergio, There were test failures. may not be related but I have re-submitted your patch again. - kalyan kumar --- This is an automatically generated e-mail. To r

Re: Review Request 64230: SENTRY-2082: Exclude javax.servlet-3.0.0.v201112011016.jar from Sentry dist

2017-11-30 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64230/#review192424 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 30, 2017

Re: Review Request 64230: SENTRY-2082: Exclude javax.servlet-3.0.0.v201112011016.jar from Sentry dist

2017-11-30 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64230/#review192423 --- Ship it! Ship It! - Alexander Kolbasov On Nov. 30, 2017, 11:

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

2017-11-30 Thread Arjun Mishra via Review Board
> On Nov. 30, 2017, 11:07 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 346 (patched) > > > > > > Is getting empty snapsho

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

2017-11-30 Thread Vadim Spector via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/#review192387 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Review Request 64230: SENTRY-2082: Exclude javax.servlet-3.0.0.v201112011016.jar from Sentry dist

2017-11-30 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64230/ --- Review request for sentry. Bugs: SENTRY-2082 https://issues.apache.org/jira

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

2017-11-30 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/ --- (Updated Nov. 30, 2017, 10:41 p.m.) Review request for sentry, kalyan kumar kal

Re: [VOTE] Release Sentry version 2.0.0

2017-11-30 Thread Kalyan Kumar Kalvagadda
I will start the voting for RC2 addressing the concerns. -Kalyan On Thu, Nov 30, 2017 at 10:36 AM, Alexander Kolbasov wrote: > Given that the licensing exercise isn't complete, I suggest revoking the > vote on the release until it is complete. > > - Alex > > On Thu, Nov 30, 2017 at 7:11 AM, Kal

Re: Review Request 64220: SENTRY-2080: Stop distributing jars with GPL and LGPL licenses only

2017-11-30 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64220/#review192329 --- Ship it! Ship It! - Na Li On Nov. 30, 2017, 6:36 p.m., kalya

Review Request 64220: SENTRY-2080: Stop distributing jars with GPL and LGPL licenses only

2017-11-30 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64220/ --- Review request for sentry, Brian Towles and Colm O hEigeartaigh. Bugs: SENTRY-2

Re: Review Request 63775: SENTRY-1543 dropOrRenamePrivilegeForAllRoles() has confusing code

2017-11-30 Thread Steve Moist via Review Board
> On Nov. 15, 2017, 7:11 p.m., Sergio Pena wrote: > > The subject of the review board must match the JIRA subject. You could > > either change the JIRA or the Review subject to match the correct fix. > > > > The getUniqueMSentryPrivilege() is still confusing. Any idea of the > > difference in

Re: Review Request 63964: SENTRY-2049: Remove hive-authz2 profile from the sentry-dist module

2017-11-30 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63964/#review192306 --- Ship it! Ship It! - Sergio Pena On Nov. 27, 2017, 9:36 p.m.,

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

2017-11-30 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/#review192305 --- Ship it! Ship It! - Sergio Pena On Nov. 29, 2017, 5:43 p.m.,

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

2017-11-30 Thread Sergio Pena via Review Board
> On Nov. 29, 2017, 4:50 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 251-252 (patched) > > > > > > This line is making me

Re: [VOTE] Release Sentry version 2.0.0

2017-11-30 Thread Alexander Kolbasov
Given that the licensing exercise isn't complete, I suggest revoking the vote on the release until it is complete. - Alex On Thu, Nov 30, 2017 at 7:11 AM, Kalyan Kumar Kalvagadda < kkal...@cloudera.com> wrote: > here are my next steps towards being compliant to apache licensing > > 1. Stop distr

Re: [VOTE] Release Sentry version 2.0.0

2017-11-30 Thread Kalyan Kumar Kalvagadda
here are my next steps towards being compliant to apache licensing 1. Stop distributing jar which are licensed under GPL and LGPL only as they are not allowed to be distributed. (Please refer http://www.apache.org/legal/resolved.html#category-a) 2. See if we can stop distributing jars which are no

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-11-30 Thread Xinran Tinney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/#review192298 --- sentry-provider/sentry-provider-db/src/test/java/org/apache/sentr

Re: [VOTE] Release Sentry version 2.0.0

2017-11-30 Thread Colm O hEigeartaigh
Hi Kalyan, You need to read the following page, which lays it all out: https://www.apache.org/dev/licensing-howto.html In particular, there are two things you need to do: a) Go through the list of dependencies and isolate the non-Apache licensed jars. Include that license in a "licenses" direct