Re: Review Request 64259: SENTRY-1572 SentryMain() shouldn't dynamically load tool class

> On Dec. 15, 2017, 7:51 p.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java > > Line 45 (original), 49 (patched) > > > > > > Do you actually use these cl

Re: Review Request 64452: SENTRY-2091: User-based Privilege is broken by SENTRY-769

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64452/#review193992 --- sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry

Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar kalvag

Re: Review Request 64452: SENTRY-2091: User-based Privilege is broken by SENTRY-769

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64452/#review193979 --- Ship it! Ship It! - Arjun Mishra On Dec. 14, 2017, 8:54 p.m.

Re: Review Request 64452: SENTRY-2091: User-based Privilege is broken by SENTRY-769

> On Dec. 15, 2017, 3:37 p.m., Arjun Mishra wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestGrantUserToRole.java > > Lines 282 (patched) > > > > > > Is the fail stat

Re: Review Request 64259: SENTRY-1572 SentryMain() shouldn't dynamically load tool class

> On Dec. 15, 2017, 7:51 p.m., Alexander Kolbasov wrote: > > sentry-command-line-tools/pom.xml > > Lines 60 (patched) > > > > > > I'm curios, what uses this? I don't think we use it here, so I will remove it > On D

Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/#review193972 --- sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/te

Re: Review Request 64259: SENTRY-1572 SentryMain() shouldn't dynamically load tool class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64259/#review193957 --- bin/config_tool Line 55 (original), 55 (patched)

Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/#review193939 --- Ship it! Ship It! - Na Li On Dec. 5, 2017, 9:09 p.m., kalyan

Re: Review Request 64452: SENTRY-2091: User-based Privilege is broken by SENTRY-769

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64452/#review193920 --- sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/te