----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64452/#review193992 -----------------------------------------------------------
sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hive/TestUserManagement.java Line 372 (original), 372 (patched) <https://reviews.apache.org/r/64452/#comment272683> Are we sure here that CREATE fails for the right reason, i.e. user1 not having privileges, not because it already exists? If we want to make sure that user1 can neither CREATE nor SELECT, would it make sense to try CREATE on a different table, not the one that already exists, followed by SELECT on already existing table? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUserManagement.java Line 370 (original), 368 (patched) <https://reviews.apache.org/r/64452/#comment272684> Ditto: do we know CREATE fails for the right reason (user1 lacking privilege), not because the table already exists? - Vadim Spector On Dec. 14, 2017, 8:54 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64452/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2017, 8:54 p.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, Sergio > Pena, and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > Update the code to make sure user without group but with role has proper > access. > test case is added for the scenario that user has no group but with desired > role. > test case is added for the scenario that user has no group and no privilege > to allow the access > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/HiveAuthzBindingHookBaseV2.java > 5a21dd3 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java > 9c60c22 > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzBindings.java > a41d1bd > > sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/binding/solr/TestSolrAuthzBinding.java > f060b82 > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java > 005724f > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 6c4631f > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hive/TestUserManagement.java > 02ac514 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestGrantUserToRole.java > 5364937 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUserManagement.java > 02ac514 > > > Diff: https://reviews.apache.org/r/64452/diff/2/ > > > Testing > ------- > > unit tests > > > Thanks, > > Na Li > >
