Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

2018-01-22 Thread Vadim Spector via Review Board
> On Jan. 22, 2018, 8:49 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > > Lines 67 (patched) > > > > > > I wonder about

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

2018-01-22 Thread Na Li via Review Board
> On Jan. 22, 2018, 8:49 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > > Lines 67 (patched) > > > > > > I wonder about

Re: Review Request 64452: SENTRY-2091: User-based Privilege is broken by SENTRY-769

2018-01-22 Thread Na Li via Review Board
> On Dec. 15, 2017, 10:48 p.m., Vadim Spector wrote: > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hive/TestUserManagement.java > > Line 372 (original), 372 (patched) > > > > > > Are

Re: Review Request 64452: SENTRY-2091: User-based Privilege is broken by SENTRY-769

2018-01-22 Thread Na Li via Review Board
> On Dec. 19, 2017, 9:58 p.m., Steve Moist wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestGrantUserToRole.java > > Lines 280 (patched) > > > > > > Worth it to add @

Re: Review Request 64452: SENTRY-2091: User-based Privilege is broken by SENTRY-769

2018-01-22 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64452/ --- (Updated Jan. 22, 2018, 9:16 p.m.) Review request for sentry, Arjun Mishra, kal

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

2018-01-22 Thread Vadim Spector via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/#review195917 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

2018-01-22 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/#review195928 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Sentry's future path

2018-01-22 Thread Sergio Pena
I don't know the current status of RecordServices and what path is taking, but as far as I know, RecordServices won't be a replacement for Sentry in the near or long future. Sentry will continue being the security point for storing and requesting user privileges for databases and other generic mode

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

2018-01-22 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/ --- (Updated Jan. 22, 2018, 5:40 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-01-22 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/#review195913 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Sentry's future path

2018-01-22 Thread shang xinli
Hi all, There was a discussion about replacing Sentry with Record Service some time ago. However, Record Service's last commit is Aug 2016. Can somebody explain is this still the path to go? Xinli

Re: Review Request 65192: SENTRY-2074: Fix maven dependencies to have all directly used libraries defined

2018-01-22 Thread Brian Towles via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65192/ --- (Updated Jan. 22, 2018, 9:13 a.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 65192: SENTRY-2074: Fix maven dependencies to have all directly used libraries defined

2018-01-22 Thread Brian Towles via Review Board
> On Jan. 19, 2018, 4:12 a.m., Colm O hEigeartaigh wrote: > > The patch does not apply for me on master: > > > > Also, the following version could be changed to the version > > ${jackson-fasterxml.version}: > > > > > > +com.fasterxml.jackson.core > > +${jackson-fasterxml.versi

Review Request 65244: SENTRY-2074: Fix maven dependencies to have all directly used libraries defined

2018-01-22 Thread Brian Towles via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65244/ --- Review request for sentry, Alexander Kolbasov, Arjun Mishra, Colm O hEigeartaigh

Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-01-22 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/ --- Review request for sentry, Arjun Mishra, Na Li, Sergio Pena, and Vadim Spector.