> On Dec. 15, 2017, 10:48 p.m., Vadim Spector wrote: > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hive/TestUserManagement.java > > Line 372 (original), 372 (patched) > > <https://reviews.apache.org/r/64452/diff/2/?file=1917438#file1917438line372> > > > > Are we sure here that CREATE fails for the right reason, i.e. user1 not > > having privileges, not because it already exists? > > > > If we want to make sure that user1 can neither CREATE nor SELECT, would > > it make sense to try CREATE on a different table, not the one that already > > exists, followed by SELECT on already existing table?
change to "CREATE TABLE db1.t_user1", so the table name is different now. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64452/#review193992 ----------------------------------------------------------- On Jan. 22, 2018, 9:16 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64452/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2018, 9:16 p.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, Sergio > Pena, and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > Update the code to make sure user without group but with role has proper > access. > test case is added for the scenario that user has no group but with desired > role. > test case is added for the scenario that user has no group and no privilege > to allow the access > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/HiveAuthzBindingHookBaseV2.java > 5a21dd3 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java > 447deaf > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java > a9b98f3 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > edea5b6 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestGrantUserToRole.java > 5364937 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUserManagement.java > fd8ec56 > > > Diff: https://reviews.apache.org/r/64452/diff/3/ > > > Testing > ------- > > unit tests > > > Thanks, > > Na Li > >
