Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

2018-01-25 Thread Vadim Spector via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/#review196297 ---

Re: [DISCUSS] Sentry roadmap after 2.0

2018-01-25 Thread Alexander Kolbasov
Stephen - can you formulate these in JIRAs so we can add these to the roadmap? On Thu, Jan 25, 2018 at 12:31 PM, Stephen Moist wrote: > A few things come to mind. > > Improving and expanding on the capabilities of the Sentry CLI. It would > be good to see all the other

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-01-25 Thread Vadim Spector via Review Board
> On Jan. 25, 2018, 4:16 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java > > Line 231 (original), 246 (patched) > >

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

2018-01-25 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/#review196289 ---

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-01-25 Thread kalyan kumar kalvagadda via Review Board
> On Jan. 25, 2018, 4:16 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java > > Line 231 (original), 246 (patched) > >

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-01-25 Thread Vadim Spector via Review Board
> On Jan. 25, 2018, 4:16 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java > > Line 231 (original), 246 (patched) > >

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

2018-01-25 Thread kalyan kumar kalvagadda via Review Board
> On Jan. 22, 2018, 8:49 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > > Lines 231 (patched) > > > > > > optimization

Re: [DISCUSS] Sentry roadmap after 2.0

2018-01-25 Thread Na Li
https://issues.apache.org/jira/browse/SENTRY-2129 is create to track the development activities for user-based privilege. I will add more sub-tasks to it On Thu, Jan 25, 2018 at 1:42 PM, Alexander Kolbasov wrote: > Agreed, making 2.1 with just user-level privileges

Re: [DISCUSS] Sentry roadmap after 2.0

2018-01-25 Thread Alexander Kolbasov
Agreed, making 2.1 with just user-level privileges improvements (plus set of accumulated bug fixes) sounds reasonable. On Thu, Jan 25, 2018 at 11:41 AM, Alexander Kolbasov wrote: > Looks like we have a consensus of doing user-level privileges improvements > for 2.1. Let's

Re: [DISCUSS] Sentry roadmap after 2.0

2018-01-25 Thread Sergio Pena
I don't think there exists a user-level privileges doc yet. I can commit to finish the default owner privileges and submit a spec doc for the changes we can do to finish it soon. Anyone else likes to commit to user-level? Btw, I'd like to lower Sentry 2.1 to 1 or 2 features so that we have a

Re: Review Request 65321: SENTRY-2127: Fix unstable unit test TestColumnEndToEnd.testCrossDbTableOperations

2018-01-25 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65321/#review196281 --- Ship it! Ship It! - Sergio Pena On Jan. 24, 2018, 9:33

Re: [DISCUSS] Sentry roadmap after 2.0

2018-01-25 Thread Alexander Kolbasov
Looks like we have a consensus of doing user-level privileges improvements for 2.1. Let's see whether anyone wants to add more content. On Thu, Jan 25, 2018 at 11:38 AM, Na Li wrote: > Sasha, > > I have looked into how to complete the user-based privilege for a while, >

Re: [DISCUSS] Sentry roadmap after 2.0

2018-01-25 Thread Alexander Kolbasov
Lina - would it make sense to create uber-JIRA for ULP, mark it with "roadmap" keyword and start putting some of these as subtasks? On Thu, Jan 25, 2018 at 11:35 AM, Na Li wrote: > Sasha, > > The current user-based privilege missed some items: > > >- Sentry policy has

Re: [DISCUSS] Sentry roadmap after 2.0

2018-01-25 Thread Na Li
Sasha, I have looked into how to complete the user-based privilege for a while, and can commit to implement it. I can work with Kalyan to create a design doc for user-based privilege. Thanks, Lina On Thu, Jan 25, 2018 at 1:35 PM, Na Li wrote: > Sasha, > > The current

Re: [DISCUSS] Sentry roadmap after 2.0

2018-01-25 Thread Na Li
Sasha, The current user-based privilege missed some items: - Sentry policy has two service API: SentryPolicyService and SentryGenericPolicyService. The current implementation does not support user-based privilege for SentryGenericPolicyService - SENTRY-2091: User-based Privilege is

Re: [DISCUSS] Sentry roadmap after 2.0

2018-01-25 Thread Alexander Kolbasov
Thanks for the link - it is nice to integrate this discussion with JIRA keywords. Looks like we need to go through the list and add categorize it into short-term and long-term buckets. I think Sergio's idea of doing smaller releases with small number of features included makes sense. We can vote

Re: [DISCUSS] Sentry roadmap after 2.0

2018-01-25 Thread Sergio Pena
There is a section on the Wiki about roadmap ideas and JIRAs already created: https://cwiki.apache.org/confluence/display/SENTRY/Sentry+Roadmap+and+ideas I'm interested in having user-level privileges and special user privileges for objects owners. I got this from the linked above: SENTRY-1073

Re: [DISCUSS] Sentry roadmap after 2.0

2018-01-25 Thread Kalyan Kumar Kalvagadda
I would like to add something here. 1. Current support for user-based-privileges allows admin to grant a role to user. Ideally, user-based-privileges feature should be allowing administrator to grant privileges to individual users directly. - I'm working on this to come up with a

Re: [DISCUSS] Sentry roadmap after 2.0

2018-01-25 Thread Alexander Kolbasov
Good point. There is some support for user-level privileges in 2.0 already - do you think that it is not sufficient and is missing some parts? Is there anyone reading this who participated in the user-level privileges in Sentry work done earlier? Is there any design doc for this? - Alex On Thu,

Re: [DISCUSS] Sentry roadmap after 2.0

2018-01-25 Thread Na Li
Sasha, It would be nice to have more features for sentry. For example, make user-based privileges working. So user can assign user directly to a role instead of through group. Lina On Thu, Jan 25, 2018 at 11:58 AM, Alexander Kolbasov wrote: > Now that we have Sentry 2.0

[DISCUSS] Sentry roadmap after 2.0

2018-01-25 Thread Alexander Kolbasov
Now that we have Sentry 2.0 release, I think it is a good time to step back from fixing bugs and immediate problems and start discussions on roadmap for Sentry going forward. Do we want to just keep it as is and improve things here and there or we want to add new features? What do people think?

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

2018-01-25 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/ --- (Updated Jan. 25, 2018, 5 p.m.) Review request for sentry, Alexander Kolbasov,

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-01-25 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/#review196263 ---

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-01-25 Thread kalyan kumar kalvagadda via Review Board
> On Jan. 25, 2018, 12:35 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java > > Line 231 (original), 246 (patched) > >