Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-01-29 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/#review196494 ---

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

2018-01-29 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/ --- (Updated Jan. 30, 2018, 1:08 a.m.) Review request for sentry, Alexander

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

2018-01-29 Thread kalyan kumar kalvagadda via Review Board
> On Jan. 22, 2018, 8:27 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 358 (patched) > > > > > > since we get max notification ID

Question about user-level privileges

2018-01-29 Thread Alexander Kolbasov
I am wondering what is the relationship between "users" as defined in Sentry and users as defined in Unix or LDAP or Active Directory. Should it be allowed to assign permissions to a user that doesn't exist? Should there be any validation if users? Should these be treated together or

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-01-29 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/ --- (Updated Jan. 29, 2018, 9:34 p.m.) Review request for sentry, Arjun Mishra, Na

Re: Review Request 64452: SENTRY-2091: User-based Privilege is broken by SENTRY-769

2018-01-29 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64452/#review196465 ---

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-01-29 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/#review196463 ---

Re: Review Request 65388: SENTRY-2124 LeaderStatusMonitor.toString() throws IllegalFormatConversionException with AtomicLong

2018-01-29 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65388/#review196461 --- Ship it! Ship It! - kalyan kumar kalvagadda On Jan. 29,

Re: Review Request 65388: SENTRY-2124 LeaderStatusMonitor.toString() throws IllegalFormatConversionException with AtomicLong

2018-01-29 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65388/#review196460 --- Ship it! Ship It! - Steve Moist On Jan. 29, 2018, 4:51

Re: permission request to edit sentry web page

2018-01-29 Thread Na Li
Colm, Thanks, Lina On Sat, Jan 27, 2018 at 10:37 AM, Colm O hEigeartaigh wrote: > You should be good now - make sure to log off first + then log on again. > > Colm. > > On Fri, Jan 26, 2018 at 5:47 PM, Na Li wrote: > > > Colm, > > > > My cwiki

Re: Review Request 65388: SENTRY-2124 LeaderStatusMonitor.toString() throws IllegalFormatConversionException with AtomicLong

2018-01-29 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65388/#review196439 --- Ship it! - Arjun Mishra On Jan. 29, 2018, 4:51 p.m., Xinran

Re: Review Request 65388: SENTRY-2124 LeaderStatusMonitor.toString() throws IllegalFormatConversionException with AtomicLong

2018-01-29 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65388/#review196438 --- Ship it! Ship It! - Sergio Pena On Jan. 29, 2018, 4:51

Re: Review Request 64452: SENTRY-2091: User-based Privilege is broken by SENTRY-769

2018-01-29 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64452/#review196435 ---

Review Request 65388: SENTRY-2124 LeaderStatusMonitor.toString() throws IllegalFormatConversionException with AtomicLong

2018-01-29 Thread Xinran Tinney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65388/ --- Review request for sentry, Alexander Kolbasov, Arjun Mishra, Colm O

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

2018-01-29 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/ --- (Updated Jan. 29, 2018, 3:47 p.m.) Review request for sentry, Alexander