Re: Review Request 65715: SENTRY-1720: Re-enable or remove TestHDFSIntegrationWithHA

2018-02-21 Thread Xinran Tinney
> On Feb. 21, 2018, 6:16 p.m., Sergio Pena wrote: > > Why is the TestHDFSIntegration.java deleted? I see it has other tests in > > that class. I am not sure, if we still need it, I will resubmit the patch. - Xinran --- This is an

Re: Review Request 65715: SENTRY-1720: Re-enable or remove TestHDFSIntegrationWithHA

2018-02-21 Thread Xinran Tinney
> On Feb. 21, 2018, 7:11 p.m., kalyan kumar kalvagadda wrote: > > Xinren, > > > > > > Can you hold on on this patch. I had a patch before which extends the HA > > functionality to sentry tests. That patch was not commiited because of test > > failures. > > Instead of deleteting it I would

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

2018-02-21 Thread Na Li via Review Board
> On Feb. 21, 2018, 5:13 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Lines 137-140 (patched) > >

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

2018-02-21 Thread Na Li via Review Board
> On Feb. 21, 2018, 5:13 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Lines 137-140 (patched) > >

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

2018-02-21 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/ --- (Updated Feb. 22, 2018, 1:28 a.m.) Review request for sentry, Alexander

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-02-21 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/#review198081 ---

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

2018-02-21 Thread Sergio Pena via Review Board
> On Feb. 21, 2018, 5:13 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Lines 137-140 (patched) > >

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

2018-02-21 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/#review197995 --- I'm not sure if sentry has a test that performs a table rename

Re: Review Request 65533: SENTRY-2115: Incorrect behavior of HMsFollower when HDFSSync feature is disabled.

2018-02-21 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65533/#review198073 --- Ship it! Ship It! - Sergio Pena On Feb. 21, 2018, 6:45

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-02-21 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/#review198040 ---

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

2018-02-21 Thread Na Li via Review Board
> On Feb. 21, 2018, 7:01 p.m., kalyan kumar kalvagadda wrote: > > I'm not sure if sentry has a test that performs a table rename and > > immediatly peforms an hive operation that uses the new table name. I did a > > quick search and did not find any. > > If sentry doesn't have them we need to

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

2018-02-21 Thread Na Li via Review Board
> On Feb. 21, 2018, 5:13 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Lines 137-140 (patched) > >

Re: Review Request 65715: SENTRY-1720: Re-enable or remove TestHDFSIntegrationWithHA

2018-02-21 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65715/#review198001 --- Xinren, Can you hold on on this patch. I had a patch before

Re: Review Request 65641: SENTRY-853 Handle show grant on failure correctly

2018-02-21 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65641/#review197979 --- Ship it! Got it, Thanks Steve. - Sergio Pena On Feb. 13,

Re: Review Request 65533: SENTRY-2115: Incorrect behavior of HMsFollower when HDFSSync feature is disabled.

2018-02-21 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65533/ --- (Updated Feb. 21, 2018, 6:45 p.m.) Review request for sentry, Alexander

Re: Review Request 64259: SENTRY-1572 SentryMain() shouldn't dynamically load tool class

2018-02-21 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64259/#review197974 --- Ship it! Thanks Xinran, then I think this change is correct as

Re: Review Request 65715: SENTRY-1720: Re-enable or remove TestHDFSIntegrationWithHA

2018-02-21 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65715/#review197973 --- Why is the TestHDFSIntegration.java deleted? I see it has other

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

2018-02-21 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/#review197936 ---

FINAL REMINDER: CFP for Apache EU Roadshow Closes 25th February

2018-02-21 Thread Sharan F
Hello Apache Supporters and Enthusiasts This is your FINAL reminder that the Call for Papers (CFP) for the Apache EU Roadshow is closing soon. Our Apache EU Roadshow will focus on Cloud, IoT, Apache Tomcat, Apache Http and will run from 13-14 June 2018 in Berlin. Note that the CFP deadline

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

2018-02-21 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/ --- (Updated Feb. 21, 2018, 4:52 p.m.) Review request for sentry, Alexander

Re: Review Request 65533: SENTRY-2115: Incorrect behavior of HMsFollower when HDFSSync feature is disabled.

2018-02-21 Thread Na Li via Review Board
> On Feb. 20, 2018, 8:28 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollower.java > > Line 336 (original), 354 (patched) > > > > > >