Re: about rename table across database

Lina, I have not checked your changes yet, I can take a look tomorrow. On Tue, Apr 10, 2018 at 5:04 PM, Na Li wrote: > Sasha, > > are you OK with my code change in https://reviews.apache.org/r/65768/? > > Thanks, > > Lina > > On Tue, Apr 10, 2018 at 6:54 PM, Kalyan Kumar Kalvagadda < > kkal...

Re: about rename table across database

Sasha, are you OK with my code change in https://reviews.apache.org/r/65768/? Thanks, Lina On Tue, Apr 10, 2018 at 6:54 PM, Kalyan Kumar Kalvagadda < kkal...@cloudera.com> wrote: > alter table could do couple of things > 1. alter the table name (alter table db1.tb1 rename to db1.tb2) > 2. mov

Re: about rename table across database

alter table could do couple of things 1. alter the table name (alter table db1.tb1 rename to db1.tb2) 2. move the table from one database to another one (alter table db1.tb2 rename to db2.tb2;) 3. both (alter table db1.tb2 rename to db2.tb3) >From what I understand, difference in prevDbName and ne

Re: about rename table across database

Sasha, We can. And I added the test case in e2e tests, and it works. On Tue, Apr 10, 2018 at 5:34 PM, Alexander Kolbasov wrote: > I think you are right - there is no reason to do that. I am not sure > whether we can actually have changed DB name in ALTER TABLE event at all. > > On Tue, Apr 10,

Sentry-jdk-1.8 - Build # 13 - Fixed

The Apache Jenkins build system has built Sentry-jdk-1.8 (build #13) Status: Fixed Check console output at https://builds.apache.org/job/Sentry-jdk-1.8/13/ to view the results.

Re: about rename table across database

I think you are right - there is no reason to do that. I am not sure whether we can actually have changed DB name in ALTER TABLE event at all. On Tue, Apr 10, 2018 at 12:58 PM, Na Li wrote: > Sasha, > > > In FullUpdateModifier.alterTable(), why did you have the section that > "Walk through all t

Re: Review Request 65768: SENTRY-2144: Table Rename should allow database name change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65768/#review200840 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

about rename table across database

Sasha, In FullUpdateModifier.alterTable(), why did you have the section that "Walk through all tables and rename DB part of the AUTH name"? This is alter table processing, so we should only process one table, not all tables in a database. Also, in NotificationProcessor, we don't change all table

Re: Review Request 65768: SENTRY-2144: Table Rename should allow database name change

> On March 14, 2018, 6:33 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateModifier.java > > Line 363 (original), 363 (patched) > > > >

Re: Review Request 65768: SENTRY-2144: Table Rename should allow database name change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65768/ --- (Updated April 10, 2018, 7:22 p.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 66360: SENTRY-2192: supress date value in @Generated annotation generated by thrift

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66360/#review200827 --- Ship it! Ship It! - Na Li On April 10, 2018, 2:16 p.m., kaly

Sentry-jdk-1.8 - Build # 12 - Unstable

The Apache Jenkins build system has built Sentry-jdk-1.8 (build #12) Status: Unstable Check console output at https://builds.apache.org/job/Sentry-jdk-1.8/12/ to view the results.

Re: Review Request 66360: SENTRY-2192: supress date value in @Generated annotation generated by thrift

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66360/ --- (Updated April 10, 2018, 2:16 p.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 65768: SENTRY-2144: Table Rename should allow database name change

> On March 14, 2018, 6:33 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateModifier.java > > Line 363 (original), 363 (patched) > > > >