Re: Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

2018-05-02 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/ --- (Updated May 3, 2018, 3:49 a.m.) Review request for sentry, Alexander Kolbasov,

Re: Review Request 66910: SENTRY-2215: Remove unused SentryGrantRevokeTask class

2018-05-02 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66910/#review202312 --- Can you add link to jira? - Na Li On May 2, 2018, 5:17 p.m., Se

Re: Review Request 66910: SENTRY-2215: Remove unused SentryGrantRevokeTask class

2018-05-02 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66910/#review202311 --- sentry-dist/src/license/THIRD-PARTY.properties Line 31 (original)

Re: Review Request 66837: SENTRY-2170: Update the Sentry-HDFS thrift for user level privileges.

2018-05-02 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66837/ --- (Updated May 2, 2018, 7:15 p.m.) Review request for sentry, Na Li and Sergio Pe

Re: Review Request 66837: SENTRY-2170: Update the Sentry-HDFS thrift for user level privileges.

2018-05-02 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66837/#review202293 --- sentry-hdfs/sentry-hdfs-common/src/main/resources/sentry_hdfs_ser

Re: Review Request 66792: SENTRY-1949: Old full snapshots are never cleaned up

2018-05-02 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66792/#review202290 --- Na Li It might be useful if we follow some ideas from this blog ab

Review Request 66910: SENTRY-2215: Remove unused SentryGrantRevokeTask class

2018-05-02 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66910/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. Bu

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

2018-05-02 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202280 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoo

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

2018-05-02 Thread Ben Iglauer via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202279 --- By isEmpty(), do you mean to exclude URIs that are blank but not e

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

2018-05-02 Thread Arjun Mishra via Review Board
> On May 2, 2018, 2:09 p.m., Ben Iglauer wrote: > > Does SentryHiveConstants.PRIVILEGE_NOT_SUPPORTED end in a space? If not, > > SentryHiveConstants.PRIVILEGE_NOT_SUPPORTED + "to EMPTY URI path" will not > > be formatted correctly. Yes it does. See here: public static final String PRIVILEGE_NO

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

2018-05-02 Thread Ben Iglauer via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202277 --- Does SentryHiveConstants.PRIVILEGE_NOT_SUPPORTED end in a space? I