Review Request 69122: SENTRY-2432: The case of a username is ignored when determining object ownership

2018-10-22 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69122/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio Pen

Re: Review Request 68926: SENTRY-2372: SentryStore should not implement grantOptionCheck

2018-10-22 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68926/ --- (Updated Oct. 22, 2018, 7:16 p.m.) Review request for sentry and kalyan kumar k

Re: Review Request 68926: SENTRY-2372: SentryStore should not implement grantOptionCheck

2018-10-22 Thread Sergio Pena via Review Board
> On Oct. 22, 2018, 3:40 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Lines 356 (patched) > > > > > > is it possib

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

2018-10-22 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68973/#review209892 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

2018-10-22 Thread kalyan kumar kalvagadda via Review Board
> On Oct. 22, 2018, 4:18 p.m., Sergio Pena wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java > > Lines 152 (patched) > > > > > > how can we make this varia

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

2018-10-22 Thread Arjun Mishra via Review Board
> On Oct. 22, 2018, 4:18 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 3478 (original), 3493 (patched) > > > >

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

2018-10-22 Thread Arjun Mishra via Review Board
> On Oct. 22, 2018, 4:18 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 3510 (patched) > > > > > > Aren't

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

2018-10-22 Thread Arjun Mishra via Review Board
> On Oct. 22, 2018, 4:18 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 3481 (original), 3496 (patched) > > > >

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

2018-10-22 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68973/#review209879 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

2018-10-22 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68973/#review209865 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/se

Re: Review Request 68926: SENTRY-2372: SentryStore should not implement grantOptionCheck

2018-10-22 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68926/#review209866 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

2018-10-22 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68973/ --- (Updated Oct. 22, 2018, 2:42 p.m.) Review request for sentry, Arjun Mishra, Na