Review Request 46058: SENTRY-480: Create import tool that will load policy file about Solr into the DB store

2016-04-11 Thread Gregory Chanan
invalid.ini PRE-CREATION sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryConfigToolSolr.java PRE-CREATION Diff: https://reviews.apache.org/r/46058/diff/ Testing --- Ran the unit tests successfully. Thanks, Gregory Chanan

Re: Notification for brancning Sentry 1.7.0 release

2016-04-13 Thread Gregory Chanan
Are commits allowed again? I assume so, since I've seen some, but I didn't see a notification on this list. Thanks, Greg On Mon, Apr 11, 2016 at 11:04 PM, Hao Hao wrote: > Hi All, > >The official branching for Sentry 1.7.0 is about to start. Please hold > off any commits until it is finish

Re: Review Request 46058: SENTRY-480: Create import tool that will load policy file about Solr into the DB store

2016-04-13 Thread Gregory Chanan
s.apache.org/r/46058/diff/ Testing --- Ran the unit tests successfully. Thanks, Gregory Chanan

Re: Notification for brancning Sentry 1.7.0 release

2016-04-13 Thread Gregory Chanan
rs so they get e-mails sent to both lists? Greg On Wed, Apr 13, 2016 at 7:52 PM, Ma, Junjie wrote: > Hi Greg, > > I forward the notification from Hao to you. > > Best regards, > > Colin Ma(Ma Jun Jie) > > -----Original Message- > From: Gregory Chanan [mailto:gch

Re: Notification for brancning Sentry 1.7.0 release

2016-04-13 Thread Gregory Chanan
o). Now as far > as I know everything should be sent to dev@sentry.apache.org, as > dev@sentry.incubator should be deprecated. Thanks! > > Best, > Hao > > On Wed, Apr 13, 2016 at 7:59 PM, Gregory Chanan > wrote: > > > Thanks! > > > > It looks like th

Review Request 46548: SENTRY-1212: Small authorization and compatibility checking bugs in Sentry conversion tool

2016-04-21 Thread Gregory Chanan
/sentry/provider/db/generic/tools/TestSentryConfigToolSolr.java 7149f17ae11b96fad279a652a2ea7d7848e97d59 Diff: https://reviews.apache.org/r/46548/diff/ Testing --- Ran the new test. Thanks, Gregory Chanan

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericServiceClientDefaultImpl.

2016-05-02 Thread Gregory Chanan
backend layer? It seems unlikely to me that the average client actually wants caching or need caching, whereas an arbitrary external service probably does. - Gregory Chanan On May 2, 2016, 9:32 p.m., Ashish Singh wrote: > > --- >

Review Request 46912: SENTRY-1228: SimpleFileProviderBackend error message missing spaces

2016-05-02 Thread Gregory Chanan
--- Thanks, Gregory Chanan

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericServiceClientDefaultImpl.

2016-05-02 Thread Gregory Chanan
> On May 2, 2016, 9:45 p.m., Gregory Chanan wrote: > > Why put the caching at the client layer instead of the provider backend > > layer? It seems unlikely to me that the average client actually wants > > caching or need caching, whereas an arbitrary external servi

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericServiceClientDefaultImpl.

2016-05-02 Thread Gregory Chanan
> On May 2, 2016, 9:45 p.m., Gregory Chanan wrote: > > Why put the caching at the client layer instead of the provider backend > > layer? It seems unlikely to me that the average client actually wants > > caching or need caching, whereas an arbitrary external servi

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericServiceClientDefaultImpl.

2016-05-02 Thread Gregory Chanan
ry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientDefaultImpl.java (line 668) <https://reviews.apache.org/r/46909/#comment195399> Use nanoTime, see here for more information: http://memorynotfound.com/calculating-elapsed-time-java/ (you can still take millis as

Re: Fwd: Sentry web server - Spnego

2016-05-05 Thread Gregory Chanan
Have you tried enabling kerberos debugging on the server side? On May 5, 2016 10:50 AM, "Sravya Tirukkovalur" wrote: > Forwarding it to dev@s.a.o instead of dev@s.i.a.o > > -- Forwarded message -- > From: Sravya Tirukkovalur > Date: Fri, Apr 29, 2016 at 2:51 PM > Subject: Sentry

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

2016-05-06 Thread Gregory Chanan
acy of system timers and schedulers"...sort of unclear if that means the cache will be updated in that time; but that's not a high precision thing we really care about, so I'd just be loose with it. Also, "sleepIfCachingEnabled" I would expect to...sleep if caching was

Review Request 47084: SENTRY-1233: Logging improvements to SentryConfigToolSolr

2016-05-06 Thread Gregory Chanan
/47084/diff/ Testing --- Manually tested, verified that the message is printed to the log. Thanks, Gregory Chanan

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

2016-05-07 Thread Gregory Chanan
ovider-file/src/main/java/org/apache/sentry/provider/file/SimpleFileProviderBackend.java (line 233) <https://reviews.apache.org/r/46909/#comment196316> you shouldn't be writting the cache directly, just build the temp table and create the cache + cache provider backend with that. Go

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

2016-05-12 Thread Gregory Chanan
> On May 8, 2016, 4:35 a.m., Gregory Chanan wrote: > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/CacheProvider.java, > > line 23 > > <https://reviews.apache.org/r/46909/diff/6/?file=1375790#file1375790line23> &g

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

2016-05-12 Thread Gregory Chanan
;https://reviews.apache.org/r/46909/#comment197247> same here. sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/TableCache.java (line 70) <https://reviews.apache.org/r/46909/#comment197248&g

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

2016-05-13 Thread Gregory Chanan
e/sentry/provider/file/SimpleFileProviderBackend.java (line 331) <https://reviews.apache.org/r/46909/#comment197478> just return the internal cache here, get rid of getCache() function. - Gregory Chanan On May 13, 2016, 4:20 p.m., Ashish Singh wrote: > >

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

2016-05-13 Thread Gregory Chanan
/#comment197491> this should be cache.getCache(). Right now you are using internal knowledge of how the TableCache works -- if you just use cache.getCache you can swap out the TableCache implementation and this will still work. - Gregory Chanan On May 13, 2016, 9:08 p.m.,

Re: Review Request 46909: SENTRY-1229: Add caching to SentryGenericProviderBackend.

2016-05-13 Thread Gregory Chanan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46909/#review133206 --- Ship it! Ship It! - Gregory Chanan On May 13, 2016, 9:27

Review Request 47566: SENTRY-1269: Converter vs Convertor is inconsistent

2016-05-18 Thread Gregory Chanan
f: https://reviews.apache.org/r/47566/diff/ Testing --- Ran the sentry-provider-db unit tests. Thanks, Gregory Chanan

Re: Policy Caching

2016-05-27 Thread Gregory Chanan
Hi Bhooshan, Take a look at SENTRY-1229. It's only supported for the generic service and it makes multiple calls and there's no callback mechanism. But it's a start. Greg On Mon, May 23, 2016 at 4:53 PM, Bhooshan Mogal wrote: > Hi folks, > > I have a product where I want to use Sentry to aut