Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-08-04 Thread Rahul Sharma
/sentry/service/thrift/PoolClientInvocationHandler.java (line 273) <https://reviews.apache.org/r/50578/#comment210914> if (retryCount == connectionRetryTotal Instead of connectionRetryTotal should it not be retryLimit? - Rahul Sharma On Aug. 2, 2016, 9:55 p.m., Hao Hao

Re: Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-07-29 Thread Rahul Sharma
<https://reviews.apache.org/r/50611/#comment210158> Logger for this class? - Rahul Sharma On July 29, 2016, 5:27 p.m., Anne Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 50182: Sentry-1371: Rework Sentry start up and Hive state fetch

2016-07-28 Thread Rahul Sharma
/sentry/service/thrift/SentryService.java (line 169) <https://reviews.apache.org/r/50182/#comment209906> Handle exector shutdown in case of exception? - Rahul Sharma On July 21, 2016, 6:22 a.m., Hao Hao

Re: Review Request 50537: SENTRY-1413:Changes to get the Fencer working with Oracle and MySQL

2016-07-27 Thread Rahul Sharma
with mysql and oracle. Thanks, Rahul Sharma

Review Request 50537: SENTRY-1413:Changes to get the Fencer working with Oracle and MySQL

2016-07-27 Thread Rahul Sharma
-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatus.java e32e1db5bbb92d35ad4063e9410c583231743edf Diff: https://reviews.apache.org/r/50537/diff/ Testing --- Tested fencing with mysql and oracle. Thanks, Rahul Sharma

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-27 Thread Rahul Sharma
eviews.apache.org/r/50404/#review143588 --- On July 26, 2016, 12:18 a.m., Rahul Sharma wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-27 Thread Rahul Sharma
automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50404/#review143579 ------- On July 26, 2016, 12:18 a.m., Rahul Sharma wrote: > > --- > This is an a

Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-25 Thread Rahul Sharma
/sentry/provider/db/service/thrift/TestActivator.java PRE-CREATION sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java PRE-CREATION Diff: https://reviews.apache.org/r/50404/diff/ Testing --- Thanks, Rahul Sharma

Re: Review Request 50264: SENTRY-1331: Add a kerberos end to end test case to access isActive and isHa metrics.

2016-07-22 Thread Rahul Sharma
, Rahul Sharma

Review Request 49522: SENTRY-1378: MAde changes to a make allowed sentry users to be case sensitive.

2016-07-01 Thread Rahul Sharma
cb2d9c9d57e53c40096d6767213212edd829c0f9 Diff: https://reviews.apache.org/r/49522/diff/ Testing --- Added a case. Thanks, Rahul Sharma

Review Request 48736: SENTRY-1319:Add metrics for isActive and isHA

2016-06-15 Thread Rahul Sharma
/tests/e2e/hdfs/TestHDFSIntegration.java 1606b6d97c6696328906100eb10464fdc2fa19e8 Diff: https://reviews.apache.org/r/48736/diff/ Testing --- Thanks, Rahul Sharma

Re: Review Request 48660: SENTRY-1319:Add metrics for isActive and isHA

2016-06-14 Thread Rahul Sharma
erver. JMX client to be implented later. - Rahul --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48660/#review137367 ------- On June 13, 2016, 6:52 p.m., Rahul Sharma wrote: > > -

Re: Review Request 48195: SENTRY-858: Database prefix is not honoured when executing grant statement

2016-06-06 Thread Rahul Sharma
show you release this is a problem. - Rahul --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48195/#review136130 ------- O

Review Request 48217: SENTRY-859: Revoking privileges on a DB removes HDFS ACLs on its table files even if there is a role for one of its tables.

2016-06-03 Thread Rahul Sharma
1606b6d97c6696328906100eb10464fdc2fa19e8 Diff: https://reviews.apache.org/r/48217/diff/ Testing --- Thanks, Rahul Sharma

Review Request 48195: SENTRY-858: Database prefix is not honoured when executing grant statement

2016-06-02 Thread Rahul Sharma
/48195/diff/ Testing --- Thanks, Rahul Sharma