> On July 26, 2016, 6:39 p.m., Anne Yu wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestActivator.java, > > line 42 > > <https://reviews.apache.org/r/50404/diff/2/?file=1452126#file1452126line42> > > > > It would be better to test like the below: > > > > 1. stop the active server; > > 2. assert active server is stopped correctly; give test a time out, in > > case in a freezing mode; > > 3. ensure passive server to become active; meaning the new active > > server is the previous passive one;
So this is just for a single service unit case, to verify that the server is down. I have added a similar case to what you suggest in the TestFailover.java - Rahul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50404/#review143579 ----------------------------------------------------------- On July 26, 2016, 12:18 a.m., Rahul Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50404/ > ----------------------------------------------------------- > > (Updated July 26, 2016, 12:18 a.m.) > > > Review request for sentry, Anne Yu and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > SENTRY-1415: Provide a hook to stop the active sentry sevice > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/Activator.java > 730dbb1b6e290c54ad60a5074009fad778d7b77c > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatus.java > e32e1db5bbb92d35ad4063e9410c583231743edf > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 51dde0e5fcfb9dd93a47351efa3a78692bb60202 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestActivator.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/50404/diff/ > > > Testing > ------- > > > Thanks, > > Rahul Sharma > >