Re: Clarification for MPath changes for SENTRY-1587

2017-04-19 Thread Alexander Kolbasov
Lina, Note that there my be multiple path values, but only a single path value for a given object since paths are stored as a set. The guarantee is provided by set semantics. We do not particularly care about duplicates across multiple objects. - Alex. > On Apr 19, 2017, at 1:09 PM, Na Li wro

Re: Clarification for MPath changes for SENTRY-1587

2017-04-19 Thread Na Li
Sasha, For now, the path entry in DB is owned by each Authz object. The DB change Kalyan made does not guarantee that with the same path value, there is only one instance of such path entry in DB in https://issues.apache.org/jira/browse/SENTRY-1629 (He will address this later). Therefore, there c

Re: Clarification for MPath changes for SENTRY-1587

2017-04-19 Thread Hao Hao
Hi Alex, I changed MPath class to include pathID to have correct MPath equality comparison. Since the original equals() definition only compares 'path' which for different MPath object it may have the same value. For pathID (primary key) assignment I change it to be auto-increment by specifying v

Clarification for MPath changes for SENTRY-1587

2017-04-19 Thread Alexander Kolbasov
Hao, Can you clarify the changes you propose for MPath class and related package.jdo changes for SENTRY-1587? You suggest changing the identity type from "database" to "application", but the pathId is not initialized in constructor and not assigned anywhere. What is your intention here? Also you