Re: Review Request 45260: SENTRY-1159: Decouple datanucleus dependences for hive-binding V1 and V2

2016-03-23 Thread Colin Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45260/#review125218 --- Ship it! Ship It! - Colin Ma On March 24, 2016, 5:41 a.m.,

Re: Review Request 45260: SENTRY-1159: Decouple datanucleus dependences for hive-binding V1 and V2

2016-03-23 Thread Dapeng Sun
> On 三月 24, 2016, 10:04 a.m., Colin Ma wrote: > > Thanks for the patch, I have 2 comments: > > 1. Different versions for datanucleus are included for hive-v1 and hive-v2. > > When package Sentry, the lib will include all these jars, how to avoid the > > conflict? > > 2. test-hive-v1 is enable

Re: Review Request 45260: SENTRY-1159: Decouple datanucleus dependences for hive-binding V1 and V2

2016-03-23 Thread Dapeng Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45260/ --- (Updated 三月 24, 2016, 1:41 p.m.) Review request for sentry and Colin Ma.

Re: Review Request 45260: SENTRY-1159: Decouple datanucleus dependences for hive-binding V1 and V2

2016-03-23 Thread Colin Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45260/#review125178 --- Thanks for the patch, I have 2 comments: 1. Different versions