Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2017-01-09 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/#review160952 --- Ship it! - Hao Hao On Jan. 5, 2017, 8:28 p.m., Alexander Kolb

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2017-01-09 Thread Mat Crocker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/#review160923 --- Ship it! looks like basic try/catch clean up, looks good to me.

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2017-01-05 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/ --- (Updated Jan. 5, 2017, 8:28 p.m.) Review request for sentry, Colin Ma, Hao Hao,

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2017-01-04 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/#review160548 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2016-12-22 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/#review160008 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2016-12-14 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/ --- (Updated Dec. 14, 2016, 11:57 p.m.) Review request for sentry, Colin Ma, Hao Ha

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2016-12-14 Thread Alexander Kolbasov
> On Dec. 14, 2016, 10:50 p.m., Vadim Spector wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java, > > line 154 > > > > > > Timer.Context.stop() per javadoc is equivalen

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2016-12-14 Thread Vadim Spector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/#review159245 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2016-12-14 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/#review159242 --- Ship it! Ship It! - Vamsee Yarlagadda On Dec. 7, 2016, 11:42

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2016-12-07 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/ --- (Updated Dec. 7, 2016, 11:42 p.m.) Review request for sentry, Colin Ma, Hao Hao

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2016-12-07 Thread Alexander Kolbasov
> On Dec. 5, 2016, 8:24 p.m., Vamsee Yarlagadda wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateForwarder.java, > > lines 188-194 > > > > > > A general question outside of this

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2016-12-07 Thread Alexander Kolbasov
> On Dec. 5, 2016, 9:25 p.m., Vadim Spector wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateForwarder.java, > > line 79 > > > > > > do we still need ctors to be public, if we hav

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2016-12-06 Thread kalyan kumar kalvagadda
> On Dec. 5, 2016, 9:25 p.m., Vadim Spector wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateForwarder.java, > > line 192 > > > > > > a) why isn't it an error? > > b) LOGGER.

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2016-12-05 Thread Vadim Spector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/#review158055 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2016-12-05 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/#review158054 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h

Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2016-12-02 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/ --- Review request for sentry, Colin Ma, Hao Hao, kalyan kumar kalvagadda, Vamsee Ya