Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-03-03 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/ --- (Updated March 3, 2017, 9:04 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-03-03 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review167848 --- Fix it, then Ship it! Ship It! sentry-service/sentry-service-

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-03-03 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/ --- (Updated March 3, 2017, 4:41 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-03-02 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review167795 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-03-02 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/ --- (Updated March 2, 2017, 2:44 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-03-01 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review167653 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-03-01 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review167621 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-02-28 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/ --- (Updated Feb. 28, 2017, 2:21 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-02-27 Thread kalyan kumar kalvagadda
> On Dec. 14, 2016, 11:21 p.m., Alexander Kolbasov wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java, > > line 280 > > > > > >

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-02-27 Thread kalyan kumar kalvagadda
> On Jan. 6, 2017, 12:27 a.m., Alexander Kolbasov wrote: > > The change seems to check for other privilege correctness in addition to > > UNSET grant option - are you adding a fix for another problem here as well? This change set has fix for SENTRY-1548 as well. - kalyan kumar -

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-02-27 Thread kalyan kumar kalvagadda
> On Jan. 22, 2017, 6:46 a.m., Alexander Kolbasov wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java, > > line 288 > > > > > >

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-02-27 Thread kalyan kumar kalvagadda
> On Jan. 5, 2017, 6:59 p.m., Vamsee Yarlagadda wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java, > > lines 1082-1085 > > > > >

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-02-27 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/ --- (Updated Feb. 28, 2017, 12:58 a.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-02-27 Thread kalyan kumar kalvagadda
> On Jan. 17, 2017, 6:06 p.m., kalyan kumar kalvagadda wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java, > > line 1052 > > > > >

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-01-21 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review162568 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-01-21 Thread Alexander Kolbasov
> On Jan. 17, 2017, 6:06 p.m., kalyan kumar kalvagadda wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java, > > line 1052 > > > > >

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-01-17 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/ --- (Updated Jan. 17, 2017, 7:28 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-01-17 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review161897 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-01-17 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review161876 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-01-05 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review160654 --- The change seems to check for other privilege correctness in addit

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-01-05 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review160628 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-01-05 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review160612 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-01-05 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/ --- (Updated Jan. 5, 2017, 4:50 p.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2016-12-19 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/ --- (Updated Dec. 20, 2016, 12:07 a.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2016-12-19 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/ --- (Updated Dec. 19, 2016, 11:25 p.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2016-12-16 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review159494 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2016-12-14 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review159250 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2016-12-14 Thread Alexander Kolbasov
> On Dec. 7, 2016, 12:56 a.m., Alexander Kolbasov wrote: > > sentry-service/sentry-service-common/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryGrantOption.java, > > line 16 > > > > > >

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2016-12-14 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/ --- (Updated Dec. 14, 2016, 10:38 p.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2016-12-14 Thread kalyan kumar kalvagadda
> On Dec. 7, 2016, 12:56 a.m., Alexander Kolbasov wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 1431 > > > > > > Why do yo

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2016-12-06 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review158278 --- sentry-service/sentry-service-common/src/gen/thrift/gen-javabean/

Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2016-12-06 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/ --- Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, and V