Re: Review Request 59510: SENTRY-1774 HMSFollower should always depend on persisted information to decide is full snapshot is needed

2017-05-26 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59510/#review176231 --- Fix it, then Ship it! Good idea to make this more generic! se

Re: Review Request 59510: SENTRY-1774 HMSFollower should always depend on persisted information to decide is full snapshot is needed

2017-05-26 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59510/#review176230 --- Ship it! Ship It! - Sergio Pena On May 26, 2017, 9:30 p.m.,

Re: Review Request 59510: SENTRY-1774 HMSFollower should always depend on persisted information to decide is full snapshot is needed

2017-05-26 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59510/ --- (Updated May 26, 2017, 9:30 p.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 59510: SENTRY-1774 HMSFollower should always depend on persisted information to decide is full snapshot is needed

2017-05-26 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59510/#review176227 --- Ship it! Ship It! - Alexander Kolbasov On May 25, 2017, 1:41

Re: Review Request 59510: SENTRY-1774 HMSFollower should always depend on persisted information to decide is full snapshot is needed

2017-05-26 Thread kalyan kumar kalvagadda
> On May 26, 2017, 8:13 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 2890 (patched) > > > > > > The name o

Re: Review Request 59510: SENTRY-1774 HMSFollower should always depend on persisted information to decide is full snapshot is needed

2017-05-26 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59510/#review176222 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 59510: SENTRY-1774 HMSFollower should always depend on persisted information to decide is full snapshot is needed

2017-05-25 Thread kalyan kumar kalvagadda
> On May 24, 2017, 7:56 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 2814 (patched) > > > > > > Acc

Re: Review Request 59510: SENTRY-1774 HMSFollower should always depend on persisted information to decide is full snapshot is needed

2017-05-25 Thread kalyan kumar kalvagadda
> On May 24, 2017, 3:23 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 268 (patched) > > > > > > Is it possible that before previou

Re: Review Request 59510: SENTRY-1774 HMSFollower should always depend on persisted information to decide is full snapshot is needed

2017-05-25 Thread Vamsee Yarlagadda
> On May 24, 2017, 3:23 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 268 (patched) > > > > > > Is it possible that before previou

Re: Review Request 59510: SENTRY-1774 HMSFollower should always depend on persisted information to decide is full snapshot is needed

2017-05-25 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59510/#review176105 --- Ship it! Ship It! - Vamsee Yarlagadda On May 25, 2017, 1:41

Re: Review Request 59510: SENTRY-1774 HMSFollower should always depend on persisted information to decide is full snapshot is needed

2017-05-25 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59510/ --- (Updated May 25, 2017, 1:41 p.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 59510: SENTRY-1774 HMSFollower should always depend on persisted information to decide is full snapshot is needed

2017-05-24 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59510/#review175982 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 59510: SENTRY-1774 HMSFollower should always depend on persisted information to decide is full snapshot is needed

2017-05-24 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59510/#review175939 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Review Request 59510: SENTRY-1774 HMSFollower should always depend on persisted information to decide is full snapshot is needed

2017-05-23 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59510/ --- Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, Ser