Re: Review Request 60926: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

2017-07-20 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60926/#review181048 --- Ship it! Ship It! - Alexander Kolbasov On July 19, 2017, 8:1

Re: Review Request 60926: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

2017-07-19 Thread Sergio Pena
> On July 19, 2017, 9:27 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 193-214 (patched) > > > > > > With your c

Re: Review Request 60926: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

2017-07-19 Thread Sergio Pena
> On July 19, 2017, 9:27 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 169 (patched) > > > > > > Currently, HMSF

Re: Review Request 60926: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

2017-07-19 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60926/#review180972 --- Sergio, I might have some more comments. sentry-provider/sentry-

Re: Review Request 60926: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

2017-07-19 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60926/ --- (Updated July 19, 2017, 8:13 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 60926: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

2017-07-19 Thread Sergio Pena
> On July 19, 2017, 5:20 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 97 (patched) > > > > > > Can you achieve the sa

Re: Review Request 60926: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

2017-07-19 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60926/#review180946 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 60926: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

2017-07-18 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60926/#review180881 --- Can we consider a case where we get the notifications from HMS but

Re: Review Request 60926: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

2017-07-18 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60926/ --- (Updated July 18, 2017, 8:23 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 60926: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

2017-07-18 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60926/#review180856 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 60926: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

2017-07-18 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60926/ --- (Updated July 18, 2017, 7:31 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 60926: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

2017-07-18 Thread Brian Towles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60926/#review180850 --- Ship it! Other then LiNas stuff ship it - Brian Towles On Ju

Re: Review Request 60926: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

2017-07-18 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60926/#review180845 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 60926: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

2017-07-18 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60926/ --- (Updated July 18, 2017, 3:20 p.m.) Review request for sentry, Alexander Kolbaso

Review Request 60926: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

2017-07-17 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60926/ --- Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and Na L