Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-12-12 Thread Alexander Kolbasov
> On Dec. 12, 2017, 1:26 a.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestImageRetriever.java > > Line 57 (original), 56 (patched) > > > > > > Not

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-12-12 Thread Arjun Mishra via Review Board
> On Dec. 12, 2017, 1:26 a.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestImageRetriever.java > > Line 57 (original), 56 (patched) > > > > > > Not

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-12-11 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/#review193478 --- Ship it! Ship It!

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-12-11 Thread Arjun Mishra via Review Board
> On Nov. 30, 2017, 3:09 p.m., Xinran Tinney wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 3574-3580 (patched) > > > > > >

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-11-30 Thread Xinran Tinney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/#review192298 ---

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-11-29 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/ --- (Updated Nov. 29, 2017, 5:23 p.m.) Review request for sentry, Alexander

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-11-29 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/ --- (Updated Nov. 29, 2017, 5:22 p.m.) Review request for sentry, Alexander

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-11-29 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/ --- (Updated Nov. 29, 2017, 5:20 p.m.) Review request for sentry, Alexander

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-11-28 Thread Vadim Spector via Review Board
> On Nov. 28, 2017, 10:16 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Line 2514 (original), 2513 (patched) > >

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-11-28 Thread Arjun Mishra via Review Board
> On Nov. 28, 2017, 10:16 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Line 2514 (original), 2513 (patched) > >

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-11-28 Thread Vadim Spector via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/#review192068 ---

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-11-28 Thread Vadim Spector via Review Board
> On Nov. 28, 2017, 10:16 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Line 2514 (original), 2513 (patched) > >

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-11-27 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/ --- (Updated Nov. 27, 2017, 6 p.m.) Review request for sentry, Alexander Kolbasov,

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-11-06 Thread Arjun Mishra via Review Board
> On Nov. 6, 2017, 10:11 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 2453 (patched) > > > > > > In

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-11-06 Thread Arjun Mishra via Review Board
> On Nov. 6, 2017, 10:11 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 2453 (patched) > > > > > > In

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-11-06 Thread Vadim Spector via Review Board
> On Nov. 6, 2017, 10:11 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 2453 (patched) > > > > > > In

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-11-06 Thread Arjun Mishra via Review Board
> On Nov. 6, 2017, 10:11 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 2453 (patched) > > > > > > In

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-11-06 Thread Arjun Mishra via Review Board
> On Nov. 6, 2017, 10:11 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 2453 (patched) > > > > > > In