Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors

2017-11-09 Thread Alexander Kolbasov
> On Nov. 9, 2017, 2:56 p.m., kalyan kumar kalvagadda wrote: > > What is the issue we are observing when this id is not set? When timeout exception occurs, id is not set. This is a mandatory field, so Thrift creates its own exception which replaces the original timeout exception. As a result,

Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors

2017-11-09 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63647/#review190589 --- What is the issue we are observing when this id is not set? -

Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors

2017-11-08 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63647/#review190472 --- Ship it! Ship It! - Sergio Pena On Nov. 7, 2017, 9:58 p.m.,

Review Request 63647: SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors

2017-11-07 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63647/ --- Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, and