Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/#review196651 --- Ship it! Ship It! - Vadim Spector On Jan. 30, 2018, 1:08

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/ --- (Updated Jan. 30, 2018, 1:08 a.m.) Review request for sentry, Alexander

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

> On Jan. 22, 2018, 8:27 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 358 (patched) > > > > > > since we get max notification ID

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/ --- (Updated Jan. 29, 2018, 3:47 p.m.) Review request for sentry, Alexander

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

> On Jan. 25, 2018, 11:42 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > > Line 235 (original), 270 (patched) > > > > >

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

> On Jan. 25, 2018, 11:42 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > > Line 235 (original), 270 (patched) > > > > >

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/#review196297 ---

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/#review196289 ---

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

> On Jan. 22, 2018, 8:49 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > > Lines 231 (patched) > > > > > > optimization

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/ --- (Updated Jan. 25, 2018, 5 p.m.) Review request for sentry, Alexander Kolbasov,

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

> On Jan. 22, 2018, 8:49 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > > Lines 67 (patched) > > > > > > I wonder about

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

> On Jan. 22, 2018, 8:49 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > > Line 60 (original), 61 (patched) > > > > > >

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

> On Jan. 22, 2018, 8:49 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > > Lines 67 (patched) > > > > > > I wonder about

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

> On Jan. 22, 2018, 8:49 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > > Lines 67 (patched) > > > > > > I wonder about

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/#review195917 ---

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/#review195928 ---

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/ --- (Updated Jan. 22, 2018, 5:40 p.m.) Review request for sentry, Alexander

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

> On Jan. 19, 2018, 1:06 a.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > > Lines 205 (patched) > > > > > > this section

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/#review195758 ---

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

> On Jan. 8, 2018, 4:35 p.m., Arjun Mishra wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 357 (patched) > > > > > > Can we make this WARN?

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/ --- (Updated Jan. 17, 2018, 11:56 p.m.) Review request for sentry, Alexander

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

> On Jan. 4, 2018, 10:40 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 205 (original), 206 (patched) > > > > > > I thought

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

> On Jan. 4, 2018, 10:40 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 205 (original), 206 (patched) > > > > > > I thought

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/ --- (Updated Jan. 5, 2018, 12:10 a.m.) Review request for sentry, Alexander

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/#review194788 ---

Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/ --- Review request for sentry, Alexander Kolbasov, Arjun Mishra, Na Li, Sergio