Re: Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

2018-07-09 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67846/#review205868 --- Ship it! Ship It! - kalyan kumar kalvagadda On July 9, 2018,

Re: Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

2018-07-09 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67846/ --- (Updated July 9, 2018, 7:28 p.m.) Review request for sentry. Repository: sent

Re: Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

2018-07-09 Thread Steve Moist via Review Board
> On July 9, 2018, 5:53 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathDeltaRetriever.java > > Line 20 (original), 20 (patched) > > > > > > Shouldn't this

Re: Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

2018-07-09 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67846/ --- (Updated July 9, 2018, 7:17 p.m.) Review request for sentry. Repository: sent

Re: Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

2018-07-09 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67846/#review205860 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h

Re: Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

2018-07-06 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67846/#review205821 --- Fix it, then Ship it! Fix it. sentry-binding/sentry-binding-h

Re: Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

2018-07-06 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67846/ --- (Updated July 6, 2018, 7:06 p.m.) Review request for sentry. Repository: sent

Re: Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

2018-07-06 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67846/#review205809 --- sentry-binding/sentry-binding-hive/pom.xml Lines 63-68 (patched)

Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

2018-07-06 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67846/ --- Review request for sentry. Repository: sentry Description --- Excluding