On Sat, Dec 26, 2020 at 11:09:41PM +0100, Lucas Nussbaum wrote:
> Source: serf
> Version: 1.3.9-8
> [...]
> > Trailer-Test: f
> > ...F..
> >
> > There was 1 failure:
> > 1) test_ssl_handshake: test/test_util.c:456: expected <0> but was <1
Thanks. I expect that this might be due to the last change - erroring out
on an expired self-signed root cert. Though I thought we didn’t check in a
root cert for our test chain...could Debian’s packaging be including a cert
for testing?
I will try to take a look this week with Debian sid...I as
On Sun, Dec 27, 2020 at 10:46:24AM -0500, Justin Erenkrantz wrote:
> Thanks. I expect that this might be due to the last change - erroring out on
> an expired self-signed root cert. Though I thought we didn’t check in a root
> cert for our test chain...could Debian’s packaging be including a cert
As an update, I've been able to triage this a bit further.
It's definitely that last noted change (erroring out on expired self-signed
root) that broke it. OpenSSL 1.1.1{g,h} are fine, but {i,-stable} are
not. Reverting just x509_vfy.c to what is in 1.1.1h causes the test to
pass.
In this test
On Mon, Dec 28, 2020 at 5:00 PM Justin Erenkrantz
wrote:
> It's not clear to me if OpenSSL authors intended to make this breaking
> change. On the serf side, we would need to think through what it would
> mean to have our app callback return false upon failure in order to
> short-circuit the che
The OpenSSL devs intended this to be a breaking change - but it's not
documented anywhere. Sigh.
I've got a WIP patch against trunk that causes test_ssl to pass - see
below. It also seems to work with OpenSSL 1.1.1h as well as OpenSSL 1.1.1i
/ 1.1.1-stable, AFAICT.
James: can you please give it
On 29.12.2020 22:35, Justin Erenkrantz wrote:
The OpenSSL devs intended this to be a breaking change - but it's not
documented anywhere. Sigh.
I've got a WIP patch against trunk that causes test_ssl to pass - see
below. It also seems to work with OpenSSL 1.1.1h as well as OpenSSL 1.1.1i
/ 1.1.
On Tue, Dec 29, 2020 at 02:35:11PM -0500, Justin Erenkrantz wrote:
> The OpenSSL devs intended this to be a breaking change - but it's not
> documented anywhere. Sigh.
>
> I've got a WIP patch against trunk that causes test_ssl to pass - see below.
> It also seems to work with OpenSSL 1.1.1h as
Happy New Year!
On Wed, Dec 30, 2020 at 10:39:28PM -0500, James McCoy wrote:
> On Tue, Dec 29, 2020 at 02:35:11PM -0500, Justin Erenkrantz wrote:
> > The OpenSSL devs intended this to be a breaking change - but it's not
> > documented anywhere. Sigh.
> >
> > I've got a WIP patch against trunk th
Sadly, my Debian sid box ran into other issues and is currently
inaccessible.
I *think* that this would address the 1.3.x test issues, but 1.3.x doesn't
build on Mac OS for me for other reasons...so, let me know how it goes?
=) -- justin
Index: test/test_context.c
===
On Fri, Jan 15, 2021 at 08:36:22AM -0500, Justin Erenkrantz wrote:
> Sadly, my Debian sid box ran into other issues and is currently inaccessible.
>
> I *think* that this would address the 1.3.x test issues, but 1.3.x doesn't
> build on Mac OS for me for other reasons...so, let me know how it goes
On Fri, Jan 15, 2021 at 9:13 PM James McCoy wrote:
> On Fri, Jan 15, 2021 at 08:36:22AM -0500, Justin Erenkrantz wrote:
> > Sadly, my Debian sid box ran into other issues and is currently
> inaccessible.
> >
> > I *think* that this would address the 1.3.x test issues, but 1.3.x
> doesn't
> > buil
12 matches
Mail list logo
