RE: svn commit: r1713489 - serf_bucket_readline()

2015-11-10 Thread Bert Huijben
> -Original Message- > From: Bert Huijben [mailto:b...@qqmail.nl] > Sent: dinsdag 10 november 2015 23:37 > To: 'Ivan Zhakov' ; rhuij...@apache.org > Cc: dev@serf.apache.org > Subject: RE: svn commit: r1713489 - in /serf/trunk: buckets/event_buckets.c > outgoing.c serf_private.h > > > >

Re: svn commit: r1713489 - serf_bucket_readline()

2015-11-11 Thread Ivan Zhakov
On 11 November 2015 at 01:44, Bert Huijben wrote: >> -Original Message- >> From: Bert Huijben [mailto:b...@qqmail.nl] >> Sent: dinsdag 10 november 2015 23:37 >> To: 'Ivan Zhakov' ; rhuij...@apache.org >> Cc: dev@serf.apache.org >> Subject: RE: svn commit: r1713489 - in /serf/trunk: buckets

Re: svn commit: r1713489 - serf_bucket_readline()

2015-11-11 Thread Greg Stein
On Wed, Nov 11, 2015 at 6:21 AM, Ivan Zhakov wrote: >... > How is event bucket situation different from barrier bucket for example? > Barrier buckets wrap a bucket and pass all methods through to it. They do *not* destroy the wrapped bucket when the barrier is destroyed. Event bucket is a zero-

Re: svn commit: r1713489 - serf_bucket_readline()

2015-11-11 Thread Ivan Zhakov
On 11 November 2015 at 18:34, Greg Stein wrote: > On Wed, Nov 11, 2015 at 6:21 AM, Ivan Zhakov wrote: >>... >> >> How is event bucket situation different from barrier bucket for example? > > > Barrier buckets wrap a bucket and pass all methods through to it. They do > *not* destroy the wrapped bu

RE: svn commit: r1713489 - serf_bucket_readline()

2015-11-11 Thread Bert Huijben
> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: woensdag 11 november 2015 13:22 > To: Bert Huijben > Cc: rhuij...@apache.org; dev@serf.apache.org > Subject: Re: svn commit: r1713489 - serf_bucket_readline() > > On 11 November 201

Re: svn commit: r1713489 - serf_bucket_readline()

2015-11-11 Thread Greg Stein
On Wed, Nov 11, 2015 at 10:51 AM, Bert Huijben wrote: > > > > -Original Message- > > From: Ivan Zhakov [mailto:i...@visualsvn.com] > > Sent: woensdag 11 november 2015 13:22 > > To: Bert Huijben > > Cc: rhuij...@apache.org; dev@serf.apache.org &

Re: svn commit: r1713489 - serf_bucket_readline()

2015-11-11 Thread Ivan Zhakov
On 11 November 2015 at 19:51, Bert Huijben wrote: >> -Original Message- >> From: Ivan Zhakov [mailto:i...@visualsvn.com] >> Sent: woensdag 11 november 2015 13:22 >> To: Bert Huijben >> Cc: rhuij...@apache.org; dev@serf.apache.org >&g

RE: svn commit: r1713489 - serf_bucket_readline()

2015-11-14 Thread Bert Huijben
> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: woensdag 11 november 2015 18:01 > To: Bert Huijben > Cc: rhuij...@apache.org; dev@serf.apache.org > Subject: Re: svn commit: r1713489 - serf_bucket_readline() > > On 11 November 201

Re: svn commit: r1713489 - serf_bucket_readline()

2015-11-14 Thread Ivan Zhakov
On 14 November 2015 at 12:06, Bert Huijben wrote: >> -Original Message- >> From: Ivan Zhakov [mailto:i...@visualsvn.com] >> Sent: woensdag 11 november 2015 18:01 >> To: Bert Huijben >> Cc: rhuij...@apache.org; dev@serf.apache.org >&g

RE: svn commit: r1713489 - serf_bucket_readline()

2015-11-14 Thread Bert Huijben
> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: zaterdag 14 november 2015 10:19 > To: Bert Huijben > Cc: rhuij...@apache.org; dev@serf.apache.org > Subject: Re: svn commit: r1713489 - serf_bucket_readline() > > > I'm startin

limited readline (was: svn commit: r1713489 - serf_bucket_readline())

2015-11-11 Thread Greg Stein
On Tue, Nov 10, 2015 at 4:44 PM, Bert Huijben wrote: >... > There is one more problem with all this wrapping: All layers need to > somehow support all read methods. > > Wrapping works for all methods except: readline. > If all methods are passed to the wrapped bucket, then readline works fine.

Re: limited readline (was: svn commit: r1713489 - serf_bucket_readline())

2015-11-11 Thread Greg Stein
And I see you built this in '788. (catching up here) On Wed, Nov 11, 2015 at 10:05 AM, Greg Stein wrote: > On Tue, Nov 10, 2015 at 4:44 PM, Bert Huijben wrote: > >... > >> There is one more problem with all this wrapping: All layers need to >> somehow support all read methods. >> >> Wrapping w

RE: limited readline (was: svn commit: r1713489 - serf_bucket_readline())

2015-11-11 Thread Bert Huijben
Hi Greg, Thanks for your reply. > -Original Message- > From: Greg Stein [mailto:gst...@gmail.com] > Sent: woensdag 11 november 2015 17:05 > To: dev@serf.apache.org > Subject: limited readline (was: svn commit: r1713489 - > serf_bucket_readline()) > > On T

Re: limited readline (was: svn commit: r1713489 - serf_bucket_readline())

2015-11-11 Thread Greg Stein
On Wed, Nov 11, 2015 at 11:00 AM, Bert Huijben wrote: >... > > -Original Message- > > From: Greg Stein [mailto:gst...@gmail.com] > > Sent: woensdag 11 november 2015 17:05 > > To: dev@serf.apache.org > > Subject: limited readline (was: svn commit: r1

RE: limited readline (was: svn commit: r1713489 - serf_bucket_readline())

2015-11-11 Thread Bert Huijben
readline (was: svn commit: r1713489 - serf_bucket_readline()) On Wed, Nov 11, 2015 at 11:00 AM, Bert Huijben mailto:b...@qqmail.nl> > wrote: >... > -Original Message- > From: Greg Stein [mailto:gst...@gmail.com <mailto:gst...@gmail.com> ] > Sent: woensdag 11 novem

RE: limited readline (was: svn commit: r1713489 - serf_bucket_readline())

2015-11-11 Thread Bert Huijben
gt; To: dev@serf.apache.org <mailto:dev@serf.apache.org> > Subject: limited readline (was: svn commit: r1713489 - > serf_bucket_readline()) >... > I believe the correct answer is that limit-type buckets need to peek first, > look for CR and/or LF, and then read() that much