[GitHub] maheshrajus commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation

2018-03-20 Thread GitBox
maheshrajus commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/615#discussion_r175984119 ## File path:

[GitHub] maheshrajus commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation

2018-03-20 Thread GitBox
maheshrajus commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/615#discussion_r175984140 ## File path:

[GitHub] liubao68 commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation

2018-03-20 Thread GitBox
liubao68 commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/615#discussion_r175968036 ## File path:

[GitHub] liubao68 commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation

2018-03-20 Thread GitBox
liubao68 commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/615#discussion_r175968036 ## File path:

[GitHub] liubao68 commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation

2018-03-20 Thread GitBox
liubao68 commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/615#discussion_r175969413 ## File path:

[GitHub] liubao68 commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation

2018-03-20 Thread GitBox
liubao68 commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/615#discussion_r175968717 ## File path:

[GitHub] liubao68 commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation

2018-03-20 Thread GitBox
liubao68 commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/615#discussion_r175968036 ## File path:

[GitHub] liubao68 commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation

2018-03-20 Thread GitBox
liubao68 commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/615#discussion_r175968036 ## File path:

[GitHub] liubao68 commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation

2018-03-20 Thread GitBox
liubao68 commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/615#discussion_r175967421 ## File path:

[GitHub] liubao68 commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation

2018-03-20 Thread GitBox
liubao68 commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/615#discussion_r175966834 ## File path:

Re: [RESULT] [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt

2018-03-20 Thread Willem Jiang
Hi Roman, Current we just published the binary to the dev directory[1] for vote, not the official release directory[2]. I think Asif just means publishing the release kit publically as a the official release once the vote passed. [1]

[GitHub] liubao68 commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation

2018-03-20 Thread GitBox
liubao68 commented on a change in pull request #615: [SCB-324] Fault-Injection handler implementation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/615#discussion_r175966624 ## File path:

Re: [RESULT] [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt

2018-03-20 Thread Roman Shaposhnik
On Mon, Mar 19, 2018 at 8:53 PM, Mohammad Asif Siddiqui wrote: > Hi All, > > We will send this Release Candidate for IPMC approval, Once the vote passes > there then we will publish the binaries. You can NOT do that. If binaries are to be published they need to be

[GitHub] maheshrajus opened a new pull request #615: [SCB-324] Fault-Injection handler implementation

2018-03-20 Thread GitBox
maheshrajus opened a new pull request #615: [SCB-324] Fault-Injection handler implementation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/615 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Third Attempt

2018-03-20 Thread bismy
+1 (binding) Integrate the release candidate to internal integration tests and all test cases passed. -- Original -- From: "Mohammad Asif Siddiqui"; Date: Tue, Mar 20, 2018 05:33 PM To: "dev"; Subject:

Re: 回复: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0- Second Attempt

2018-03-20 Thread Jean-Baptiste Onofré
+1 (binding) Build is ok. Signatures and headers are good too. Regards JB Le 20 mars 2018 à 14:36, à 14:36, bismy a écrit: >+1 Non Binding >Building from source in linux, and run demos and tests according to >README.md, all test cases passed. > > >-- 原始邮件

?????? [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0- Second Attempt

2018-03-20 Thread bismy
+1 Non Binding Building from source in linux, and run demos and tests according to README.md, all test cases passed. -- -- ??: "Zen Lin"; : 2018??3??19??(??) 4:22 ??: "dev";

[GitHub] WillemJiang closed pull request #156: SCB-390 Update to introduece the byteman to the acceptance tests

2018-03-20 Thread GitBox
WillemJiang closed pull request #156: SCB-390 Update to introduece the byteman to the acceptance tests URL: https://github.com/apache/incubator-servicecomb-saga/pull/156 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] WillemJiang commented on a change in pull request #156: SCB-390 Update to introduece the byteman to the acceptance tests

2018-03-20 Thread GitBox
WillemJiang commented on a change in pull request #156: SCB-390 Update to introduece the byteman to the acceptance tests URL: https://github.com/apache/incubator-servicecomb-saga/pull/156#discussion_r175702856 ## File path: saga-demo/booking/booking/pom.xml ## @@ -77,6

[GitHub] WillemJiang commented on a change in pull request #156: SCB-390 Update to introduece the byteman to the acceptance tests

2018-03-20 Thread GitBox
WillemJiang commented on a change in pull request #156: SCB-390 Update to introduece the byteman to the acceptance tests URL: https://github.com/apache/incubator-servicecomb-saga/pull/156#discussion_r175702856 ## File path: saga-demo/booking/booking/pom.xml ## @@ -77,6

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Third Attempt

2018-03-20 Thread Mohammad Asif Siddiqui
On 2018/03/20 09:33:47, Mohammad Asif Siddiqui wrote: > + Binding +1 Binding > > I checked > - incubating in name > - hashes and signatures is good > - DISCLAIMER/NOTICE/LICENSE exists > - can make release kit from source > - checked for archive

Re: [SAGA] introduce the byteman to the acceptance tests

2018-03-20 Thread Zheng Feng
You can use the multi-steps in the acceptance test. e.g. Given Install byteman script timeout.btm to Car Service Given Install byteman script timeout.btm to Hotel Service Given Install byteman script timeout.btm to Booking Service 2018-03-20 15:25 GMT+08:00 Willem Jiang

Re: [SAGA] introduce the byteman to the acceptance tests

2018-03-20 Thread Willem Jiang
Yeah, it's great feature that we can leverage. Thanks for Feng zheng's contribution. Now my question is do we only support submit the byteman rule for one service? Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang

[GitHub] liubao68 commented on a change in pull request #594: [SCB-379] support AsyncRestTemplate

2018-03-20 Thread GitBox
liubao68 commented on a change in pull request #594: [SCB-379] support AsyncRestTemplate URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/594#discussion_r175666547 ## File path:

[SAGA] introduce the byteman to the acceptance tests

2018-03-20 Thread Zheng Feng
Hi all, I just send the PR [1] to introduce the byteman[2] to our acceptance tests. The byteman could be used to inject the fault into the java classes. The PR includes 1. unpack the byteman.jar into the ${project.output.directory}/saga which can be assembled into the docker image. 2. set the

[GitHub] coveralls commented on issue #156: SCB-390 Update to introduece the byteman to the acceptance tests

2018-03-20 Thread GitBox
coveralls commented on issue #156: SCB-390 Update to introduece the byteman to the acceptance tests URL: https://github.com/apache/incubator-servicecomb-saga/pull/156#issuecomment-374489236 [![Coverage

[GitHub] zhfeng opened a new pull request #156: SCB-390 Update to introduece the byteman to the acceptance tests

2018-03-20 Thread GitBox
zhfeng opened a new pull request #156: SCB-390 Update to introduece the byteman to the acceptance tests URL: https://github.com/apache/incubator-servicecomb-saga/pull/156 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a