Re: About introduce Lombok to service comb

2018-08-22 Thread Willem Jiang
We could specify it in the environment setup document. @Cherry Could you share the experience of Lombok usage in sharding sphere? Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Aug 22, 2018 at 2:13 PM, wjm wjm wrote: > everyone clone our code, if need to load by IDE, must install t

Re:[DISCUSS]Add a local or embedded interface to call Saga

2018-08-22 Thread ????????????
SCSagaSQLFormatDesign.png This picture is my design for embedded interface to call Saga. In the design, we need to extend TYPE_SQL=sql in Operation interface and JsonSubTypes in JsonSagaRequest interface. And we need to add some classes to match the new json we defined before. we also can reuse

Re:[DISCUSS]Add a local or embedded interface to call Saga

2018-08-22 Thread ????????????
sorry, the image link seems to be invalid. https://raw.githubusercontent.com/KomachiSion/incubator-servicecomb-saga/share/docs/static_files/SCSagaDesign.png -- -- ??: ""; : 2018??8??22??(??) 3:49 ??: "dev"; : Re:[

Re: [DISCUSS]Add a local or embedded interface to call Saga

2018-08-22 Thread Zheng Feng
Nice work and I think you could raise the JIRA on https://issues.apache.org/jira/browse/SCB for this new feature. Good luck with the implementation ! 2018-08-22 15:49 GMT+08:00 新道场开张了 : > SCSagaSQLFormatDesign.png > > > This picture is my design for embedded interface to call Saga. > In the desi

Re: [DISCUSS]Add a local or embedded interface to call Saga

2018-08-22 Thread Willem Jiang
Just a quick question about the Operation's TYPE_SQL? I'm not sure if it is relate to the Operation that Saga already defined. BTW, you can create a JIRA and attached the UML design document to it. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Aug 22, 2018 at 3:51 PM, 新道场开张了 wrote

Re:[DISCUSS]Add a local or embedded interface to call Saga

2018-08-22 Thread ????????????
Yes, it is relate to the Operation that Saga already defined in saga-core. I just want to add a new String named TYPE_SQL like TYPE_REST and TYPE_NOP. The TYPE_SQL may be used by JsonSagaRequest interface to let Jackson find the implement class based on 'type' property. Some questions about JIRA

Re: [SCB-856] about try interface in saga-transaction manager

2018-08-22 Thread cherrylzhao
I have made some comment on SCB-856(https://issues.apache.org/jira/browse/SCB-856 ) Please feel free to provide some suggest. > On 8 Aug 2018, at 9:25 AM, bismy wrote: > > Our customer want to use this feature too, and I'd like to join and find s

Re: [DISCUSS]Add a local or embedded interface to call Saga

2018-08-22 Thread Willem Jiang
I just created a new issue[1] for this new feature, please feel free to create sub task to track you task. [1]https://issues.apache.org/jira/browse/SCB-864 Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Aug 22, 2018 at 5:07 PM, 新道场开张了 wrote: > Yes, it is relate to the Operation th

Saga load test & comparison

2018-08-22 Thread Lance Ju
Hi, team, I've made a simple test on saga performances, with 3 *Test scenarios:* - Disable omega(run the original business without saga) - Enable omega and handle saga events in Redis - Enable omega and handle saga events in PostgreSQL * The test environment:* - 3 Virtual

Re: [DISCUSSION] add Github button in navigation banner of servicecomb website

2018-08-22 Thread Lance Ju
I can't see the banner, would you share the images' URL, Kirin? Willem Jiang 于2018年8月22日周三 上午10:50写道: > We have the github reference here[1], and it could be great that we have > some banner for all the repos that we have in the home page. > > http://servicecomb.incubator.apache.org/developers/

Re: Proposal for holding a Apache ServiceComb(incubating) meetup as a Co-Located Event in HC 2018

2018-08-22 Thread Lance Ju
+1 non-binding Kirin Wang 于2018年8月22日周三 上午9:45写道: > +1 non-binding > > 2018-08-21 16:09 GMT+08:00, Zen Lin : > > This is a Proposal for holding a Co-Located Event in HC 2018[1] to help > > building ServiceComb's community. > > > > HC 2018 is a conference hosted by Huawei, have nearly 1000 summit

答复: Proposal for holding a Apache ServiceComb(incubating) meetup as a Co-Located Event in HC 2018

2018-08-22 Thread YangYongZheng
+1 non-binding Best Regards! YangYongZheng -邮件原件- 发件人: Zen Lin [mailto:zenlintechnofr...@gmail.com] 发送时间: 2018年8月21日 16:09 收件人: dev 抄送: Sally Khudairi 主题: Proposal for holding a Apache ServiceComb(incubating) meetup as a Co-Located Event in HC 2018 This is a Proposal for holding a

Re: Saga load test & comparison

2018-08-22 Thread Willem Jiang
Just a quick note for the test case background, all the tests are based on the saga-spring-demo[1] In this demo, the booking service calls the car service and the hotel service, all of these tests don't have any database option. It looks the pack (Omega and Alpha) introduced some overhead for the

Re: Proposal for holding a Apache ServiceComb(incubating) meetup as a Co-Located Event in HC 2018

2018-08-22 Thread Willem Jiang
Yeah, it's great that we can host this kind of meeting here. If there is no other objection, let's start the vote for this meetup. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Tue, Aug 21, 2018 at 4:09 PM, Zen Lin wrote: > This is a Proposal for holding a Co-Located Event in HC 2018[

Re: [DISCUSSION] add Github button in navigation banner of servicecomb website

2018-08-22 Thread Kirin Wang
Hi lance: you can view my test website: https://wangkirin.github.io/ to see the result Lance Ju 于2018年8月22日周三 下午9:36写道: > I can't see the banner, would you share the images' URL, Kirin? > > Willem Jiang 于2018年8月22日周三 上午10:50写道: > > > We have the github reference here[1], and it coul

Re: [DISCUSSION] add Github button in navigation banner of servicecomb website

2018-08-22 Thread Willem Jiang
I don't think we can keep adding the links to the upper banner, if the screen size is smaller, we cannot guarantee all the links are displayed. How about we can add the github repo links just after latest release links. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Thu, Aug 23, 2018 at 9

?????? About introduce Lombok to service comb

2018-08-22 Thread bismy
In my opinion, I'd prefer not include Lombok in our project. Here my reasons: 1. It's a convenient tool to write getters and setters, users can include it very easily to their projects. 2. For framework, I'd prefer our class do not use Lombok annotations. Because write getters/setters is very pot

Re: About introduce Lombok to service comb

2018-08-22 Thread 赵俊
Hi we often use following lombok annotations, it makes our code clean especially existing too many fields. Lombok seems to be very stable for us so far. 1.@Getter, @Setter 2. @RequiredAgsConstructor 3. @NoArgsConstructor(access = AccessLevel.PRIVATE) 4. @Slf4j 5. @EqualsAndHashCode 6. @ToString

[DISCUSS]add The Sources Panel In Schema Test

2018-08-22 Thread Sure
Now, shema test in the sc frontend does not contain the schema source, then the developer can not debug it coveniently. So, I suggest add a source panel to shema test