[GitHub] yhs0092 opened a new pull request #660: [SCB-453] Read config from application yaml properties

2018-04-19 Thread GitBox
yhs0092 opened a new pull request #660: [SCB-453] Read config from application yaml properties URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/660 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [J

[GitHub] zhengyangyong commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

2018-04-19 Thread GitBox
zhengyangyong commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182739600 ## File path: spring-boot-starter/spring-boot-starter

[GitHub] zhengyangyong commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

2018-04-19 Thread GitBox
zhengyangyong commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182740480 ## File path: spring-boot-starter/spring-boot-starter

[GitHub] coveralls commented on issue #651: [SCB-498] Configuration Center ip address need to config default port

2018-04-19 Thread GitBox
coveralls commented on issue #651: [SCB-498] Configuration Center ip address need to config default port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#issuecomment-381932927 [![Coverage Status](https://coveralls.io/builds/16597412/badge)](https://coveralls

[GitHub] weichao666 commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port

2018-04-19 Thread GitBox
weichao666 commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#discussion_r182720344 ## File path: foundations/foundation-common/src/main/java/o

[GitHub] weichao666 commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port

2018-04-19 Thread GitBox
weichao666 commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#discussion_r182720412 ## File path: foundations/foundation-common/src/main/java/o

[GitHub] weichao666 commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port

2018-04-19 Thread GitBox
weichao666 commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#discussion_r182673233 ## File path: foundations/foundation-common/src/main/java/o

[GitHub] weichao666 commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port

2018-04-19 Thread GitBox
weichao666 commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#discussion_r182673233 ## File path: foundations/foundation-common/src/main/java/o

[GitHub] liubao68 commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port

2018-04-19 Thread GitBox
liubao68 commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#discussion_r182670732 ## File path: foundations/foundation-common/src/main/java/org

[GitHub] liubao68 commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port

2018-04-19 Thread GitBox
liubao68 commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#discussion_r182670564 ## File path: foundations/foundation-common/src/main/java/org

[GitHub] wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

2018-04-19 Thread GitBox
wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182439746 ## File path: spring-boot-starter/spring-boot-starter-disco

[GitHub] jeho0815 commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis

2018-04-19 Thread GitBox
jeho0815 commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r182653130 ## File path: transports/transport-rest/transport-rest-vertx/src/test/java/org/apache/serv

[GitHub] asifdxtreme commented on issue #328: [SCB-479] Add proxy to service-center in frontend

2018-04-19 Thread GitBox
asifdxtreme commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-382634015 @yangbor Does the current implementation holds if service-center and frontend is running in the same d

[GitHub] coveralls commented on issue #653: [SCB-483] Springmvc rest vertx file download

2018-04-19 Thread GitBox
coveralls commented on issue #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#issuecomment-382072555 [![Coverage Status](https://coveralls.io/builds/16592696/badge)](https://coveralls.io/builds/16592696)

[GitHub] wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download

2018-04-18 Thread GitBox
wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182644564 ## File path: common/common-rest/src/main/java/org/apache/servicecomb/common/rest/filte

[GitHub] wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download

2018-04-18 Thread GitBox
wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182643228 ## File path: demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb

[GitHub] keepongjl opened a new issue #659: 是否考虑支持函数重载

2018-04-18 Thread GitBox
keepongjl opened a new issue #659: 是否考虑支持函数重载 URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/659 现在的Provider不支持函数重载(契约生成会报错Caused by: java.lang.Error: OperationId must be unique),是否考虑支持函数重载? This is

[GitHub] coveralls commented on issue #651: [SCB-498] Configuration Center ip address need to config default port

2018-04-18 Thread GitBox
coveralls commented on issue #651: [SCB-498] Configuration Center ip address need to config default port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#issuecomment-381932927 [![Coverage Status](https://coveralls.io/builds/16590450/badge)](https://coveralls

[GitHub] yangbor commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis

2018-04-18 Thread GitBox
yangbor commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r182619742 ## File path: transports/transport-rest/transport-rest-vertx/src/test/java/org/apache/servi

[GitHub] weichao666 commented on issue #651: [SCB-498] Configuration Center ip address need to config default port

2018-04-18 Thread GitBox
weichao666 commented on issue #651: [SCB-498] Configuration Center ip address need to config default port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#issuecomment-382585058 modified This is an

[GitHub] liubao68 commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule

2018-04-18 Thread GitBox
liubao68 commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/657#issuecomment-382582463 I am using eclipse and all compile warnings fixed except http

[GitHub] liubao68 commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download

2018-04-18 Thread GitBox
liubao68 commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182612283 ## File path: common/common-rest/src/main/java/org/apache/servicecomb/common/rest/filt

[GitHub] liubao68 commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download

2018-04-18 Thread GitBox
liubao68 commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182611014 ## File path: demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecom

[GitHub] WillemJiang closed pull request #175: SCB-505 Update to throw exception when the transaction timeout

2018-04-18 Thread GitBox
WillemJiang closed pull request #175: SCB-505 Update to throw exception when the transaction timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/175 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the s

[GitHub] coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout

2018-04-18 Thread GitBox
coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/175#issuecomment-382423621 [![Coverage Status](https://coveralls.io/builds/16579027/badge)](https://coveralls.io/builds/1657

[GitHub] coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout

2018-04-18 Thread GitBox
coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/175#issuecomment-382423621 [![Coverage Status](https://coveralls.io/builds/16578966/badge)](https://coveralls.io/builds/1657

[GitHub] coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout

2018-04-18 Thread GitBox
coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/175#issuecomment-382423621 [![Coverage Status](https://coveralls.io/builds/16578938/badge)](https://coveralls.io/builds/1657

[GitHub] WillemJiang commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

2018-04-18 Thread GitBox
WillemJiang commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182465491 ## File path: spring-boot-starter/spring-boot-starter-d

[GitHub] zhfeng opened a new pull request #175: SCB-505 Update to throw exception when the transaction timeout

2018-04-18 Thread GitBox
zhfeng opened a new pull request #175: SCB-505 Update to throw exception when the transaction timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/175 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JI

[GitHub] wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

2018-04-18 Thread GitBox
wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182439746 ## File path: spring-boot-starter/spring-boot-starter-disco

[GitHub] wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

2018-04-18 Thread GitBox
wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182437916 ## File path: spring-boot-starter/spring-boot-starter-discov

[GitHub] wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

2018-04-18 Thread GitBox
wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182439425 ## File path: spring-boot-starter/spring-boot-starter-disco

[GitHub] Rajadeepan commented on issue #648: [SCB-482] Http2 support for java-chassis

2018-04-18 Thread GitBox
Rajadeepan commented on issue #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#issuecomment-382374604 commit added for UT and IT This is an automated me

[GitHub] coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis

2018-04-18 Thread GitBox
coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#issuecomment-381568126 [![Coverage Status](https://coveralls.io/builds/16575497/badge)](https://coveralls.io/builds/16575497) Co

[GitHub] coveralls commented on issue #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

2018-04-18 Thread GitBox
coveralls commented on issue #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#issuecomment-382350160 [![Coverage Status](https://coveralls.io/builds/16574872/badge)](https://covera

[GitHub] zhengyangyong opened a new pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

2018-04-18 Thread GitBox
zhengyangyong opened a new pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contributi

[GitHub] coveralls commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule

2018-04-18 Thread GitBox
coveralls commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/657#issuecomment-382318550 [![Coverage Status](https://coveralls.io/builds/16573156

[GitHub] wujimin commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule

2018-04-18 Thread GitBox
wujimin commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/657#issuecomment-382310371 paste compile warning check image please.

[GitHub] liubao68 opened a new pull request #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule

2018-04-18 Thread GitBox
liubao68 opened a new pull request #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/657 Follow this checklist to help us incorporate your contribution quickly and

[GitHub] coveralls commented on issue #653: [SCB-483] Springmvc rest vertx file download

2018-04-18 Thread GitBox
coveralls commented on issue #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#issuecomment-382072555 [![Coverage Status](https://coveralls.io/builds/16572229/badge)](https://coveralls.io/builds/16572229)

[GitHub] wujimin commented on issue #653: [SCB-483] Springmvc rest vertx file download

2018-04-18 Thread GitBox
wujimin commented on issue #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#issuecomment-382290341 add a new commit: "set correct content-type for download"

[GitHub] zhengyangyong commented on issue #644: 新版的release编译包啥时候放出来啊?

2018-04-17 Thread GitBox
zhengyangyong commented on issue #644: 新版的release编译包啥时候放出来啊? URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/644#issuecomment-382250055 you can donwload from apache , http://apache.org/dyn/closer.cgi/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-

[GitHub] zhengyangyong commented on issue #656: bmi项目的log日志没有输出

2018-04-17 Thread GitBox
zhengyangyong commented on issue #656: bmi项目的log日志没有输出 URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/656#issuecomment-382249813 log4j2.xml in bmi is useless since 1.0.0-m1,you can create a JIRA and submit a PR remove(fix) it -

[GitHub] coveralls commented on issue #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
coveralls commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-380735106 [![Coverage Status](https://coveralls.io/builds/16570100/badge)](https://coveralls.io/builds/1657010

[GitHub] codecov-io commented on issue #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
codecov-io commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-380735171 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr&el=h1) R

[GitHub] coveralls commented on issue #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
coveralls commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-380735106 [![Coverage Status](https://coveralls.io/builds/16570059/badge)](https://coveralls.io/builds/1657005

[GitHub] codecov-io commented on issue #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
codecov-io commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-380735171 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr&el=h1) R

[GitHub] coveralls commented on issue #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
coveralls commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-380735106 [![Coverage Status](https://coveralls.io/builds/16570047/badge)](https://coveralls.io/builds/1657004

[GitHub] msnetc opened a new issue #656: bmi项目的log日志没有输出

2018-04-17 Thread GitBox
msnetc opened a new issue #656: bmi项目的log日志没有输出 URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/656 windows 机器:E:\dev\logs\ 启动后,日志并没有输出 This is an automated message from the Apache Git Service.

[GitHub] wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download

2018-04-17 Thread GitBox
wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182296939 ## File path: foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundat

[GitHub] wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download

2018-04-17 Thread GitBox
wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182294530 ## File path: common/common-rest/src/main/java/org/apache/servicecomb/common/rest/Abstr

[GitHub] WillemJiang commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download

2018-04-17 Thread GitBox
WillemJiang commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182294300 ## File path: foundations/foundation-vertx/src/main/java/org/apache/servicecomb/fou

[GitHub] msnetc opened a new issue #655: rpc模式下生成swagger-ui文档

2018-04-17 Thread GitBox
msnetc opened a new issue #655: rpc模式下生成swagger-ui文档 URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/655 bug: rpc模式下,如果request 参数是complexttype, 甚至我直接声明一个简单对象,都不能生成swager-ui文档。 很多场合下,项目的请求参数有多个:如companyid,userid,token等。这样情况下如果一个方法传递多个参数,是一直用很不好的设计方式。 所以:我需要rpc模

[GitHub] WillemJiang commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download

2018-04-17 Thread GitBox
WillemJiang commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182291768 ## File path: common/common-rest/src/main/java/org/apache/servicecomb/common/rest/A

[GitHub] WillemJiang commented on issue #654: java-chassis依赖的springboot版本过低

2018-04-17 Thread GitBox
WillemJiang commented on issue #654: java-chassis依赖的springboot版本过低 URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/654#issuecomment-382219074 spring boot 1.5.x的最新版是1.5.12 (升级很快), 我们会先验证1.5.x,应用本身还是需要能够重载spring boot的版本。 -

[GitHub] crystaldust commented on issue #174: Add guide on how to build and run alpha server

2018-04-17 Thread GitBox
crystaldust commented on issue #174: Add guide on how to build and run alpha server URL: https://github.com/apache/incubator-servicecomb-saga/pull/174#issuecomment-382216387 Yea, the database is required to run alpha server, but the Postgresql is a very generic image and all the documents

[GitHub] msnetc opened a new issue #654: java-chassis依赖的springboot版本过低

2018-04-17 Thread GitBox
msnetc opened a new issue #654: java-chassis依赖的springboot版本过低 URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/654 我们项目需要springboot版本是1.5.9, 而java-chassis的版本低于1.5.9, 是否能考虑升级到1.5.9。 This is a

[GitHub] WillemJiang closed pull request #174: Add guide on how to build and run alpha server

2018-04-17 Thread GitBox
WillemJiang closed pull request #174: Add guide on how to build and run alpha server URL: https://github.com/apache/incubator-servicecomb-saga/pull/174 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenanc

[GitHub] WillemJiang commented on issue #174: Add guide on how to build and run alpha server

2018-04-17 Thread GitBox
WillemJiang commented on issue #174: Add guide on how to build and run alpha server URL: https://github.com/apache/incubator-servicecomb-saga/pull/174#issuecomment-382202325 @yangbor Please feel free to submit an PR for the prerequisite description of Database. -

[GitHub] WillemJiang commented on issue #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
WillemJiang commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-382201777 @yangbor You can close and reopen the issue to trigger the build. BTW, once you have the committer

[GitHub] codecov-io commented on issue #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
codecov-io commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-380735171 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr&el=h1) R

[GitHub] wujimin commented on issue #652: [SCB 456]Remove warning

2018-04-17 Thread GitBox
wujimin commented on issue #652: [SCB 456]Remove warning URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/652#issuecomment-382082568 only one line changed, why so many commit log? you'd better use rebase not pull git command. ---

[GitHub] wujimin commented on issue #652: [SCB 456]Remove warning

2018-04-17 Thread GitBox
wujimin commented on issue #652: [SCB 456]Remove warning URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/652#issuecomment-382082058 it seems that you did not import intellij-java-google-style.xml This i

[GitHub] wujimin commented on issue #652: [SCB 456]Remove warning

2018-04-17 Thread GitBox
wujimin commented on issue #652: [SCB 456]Remove warning URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/652#issuecomment-382075099 paste compile warning check image please This is an automated message

[GitHub] coveralls commented on issue #653: [SCB-483] Springmvc rest vertx file download

2018-04-17 Thread GitBox
coveralls commented on issue #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#issuecomment-382072555 [![Coverage Status](https://coveralls.io/builds/16561437/badge)](https://coveralls.io/builds/16561437)

[GitHub] wujimin opened a new pull request #653: [SCB-483] Springmvc rest vertx file download

2018-04-17 Thread GitBox
wujimin opened a new pull request #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653 springmvc over rest vertx support file download. ![image](https://user-images.githubusercontent.com/16874843/38883855-aaeaf1ce-

[GitHub] coveralls commented on issue #652: [SCB 456]Remove warning

2018-04-17 Thread GitBox
coveralls commented on issue #652: [SCB 456]Remove warning URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/652#issuecomment-382037053 [![Coverage Status](https://coveralls.io/builds/16559388/badge)](https://coveralls.io/builds/16559388) Coverage increased

[GitHub] jasononion opened a new pull request #652: [SCB 456]Remove warning

2018-04-17 Thread GitBox
jasononion opened a new pull request #652: [SCB 456]Remove warning URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/652 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.ap

[GitHub] coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis

2018-04-17 Thread GitBox
coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#issuecomment-381568126 [![Coverage Status](https://coveralls.io/builds/16558604/badge)](https://coveralls.io/builds/16558604) Co

[GitHub] yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-381947037 @WillemJiang Could you please trigger the CI manually to run the UT again? I created a issue for tra

[GitHub] yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-381937397 The UT succeeded on local build but the following case failed on travis. Need investigation. Upd

[GitHub] yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-381937397 The UT succeeded on local build but the following case failed on travis. Need investigation. Upd

[GitHub] yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-381937397 The UT succeeded on local build but the following case failed on travis. Need investigation. Upd

[GitHub] yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-381937397 The UT succeeded on local build but the following case failed on travis. Need investigation.

[GitHub] coveralls commented on issue #138: SCB-224 retry sub-transaction on failure

2018-04-17 Thread GitBox
coveralls commented on issue #138: SCB-224 retry sub-transaction on failure URL: https://github.com/apache/incubator-servicecomb-saga/pull/138#issuecomment-368816986 [![Coverage Status](https://coveralls.io/builds/16554289/badge)](https://coveralls.io/builds/16554289) Coverage i

[GitHub] coveralls commented on issue #138: SCB-224 retry sub-transaction on failure

2018-04-17 Thread GitBox
coveralls commented on issue #138: SCB-224 retry sub-transaction on failure URL: https://github.com/apache/incubator-servicecomb-saga/pull/138#issuecomment-368816986 [![Coverage Status](https://coveralls.io/builds/16554289/badge)](https://coveralls.io/builds/16554289) Coverage i

[GitHub] yangbor commented on issue #651: [SCB-498] Configuration Center ip address need to config default port

2018-04-17 Thread GitBox
yangbor commented on issue #651: [SCB-498] Configuration Center ip address need to config default port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#issuecomment-381934241 It seems to be the wrong place to fix the problem. the http(80) and https(443) are Well

[GitHub] coveralls commented on issue #651: [SCB-498] Configuration Center ip address need to config default port

2018-04-17 Thread GitBox
coveralls commented on issue #651: [SCB-498] Configuration Center ip address need to config default port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#issuecomment-381932927 [![Coverage Status](https://coveralls.io/builds/16554184/badge)](https://coveralls

[GitHub] coveralls commented on issue #138: SCB-224 retry sub-transaction on failure

2018-04-17 Thread GitBox
coveralls commented on issue #138: SCB-224 retry sub-transaction on failure URL: https://github.com/apache/incubator-servicecomb-saga/pull/138#issuecomment-368816986 [![Coverage Status](https://coveralls.io/builds/16554142/badge)](https://coveralls.io/builds/16554142) Coverage i

[GitHub] coveralls commented on issue #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
coveralls commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-380735106 [![Coverage Status](https://coveralls.io/builds/16554102/badge)](https://coveralls.io/builds/1655410

[GitHub] WillemJiang closed pull request #62: Update quick-start.md change, cd ServiceComb-Java-Chasiss to cd incubator-servicecomb-java-chassis

2018-04-17 Thread GitBox
WillemJiang closed pull request #62: Update quick-start.md change, cd ServiceComb-Java-Chasiss to cd incubator-servicecomb-java-chassis URL: https://github.com/apache/incubator-servicecomb-website/pull/62 This is a PR merged from a forked repository. As GitHub hides the original diff on

[GitHub] WillemJiang commented on issue #62: Update quick-start.md change, cd ServiceComb-Java-Chasiss to cd incubator-servicecomb-java-chassis

2018-04-17 Thread GitBox
WillemJiang commented on issue #62: Update quick-start.md change, cd ServiceComb-Java-Chasiss to cd incubator-servicecomb-java-chassis URL: https://github.com/apache/incubator-servicecomb-website/pull/62#issuecomment-381928235 Sorry, I just did a quick fix for it. The website is updated

[GitHub] WillemJiang commented on issue #62: Update quick-start.md change, cd ServiceComb-Java-Chasiss to cd incubator-servicecomb-java-chassis

2018-04-17 Thread GitBox
WillemJiang commented on issue #62: Update quick-start.md change, cd ServiceComb-Java-Chasiss to cd incubator-servicecomb-java-chassis URL: https://github.com/apache/incubator-servicecomb-website/pull/62#issuecomment-381928235 Sorry, I just did a quick fix for it. -

[GitHub] yangbor commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
yangbor commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#discussion_r182017016 ## File path: frontend/server_test.go ## @@ -0,0 +1,55 @@ +package main

[GitHub] yangbor commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
yangbor commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#discussion_r182016985 ## File path: frontend/server.go ## @@ -0,0 +1,54 @@ +package main R

[GitHub] yangbor commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
yangbor commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#discussion_r182016919 ## File path: frontend/main.go ## @@ -19,34 +19,30 @@ package main imp

[GitHub] yangbor commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
yangbor commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#discussion_r182016919 ## File path: frontend/main.go ## @@ -19,34 +19,30 @@ package main imp

[GitHub] yangbor commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
yangbor commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#discussion_r182016267 ## File path: frontend/main.go ## @@ -19,34 +19,30 @@ package main imp

[GitHub] yangbor commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
yangbor commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#discussion_r182015996 ## File path: frontend/Readme.md ## @@ -41,15 +40,6 @@ go run main.go

[GitHub] wannnafly opened a new pull request #62: Update quick-start.md change, cd ServiceComb-Java-Chasiss to cd incubator-servicecomb-java-chassis

2018-04-17 Thread GitBox
wannnafly opened a new pull request #62: Update quick-start.md change, cd ServiceComb-Java-Chasiss to cd incubator-servicecomb-java-chassis URL: https://github.com/apache/incubator-servicecomb-website/pull/62 This is an au

[GitHub] WillemJiang commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
WillemJiang commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#discussion_r182011933 ## File path: frontend/Readme.md ## @@ -41,15 +40,6 @@ go run main.

[GitHub] weichao666 opened a new pull request #651: [SCB-498] Configuration Center ip address need to config default port

2018-04-17 Thread GitBox
weichao666 opened a new pull request #651: [SCB-498] Configuration Center ip address need to config default port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/651 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make

[GitHub] WillemJiang commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
WillemJiang commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#discussion_r182011224 ## File path: frontend/server_test.go ## @@ -0,0 +1,55 @@ +package

[GitHub] WillemJiang commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
WillemJiang commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#discussion_r182010873 ## File path: frontend/server.go ## @@ -0,0 +1,54 @@ +package main

[GitHub] WillemJiang commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
WillemJiang commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#discussion_r182010669 ## File path: frontend/main.go ## @@ -19,34 +19,30 @@ package main

[GitHub] coveralls commented on issue #138: SCB-224 retry sub-transaction on failure

2018-04-17 Thread GitBox
coveralls commented on issue #138: SCB-224 retry sub-transaction on failure URL: https://github.com/apache/incubator-servicecomb-saga/pull/138#issuecomment-368816986 [![Coverage Status](https://coveralls.io/builds/16552896/badge)](https://coveralls.io/builds/16552896) Coverage i

[GitHub] coveralls commented on issue #138: SCB-224 retry sub-transaction on failure

2018-04-17 Thread GitBox
coveralls commented on issue #138: SCB-224 retry sub-transaction on failure URL: https://github.com/apache/incubator-servicecomb-saga/pull/138#issuecomment-368816986 [![Coverage Status](https://coveralls.io/builds/16552599/badge)](https://coveralls.io/builds/16552599) Coverage i

[GitHub] yangbor commented on issue #174: Add guide on how to build and run alpha server

2018-04-17 Thread GitBox
yangbor commented on issue #174: Add guide on how to build and run alpha server URL: https://github.com/apache/incubator-servicecomb-saga/pull/174#issuecomment-381890558 Postgresql is required before running alpha server, could you please also add a section about starting up the database?

[GitHub] coveralls commented on issue #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
coveralls commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-380735106 [![Coverage Status](https://coveralls.io/builds/16552315/badge)](https://coveralls.io/builds/1655231

[GitHub] codecov-io commented on issue #328: [SCB-479] Add proxy to service-center in frontend

2018-04-17 Thread GitBox
codecov-io commented on issue #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-380735171 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr&el=h1) R

<    4   5   6   7   8   9   10   11   12   13   >