Re: [DISCUSS] merge docs and example repos into trunk repo

2020-02-12 Thread Juan Pan
Hi community, ISSUE [1] concerning doc merging has fixed already. Once redundant branch of sharding-sphere-doc is deleted, there will be a successful end. [1] https://github.com/apache/incubator-shardingsphere/issues/4243 Juan Pan (Trista) Senior DBA & PPMC of

Re: [DISCUSS] merge docs and example repos into trunk repo

2020-02-11 Thread Juan Pan
Hi We find there are some improvements to do for `incubator-shardingsphere/docs`, which i am working on, so once it makes some headway, i will update here. Please refer to issue[1] to learn more. [1] https://github.com/apache/incubator-shardingsphere/issues/4243 Juan Pan (Trista)

Re: [DISCUSS] merge docs and example repos into trunk repo

2020-02-10 Thread 蒋晓峰
Good Job! On Mon, Feb 10, 2020 at 8:58 PM Zhang Yonglun wrote: > incubator-shardingsphere-doc has been merged into > incubator-shardingsphere/docs via > https://github.com/apache/incubator-shardingsphere/pull/4226 > > -- > > Zhang Yonglun > Apache ShardingSphere > > > guangyuan wang 于2020年1月20日

Re: [DISCUSS] merge docs and example repos into trunk repo

2020-02-10 Thread Juan Pan
Great job! Juan Pan (Trista) Senior DBA & PPMC of Apache ShardingSphere(Incubating) E-mail: panj...@apache.org On 02/10/2020 20:58,Zhang Yonglun wrote: incubator-shardingsphere-doc has been merged into incubator-shardingsphere/docs via https://github.com/apache/inc

Re: [DISCUSS] merge docs and example repos into trunk repo

2020-02-10 Thread Zhang Yonglun
incubator-shardingsphere-doc has been merged into incubator-shardingsphere/docs via https://github.com/apache/incubator-shardingsphere/pull/4226 -- Zhang Yonglun Apache ShardingSphere guangyuan wang 于2020年1月20日周一 下午4:58写道: > I think it's a good idea. As I am a contributor whose first contribu

Re: [DISCUSS] merge docs and example repos into trunk repo

2020-01-20 Thread guangyuan wang
I think it's a good idea. As I am a contributor whose first contribution in the sharding sphere is the modification in docs. This will encourage the contributor to participate in the sharding sphere, especially for those new players. Zhiyi Yan 于2020年1月17日周五 下午3:49写道: > +1. Good idea! > It makes

Re: [DISCUSS] merge docs and example repos into trunk repo

2020-01-16 Thread Zhiyi Yan
+1. Good idea! It makes easier to find examples. - Zhiyi Yan (Zhyee) Apache ShardingSphere zhangli...@apache.org 于2020年1月17日周五 下午12:16写道: > Hi ShardingSphere community, > > I'd like to discuss about merge docs[1] and examples[2] repos into the > trunk repo[3]. > > The benefit is encour

Re: [DISCUSS] merge docs and example repos into trunk repo

2020-01-16 Thread zhangli...@apache.org
Hi Trista, > If so, i guess our users would not ask any question concerning examples repo any more. We may create a README.md to describe the project structure, and put independent README.md into docs, example and source code projects. -- Liang Zhang (John) Apache ShardingSphere

Re:[DISCUSS] merge docs and example repos into trunk repo

2020-01-16 Thread Juan Pan
If so, i guess our users would not ask any question concerning examples repo any more. Juan Pan (Trista) Senior DBA & PPMC of Apache ShardingSphere(Incubating) E-mail: panj...@apache.org On 01/17/2020 12:15,zhangli...@apache.org wrote: Hi ShardingSphere community,

Re: [DISCUSS] merge docs and example repos into trunk repo

2020-01-16 Thread zhangli...@apache.org
Docs, examples and source code are 3 different projects. Developer to import them still need 3 diff workspaces. -- Liang Zhang (John) Apache ShardingSphere & Dubbo sunbufu 于2020年1月17日周五 下午2:33写道: > +1 > > > It is easier to find example for new user. > > > — > Haisheng

Re:[DISCUSS] merge docs and example repos into trunk repo

2020-01-16 Thread sunbufu
+1 It is easier to find example for new user. — Haisheng Sun (sunbufu) Apache ShardingSphere On 01/17/2020 14:28,Sion Yang wrote: Nice idea. This can reduce the difference between example and trunk repo. -- Yi Yang(Sion) Apache ShardingSphere At 2020-01-17 12:15:29, "zhangli..

Re:[DISCUSS] merge docs and example repos into trunk repo

2020-01-16 Thread 赵科
+1. Good idea to help newcomers better integrate. At 2020-01-17 12:15:29, "zhangli...@apache.org" wrote: >Hi ShardingSphere community, > >I'd like to discuss about merge docs[1] and examples[2] repos into the >trunk repo[3]. > >The benefit is encourage potential contributors begin from docs

Re:[DISCUSS] merge docs and example repos into trunk repo

2020-01-16 Thread Sion Yang
Nice idea. This can reduce the difference between example and trunk repo. -- Yi Yang(Sion) Apache ShardingSphere At 2020-01-17 12:15:29, "zhangli...@apache.org" wrote: >Hi ShardingSphere community, > >I'd like to discuss about merge docs[1] and examples[2] repos into the >trunk repo[3]. >

Re:[DISCUSS] merge docs and example repos into trunk repo

2020-01-16 Thread Zonglei Dong
+1 I support it. But I suggest that merge docs and example repos doesn’t affect the source code, Because now the source code compile and run all test code need 10+ minutes, it is not convenient to check code before submit PR. Best wishes! Zonglei Dong Apache ShardingSphere On 01/17/2020 13

Re:[DISCUSS] merge docs and example repos into trunk repo

2020-01-16 Thread sushixiang
Good idea! +1 -- Original -- From: "zhangli...@apache.org"https://github.com/apache/incubator-shardingsphere-doc [2] https://github.com/apache/incubator-shardingsphere-example [3] https://github.com/apache/incubator-shardingsphere -- Liang Zhang

Re: [DISCUSS] merge docs and example repos into trunk repo

2020-01-16 Thread Zhang Yonglun
+1 -- Zhang Yonglun Apache ShardingSphere zhaojun 于2020年1月17日周五 下午1:09写道: > +1 > > -- > Zhao Jun (cherrylzhao) > Apache ShardingSphere & ServiceComb > > > On Jan 17, 2020, at 12:18 PM, Raigor Jiang wrote: > > > > It will be nice! agree +1 > > > > > > > > > > On 01/17/2020 12

Re: [DISCUSS] merge docs and example repos into trunk repo

2020-01-16 Thread zhaojun
+1 -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb > On Jan 17, 2020, at 12:18 PM, Raigor Jiang wrote: > > It will be nice! agree +1 > > > > > On 01/17/2020 12:15,zhangli...@apache.org wrote: > Hi ShardingSphere community, > > I'd like to discuss about merge

Re:[DISCUSS] merge docs and example repos into trunk repo

2020-01-16 Thread Raigor Jiang
It will be nice! agree +1 On 01/17/2020 12:15,zhangli...@apache.org wrote: Hi ShardingSphere community, I'd like to discuss about merge docs[1] and examples[2] repos into the trunk repo[3]. The benefit is encourage potential contributors begin from docs and examples. Docs and examples are sa

[DISCUSS] merge docs and example repos into trunk repo

2020-01-16 Thread zhangli...@apache.org
Hi ShardingSphere community, I'd like to discuss about merge docs[1] and examples[2] repos into the trunk repo[3]. The benefit is encourage potential contributors begin from docs and examples. Docs and examples are same important with source codes, it is a good way to decrease the bar to particip