Re: Stacking OpenSocial Containers

2010-03-10 Thread 王超
Very interesting idea. Actually I've personally put some efforts on this idea. Some challenges I've faced includes: 1. Latency. Since these 2 containers might not locate in the same data center (in most of the cases), the data fetching latency could be a serious issue. 2. Security. There need

Re: Calculate response Hash value (issue391042)

2010-03-10 Thread Ziv Horesh
On Mar 10, 2010, at 6:44 PM, chiragsh...@gmail.com wrote: http://codereview.appspot.com/391042/diff/12002/25005 File java/gadgets/src/main/java/org/apache/shindig/gadgets/http/ HttpResponseMetadataHelper.java (right): http://codereview.appspot.com/391042/diff/12002/25005#newcode50 java/gad

Re: Fixing chained syntax parsing when params are at the end of configured path (issue427041)

2010-03-10 Thread John Hjelmstad
Ha, seems reasonable. Added a bunch of commentary on this and committed. On Wed, Mar 10, 2010 at 6:25 PM, wrote: > LGTM > > > http://codereview.appspot.com/427041/diff/1/3 > File > > > java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java > (right): > > http://cod

Re: Calculate response Hash value (issue391042)

2010-03-10 Thread johnfargo
LGTM, committed. http://codereview.appspot.com/391042/show

Re: Fixing chained syntax parsing when params are at the end of configured path (issue427041)

2010-03-10 Thread zhoresh
LGTM http://codereview.appspot.com/427041/diff/1/3 File java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java (right): http://codereview.appspot.com/427041/diff/1/3#newcode185 java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java:1

Fixing chained syntax parsing when params are at the end of configured path (issue427041)

2010-03-10 Thread johnfargo
Reviewers: shindig.remailer_gmail.com, zhoresh, Description: The DefaultProxyUriManagerTest implementation was also not using the process() method to verify parsing behavior, as it ought to have. Changing the logic surfaced the issue. Thanks to Ziv Horesh for taking notice. Please review this a

Re: Calculate response Hash value (issue391042)

2010-03-10 Thread zhoresh
One more time with integration test http://codereview.appspot.com/391042/show

Re: Calculate response Hash value (issue391042)

2010-03-10 Thread johnfargo
Sounds good but don't get rid of the integration test, I'd just like to see the unit test added :) http://codereview.appspot.com/391042/show

Re: Calculate response Hash value (issue391042)

2010-03-10 Thread zhoresh
Update according to john comments http://codereview.appspot.com/391042/show

Re: Calculate response Hash value (issue391042)

2010-03-10 Thread Ziv Horesh
On Wed, Mar 10, 2010 at 4:48 PM, wrote: > > http://codereview.appspot.com/391042/diff/1/2 > File > > > java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java > (right): > > http://codereview.appspot.com/391042/diff/1/2#newcode48 > > java/gadgets/src/main/java/org/a

Re: Calculate response Hash value (issue391042)

2010-03-10 Thread johnfargo
http://codereview.appspot.com/391042/diff/1/2 File java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java (right): http://codereview.appspot.com/391042/diff/1/2#newcode48 java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java:48: Ht

Calculate response Hash value (issue391042)

2010-03-10 Thread zhoresh
Reviewers: shindig.remailer_gmail.com, johnfargo, Description: This feature will be used by the Uri rewritters to create versions for resources. The request pipeline calculates the md5 for each response and store it in the HttpResponse metadata map. The added class HttpResponseMetadataHelper wi

Re: Handle BOM Entity in gadget spec (issue217102)

2010-03-10 Thread johnfargo
LGTM, committed. http://codereview.appspot.com/217102/show

Authen token parsing

2010-03-10 Thread Ziv Horesh
Currently authentication token in Shindig is being parsed as part of AuthenticationServletFilter. The filter stuff the token in the AuthInfo class, so it can be used later. So at this point the token is being parsed weather it is being used or not. We suggest to improve that by deferring the parsi

Stacking OpenSocial Containers

2010-03-10 Thread Niels van Dijk
Hi, Has anyone every tried to introduce a persistent data layer in a container based on another OpenSocial containers content? This could be done by implementing a php or java OpenSocial client in the persistent data layer to consume a remote container's rest api. It would for example be interest

Re: Caja does not support proxy url gadgets (issue380041)

2010-03-10 Thread johnfargo
LGTM http://codereview.appspot.com/380041/diff/8001/9003 File java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java (right): http://codereview.appspot.com/380041/diff/8001/9003#newcode82 java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java:82: if (requ

Re: Caja does not support proxy url gadgets (issue380041)

2010-03-10 Thread jasvir
http://codereview.appspot.com/380041/diff/1/4 File java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java (right): http://codereview.appspot.com/380041/diff/1/4#newcode81 java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java:81: if (gadget.getCurrentView(