Re: Support Cross-Site Request Sharing in Shindig JSONP (issue1109041)

2010-05-04 Thread John Hjelmstad
Thanks Paul, looking forward to the patch. Is the XDomainRequest API something we can/should wrap in gadgets.io.makeRequest in the appropriate context? Suppose I could do a little digging... --j On Tue, May 4, 2010 at 10:42 PM, Paul Lindner wrote: > Safari 4, Chrome 3+ and FF 3.5+. > > IE has s

Re: Support Cross-Site Request Sharing in Shindig JSONP (issue1109041)

2010-05-04 Thread Paul Lindner
Safari 4, Chrome 3+ and FF 3.5+. IE has something similar (XDomainRequest) More here: http://hacks.mozilla.org/2009/07/cross-site-xmlhttprequest-with-cors/ If I had a few spare moments I'd cook something up for browserscope.org (+steve, maybe he knows..) Might be worth it to shove non-cachable

Re: UserPrefsDialog results in jsonp call to http://gmodules.com/ig?

2010-05-04 Thread Paul Lindner
[responding waaay after the fact...] The metadata call is one of the few that does support jsonp. If you've been following along you'll see that the JSON-RPC endpoint supports it now and I have a patch review up for REST support. Next step is to convert the metadata servlet into a proper 'Apps'

Hudson build is back to stable : Shindig #1495

2010-05-04 Thread Apache Hudson Server
See

Hudson build is back to stable : Shindi g » Apache Shindig Gadget Renderer #1495

2010-05-04 Thread Apache Hudson Server
See

Re: [Request || Response]Rewriters, ImageRewriters, and rewriter caching

2010-05-04 Thread John Hjelmstad
Cool -- A) To what degree have you customized the ImageRewriter? Have you made it a pipeline unto itself (ie. with sub-rewriters)? Doing so in a standard way is a motivating factor for these proposals. B) Are you modifying the caching behavior of the existing ImageRewriter pipeline -- namely, that

Re: [Request || Response]Rewriters, ImageRewriters, and rewriter caching

2010-05-04 Thread Chirag Shah
FWIW at Yahoo! we've configured a version of apache traffic server [1] to act as a reverse proxy which hits our own ImageRewriter. We've seen very notable performance gains with this setup. [1] http://trafficserver.apache.org/docs/v2/admin/reverse.htm On Tue, May 4, 2010 at 1:00 PM, John Hjelmsta

Re: Support Cross-Site Request Sharing in Shindig JSONP (issue1109041)

2010-05-04 Thread johnfargo
http://codereview.appspot.com/1109041/diff/1/2 File java/common/src/main/java/org/apache/shindig/common/servlet/HttpUtil.java (right): http://codereview.appspot.com/1109041/diff/1/2#newcode134 java/common/src/main/java/org/apache/shindig/common/servlet/HttpUtil.java:134: resp.addHeader("Access-C

Re: Support Cross-Site Request Sharing in Shindig JSONP (issue1109041)

2010-05-04 Thread johnfargo
Curious, have you got a list of current browsers that are CORS conformant? http://codereview.appspot.com/1109041/show

Re: JSONP and CORS for rest requests (issue1110041)

2010-05-04 Thread johnfargo
meta-comment: test? http://codereview.appspot.com/1110041/diff/1/2 File java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java (right): http://codereview.appspot.com/1110041/diff/1/2#newcode100 java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java:

JSONP and CORS for rest requests (issue1110041)

2010-05-04 Thread lindner
Reviewers: shindig.remailer_gmail.com, Please review this at http://codereview.appspot.com/1110041/show Affected files: M java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java Index: java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java

Re: Support Cross-Site Request Sharing in Shindig JSONP (issue1109041)

2010-05-04 Thread lindner
More info about this here: http://www.w3.org/TR/cors/ http://codereview.appspot.com/1109041/show

Support Cross-Site Request Sharing in Shindig JSONP (issue1109041)

2010-05-04 Thread lindner
Reviewers: shindig.remailer_gmail.com, Please review this at http://codereview.appspot.com/1109041/show Affected files: M java/common/src/main/java/org/apache/shindig/common/servlet/HttpUtil.java M java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java M java/gad

Re: Shindig Feed Processor: Parse MediaRSS items into optional Media element (issue1019041)

2010-05-04 Thread Paul Lindner
+...@shindig.apache.org Getting one more round of feedback, if no objections I'll commit this tomorrow via lazy consensus. On Wed, Apr 28, 2010 at 10:54 AM, Paul Lindner wrote: > Looks good to me. > > I can fix up the tabs vs spaces. > > Anyone opposed to adding rome-modules as a dependency? >

Re: [Request || Response]Rewriters, ImageRewriters, and rewriter caching

2010-05-04 Thread Paul Lindner
On Tue, May 4, 2010 at 1:00 PM, John Hjelmstad wrote: > We've implemented several RequestRewriters that aren't in Shindig, but > they'd be trivial to refactor into ResponseRewriters as described here. > > I'm unaware of anyone who's implemented a custom ImageRewriter (beyond > BasicImageRewriter)

Hudson build became unstable: Shindig #1494

2010-05-04 Thread Apache Hudson Server
See

Hudson build became unstable: Shindig » Apache Shindig Gadget Renderer #1494

2010-05-04 Thread Apache Hudson Server
See

Re: Update Caja to r4052 (issue846046)

2010-05-04 Thread John Hjelmstad
Adding and trying out the tests once more.. On Tue, May 4, 2010 at 12:59 PM, wrote: > > http://codereview.appspot.com/846046/diff/1/15 > File pom.xml (right): > > http://codereview.appspot.com/846046/diff/1/15#newcode1381 > pom.xml:1381: r3950 > You'll also need htmlparser which has now been spl

Re: [Request || Response]Rewriters, ImageRewriters, and rewriter caching

2010-05-04 Thread John Hjelmstad
We've implemented several RequestRewriters that aren't in Shindig, but they'd be trivial to refactor into ResponseRewriters as described here. I'm unaware of anyone who's implemented a custom ImageRewriter (beyond BasicImageRewriter). What more-radical reorganization might you suggest? Any additi

Re: Update Caja to r4052 (issue846046)

2010-05-04 Thread jasvir
http://codereview.appspot.com/846046/diff/1/15 File pom.xml (right): http://codereview.appspot.com/846046/diff/1/15#newcode1381 pom.xml:1381: r3950 You'll also need htmlparser which has now been split out into a separate maven dependency: caja htmlparser r4052

Re: [Request || Response]Rewriters, ImageRewriters, and rewriter caching

2010-05-04 Thread Paul Lindner
How many people have implemented custom rewriters? I'm guessing it's a small number, in which case I'd suggest a more radical reorganization of the code. In any case these are all good ideas. On Fri, Apr 30, 2010 at 5:13 PM, John Hjelmstad wrote: > Hi all, > > I'm looking into the rewriting pi

Re: INVALID_CHARACTER_ERR: An invalid or illegal XML character is specified.

2010-05-04 Thread franck tankoua
Actually the encoding is set to "UTF-8" at line 161. On Tue, May 4, 2010 at 3:44 PM, Mat Mannion wrote: > I wonder if the character encoding is being changed from UTF-8 somewhere, > or > if Neko is using the default character encoding from the OS/Java and > getting > muddled. > > On 4 May 2010 1

Re: Update Caja to r4052 (issue846046)

2010-05-04 Thread johnfargo
On 2010/04/25 20:40:26, jasvir wrote: http://codereview.appspot.com/846046/diff/1/8 File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java (right): http://codereview.appspot.com/846046/diff/1/8#newcode180 java/gadgets/src/main/java/org/apache/shindig/g

Re: Update Caja to r4052 (issue846046)

2010-05-04 Thread jasvir
ping? http://codereview.appspot.com/846046/show

Re: INVALID_CHARACTER_ERR: An invalid or illegal XML character is specified.

2010-05-04 Thread Mat Mannion
I wonder if the character encoding is being changed from UTF-8 somewhere, or if Neko is using the default character encoding from the OS/Java and getting muddled. On 4 May 2010 14:08, franck tankoua wrote: > Hi Paul, > > The error is actually comming from the xml I guess. When debugging, I have

Re: INVALID_CHARACTER_ERR: An invalid or illegal XML character is specified.

2010-05-04 Thread franck tankoua
Hi Paul, The error is actually comming from the xml I guess. When debugging, I have got the contains of the xml into the source ( inputSource.setCharacterStream(new StringReader(source)); line 162 of NekoSimplifiedHtmlParser.java) But This xml (http://www.google.com/ig/modules/horoscope.xml) s

PHP shindig and phpsocketdaemon

2010-05-04 Thread Loic Dachary
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I'm trying to figure out if running PHP shindig with the Drupal adaptor ( http://drupal.org/project/ShindigIntegrator ) from within a standalone PHP based server ( using http://code.google.com/p/phpsocketdaemon/ ) can be done without too much trou

Re: Explicitly use UTF-8 when turning strings to byte arrays (issue977046)

2010-05-04 Thread zhoresh
http://codereview.appspot.com/977046/diff/1/6 File java/common/src/main/java/org/apache/shindig/common/util/Base32.java (right): http://codereview.appspot.com/977046/diff/1/6#newcode40 java/common/src/main/java/org/apache/shindig/common/util/Base32.java:40: return ENCODER.encode(arg0).getBytes("