Hudson build became unstable: Shindig #1516

2010-05-13 Thread Apache Hudson Server
See

Hudson build became unstable: Shindig » Apache Shindig Gadget Renderer #1516

2010-05-13 Thread Apache Hudson Server
See

Re: Creating a shindig-extras module

2010-05-13 Thread ๏̯͡๏ Jasvir Nagra
The html parser already parses script tags and so knows the urls of code being included. At this point, the rewriter could substitute a known-to-cajole version if it cared to and/or inline the script. Is your concern that a library like jQuery may have been modified and/or be included from an unre

Hudson build is back to normal : Shindig #1514

2010-05-13 Thread Apache Hudson Server
See

Hudson build is back to normal : Shindig » Apache Shindig Sample SPI and API Implementations #1514

2010-05-13 Thread Apache Hudson Server
See

Hudson build is back to stable : Shindi g » Apache Shindig Gadget Renderer #1514

2010-05-13 Thread Apache Hudson Server
See

Re: [2.0] Removing some @Deprecated classes/methods/features

2010-05-13 Thread Chirag Shah
While we're at it.. what do you think about adding RestfulCollection(List entry, CollectionOptions options), and deducing startIndex (from options), totalResults (from entry), itemsPerPage (from options)? Thanks, Chirag On Thu, May 13, 2010 at 4:26 PM, Paul Lindner wrote: > I'm starting some cle

Hudson build became unstable: Shindig » Apache Shindig Gadget Renderer #1513

2010-05-13 Thread Apache Hudson Server
See

Build failed in Hudson: Shindig #1513

2010-05-13 Thread Apache Hudson Server
See Changes: [lindner] 2.0 Prep -- Remove deprecated code and features -- [...truncated 5012 lines...] May 14, 2010 3:09:19 AM com.gargoylesoftware.htmlunit.html.SimpleHTMLParserListener war

Build failed in Hudson: Shindig » Apache Shi ndig Sample SPI and API Implementations #1513

2010-05-13 Thread Apache Hudson Server
See -- [INFO] [INFO] Building Apache Shindig Sample SPI and API Implementations [INFO]t

Re: Fix Refresh override (issue1215041)

2010-05-13 Thread lindner
lgtm http://codereview.appspot.com/1215041/show

Fix Refresh override (issue1215041)

2010-05-13 Thread zhoresh
Reviewers: shindig.remailer_gmail.com, johnfargo, Description: Fix handling of refresh time by ProxyHandler. The handler class already handle the refresh so skip the refresh update in the proxy base. The real problem was that chain param style proxy refresh would be ignored and replaced with the

Re: Creating a shindig-extras module

2010-05-13 Thread Paul Lindner
we could offer caja versions of said libraries, plus the js can be concat'd with the rest of the payload. Lots of interesting things can fallout from this technique. 2010/5/13 ๏̯͡๏ Jasvir Nagra > On Thu, May 13, 2010 at 5:07 PM, Paul Lindner wrote: > > > There are some features that are new, e

Re: Creating a shindig-extras module

2010-05-13 Thread ๏̯͡๏ Jasvir Nagra
On Thu, May 13, 2010 at 5:07 PM, Paul Lindner wrote: > There are some features that are new, experimental and generally not > production ready nor standardized yet. However I'd like to see them > checked > in and maintained over time after such time they can graduate to > shindig-gadgets and/or

Creating a shindig-extras module

2010-05-13 Thread Paul Lindner
There are some features that are new, experimental and generally not production ready nor standardized yet. However I'd like to see them checked in and maintained over time after such time they can graduate to shindig-gadgets and/or shindig-social-api. I propose putting these new features in a ne

[2.0] Removing some @Deprecated classes/methods/features

2010-05-13 Thread Paul Lindner
I'm starting some cleanup getting ready for 2.0. This involves removing some deprecated code. The only one that we might want to keep is legacy body signing and/or strict content checks. I'm going to remove it for now. If anyone needs it for 2.x let me know and I'll revert. * SocialSpiExceptio

Re: Adding expiration information to the SecurityToken interface

2010-05-13 Thread Brian Eaton
On Thu, May 13, 2010 at 1:23 PM, Paul Lindner wrote: > We could certainly move the validation of tokens into the Codec (I guess > we'll then have to rename that class SecurityTokenCodecValidator as well...) > I added the isExpired() method so that a request for an expired token could > get downgra

Re: gadget prefs vs person app data

2010-05-13 Thread 王超
Hi Laura, One of the major differences between user pref and appdata is, user pref participated in the gadget rendering stage, yet appdata doesn't. For example, the user may set his favorite fruit to banana, while the default value is apple. Then: - if the user set userpref: fav_fruit = "banana",

Re: Adding expiration information to the SecurityToken interface

2010-05-13 Thread Paul Lindner
We could certainly move the validation of tokens into the Codec (I guess we'll then have to rename that class SecurityTokenCodecValidator as well...) I added the isExpired() method so that a request for an expired token could get downgraded to an anonymous level of access during the chain of Authe

Re: Allow injection of new features directories/resources via multibindings (issue1197041)

2010-05-13 Thread Henry Saputra
Using AOP to allow developers to add logic in the pointcuts handlers (or aspect in AspectJ) should be interesting approach. If not mistaken some other projects like Tuscany already support AOP with AspectJ to allow extension with developers code via the custom logic on some published pointcuts. A

Re: Allow injection of new features directories/resources via multibindings (issue1197041)

2010-05-13 Thread lindner
http://codereview.appspot.com/1197041/show

Re: Allow injection of new features directories/resources via multibindings (issue1197041)

2010-05-13 Thread Paul Lindner
On Thu, May 13, 2010 at 12:16 PM, John Hjelmstad wrote: > On Thu, May 13, 2010 at 12:01 PM, Paul Lindner >wrote: > > > hrm.. > > > > Due to the ordered magic of ImmutableSet we do get things injected in the > > correct order: > > > > I sort of figured that to be the case, though I'm still a bit

Re: Allow injection of new features directories/resources via multibindings (issue1197041)

2010-05-13 Thread John Hjelmstad
On Thu, May 13, 2010 at 12:01 PM, Paul Lindner wrote: > hrm.. > > Due to the ordered magic of ImmutableSet we do get things injected in the > correct order: > I sort of figured that to be the case, though I'm still a bit loath for important behavior to depend on quasi-magic (Guice :)) combined wi

Re: Adding expiration information to the SecurityToken interface

2010-05-13 Thread John Hjelmstad
On Thu, May 13, 2010 at 12:01 PM, Brian Eaton wrote: > On Tue, May 11, 2010 at 2:16 PM, Paul Lindner > wrote: > > +beaton (for domain member question) > > I'll add some docs to the committed code. expiresAt is informational, > > isExpired() is canonical and convenient enough that I'm betting th

Re: Allow injection of new features directories/resources via multibindings (issue1197041)

2010-05-13 Thread Paul Lindner
hrm.. Due to the ordered magic of ImmutableSet we do get things injected in the correct order: As you can see below we inject the random ordered multibindings first, followed by the comma split paths of "shindig.features.default". @Provides @Singleton @Named("org.apache.shindig.features")

Re: Adding expiration information to the SecurityToken interface

2010-05-13 Thread Brian Eaton
On Tue, May 11, 2010 at 2:16 PM, Paul Lindner wrote: > +beaton (for domain member question) > I'll add some docs to the committed code.  expiresAt is informational, > isExpired() is canonical and convenient enough that I'm betting that most > implementers will use it, and it can encompass things l

Re: Allow injection of new features directories/resources via multibindings (issue1197041)

2010-05-13 Thread John Hjelmstad
This actually isn't backward-compatible. Set is unordered, whereas the previous ordered array makes it possible to override existing feature declarations. For instance, we have a custom rpc/feature.xml override of the Shindig default. --j On Thu, May 13, 2010 at 6:58 AM, Paul Lindner wrote: > H

Re: upgrade to servlet-api 2.5

2010-05-13 Thread Paul Lindner
Hmm, If you're using maven you can add an for servlet-api-2.5 to your pom.xml and move on. For 2.0.x we'll insure that we maintain 2.4 ABI compatibility for deployed artifacts by not using the new methods in 2.5. You'll still be responsible for supplying your own web.xml, but that's a given!

Re: upgrade to servlet-api 2.5

2010-05-13 Thread Han Nguyen
-1 for the proposal as is. We certainly understand and in favor of your proposal for web.xml cleanup and API ease of use. However, we have requirements to support both 2.4 and 2.5. Is there a way we can manage this to provide backward compatibility to take care of any possible API conflicts/brea

Hudson build is back to stable : Shindig #1511

2010-05-13 Thread Apache Hudson Server
See

Hudson build is back to stable : Sh indig » Apache Shindig Web App #1511

2010-05-13 Thread Apache Hudson Server
See

gadget prefs vs person app data

2010-05-13 Thread Laura Nathanson
I've integrated parts of Shindig with my social networking site, but, I haven't been able to grasp this from the documentation I've seen.. What's the difference between prefs and app data? I've implemented app data for my site, and know that I'm supposed to go on and provide prefs. But I'm not sur

Re: Allow injection of new features directories/resources via multibindings (issue1197041)

2010-05-13 Thread Paul Lindner
Here's the next step towards allowing a shindig plugin architecture. This one allows external modules to add their javascript features to the FeatureRegistry. It's backwards compatible with the way we currently inject feature directories (via shindig.features.default) so I'm going to commit this

Re: Move 'org.apache.shindig.serviceExpirationDurationMinutes' to shindig.properties (issue1196041)

2010-05-13 Thread Paul Lindner
Guice can convert constant strings to similarly named primitive and other types. Also this config value was being set downstream (in SocialApiGuiceModule) which meant that you couldn't instantiate the gadgets guice module without errors. On Thu, May 13, 2010 at 6:51 AM, wrote: > Reviewers: shin

Allow injection of new features directories/resources via multibindings (issue1197041)

2010-05-13 Thread lindner
Reviewers: shindig.remailer_gmail.com, Please review this at http://codereview.appspot.com/1197041/show Affected files: M java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java M java/gadgets/src/main/java/org/apache/shindig/gadgets/features/FeatureRegistry.java

Move 'org.apache.shindig.serviceExpirationDurationMinutes' to shindig.properties (issue1196041)

2010-05-13 Thread lindner
Reviewers: shindig.remailer_gmail.com, Please review this at http://codereview.appspot.com/1196041/show Affected files: M UPGRADING M java/common/conf/shindig.properties M java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java Index: UPGRADING

Hudson build is unstable: Shindig #1510

2010-05-13 Thread Apache Hudson Server
See

Hudson build is unstable: Shindi g » Apache Shindig Web App #1510

2010-05-13 Thread Apache Hudson Server
See