Re: Session aware gadget xml fetching.

2010-11-17 Thread Nuwan Bandara
Hi Guys, I feel there is an advantage of this feature to shindig, If so I would like to contribute my solution (if it is accepted as a viable one) as a patch, so shindig users who need such functionality can add few configuration and leverage the benefit. Thanks & Regards, /Nuwan On Wed, Nov 17,

Re: Small enhancements to RewriteModule to make it reusable (issue3175041)

2010-11-17 Thread gagan . goku
Build looks good. Committed as r1036219. Thanks for the quick reviews guys. http://codereview.appspot.com/3175041/

Re: Small enhancements to RewriteModule to make it reusable (issue3175041)

2010-11-17 Thread Gagandeep singh
I was in a hurry to submit :) On Thu, Nov 18, 2010 at 2:06 AM, wrote: > LGTM (I was curious about the RewritePath not being public) > > > http://codereview.appspot.com/3175041/ >

Re: Small enhancements to RewriteModule to make it reusable (issue3175041)

2010-11-17 Thread henry . saputra
LGTM (I was curious about the RewritePath not being public) http://codereview.appspot.com/3175041/

Re: Issue 3175041: Small enhancements to RewriteModule to make it reusable

2010-11-17 Thread John Hjelmstad
LGTM On Wed, Nov 17, 2010 at 12:32 PM, Gagandeep singh wrote: > Reviewers: dev@shindig.apache.org, fargo >, > zhoresh > > Description: > > This cl: > 1) Makes RewritePath class public (I missed it > inhttp://codereview.appspot.com/2058042/) > 2) Makes some of the helper methods of RewriteModule

Issue 3175041: Small enhancements to RewriteModule to make it reusable

2010-11-17 Thread Gagandeep singh
Reviewers: dev@shindig.apache.org, fargo >, zhoresh Description: This cl: 1) Makes RewritePath class public (I missed it inhttp://codereview.appspot.com/2058042/) 2) Makes some of the helper methods of RewriteModule protected so other classes that extend RewriteModule can reuse these. Please re

Re: Session aware gadget xml fetching.

2010-11-17 Thread Nuwan Bandara
Hi Jesse, Thanks for your idea, however, I dont think it can solve the issue I am facing, let me explain a little On Wed, Nov 17, 2010 at 7:19 PM, Ciancetta, Jesse E. wrote: > Hi Nuwan, > > I'm wondering if a servlet filter might be a possible solution to this > problem. Since it sounds like ev

RE: Session aware gadget xml fetching.

2010-11-17 Thread Ciancetta, Jesse E.
Hi Nuwan, I'm wondering if a servlet filter might be a possible solution to this problem. Since it sounds like everything is running under the same servlet container, I think you could just drop a servlet filter in front of any /gadgets/ifr requests and within the filter get access to the user

Re: Session aware gadget xml fetching.

2010-11-17 Thread Nuwan Bandara
Hi Tim, On Wed, Nov 17, 2010 at 2:21 PM, Tim Wintle wrote: > On Wed, 2010-11-17 at 09:10 +0530, Nuwan Bandara wrote: > > Hi Devs, > > > > I am facing a difficulty, while using shindig to make session aware calls > to > > fetch gadget xmls. My requirement is as follows. > > > > When shindig is run

Re: Session aware gadget xml fetching.

2010-11-17 Thread Nuwan Bandara
Hi John, I have a solution for this problem, however when it comes to caching, it introduces a limitation. Let me elaborate on it. I have a container (Gadget Server), which wraps shindig to perform gadget rendering functionality. The server also provide a repository to store gadget and all other

Re: Session aware gadget xml fetching.

2010-11-17 Thread Tim Wintle
On Wed, 2010-11-17 at 09:10 +0530, Nuwan Bandara wrote: > Hi Devs, > > I am facing a difficulty, while using shindig to make session aware calls to > fetch gadget xmls. My requirement is as follows. > > When shindig is running as the gadget renderer, and when there are gadgets > hosted in the sam