RE: Use of CI Systems at the ASF

2011-07-07 Thread Gavin McDonald
> -Original Message- > From: Gavin McDonald [mailto:ga...@16degrees.com.au] > Sent: Thursday, 7 July 2011 7:00 AM > To: dev@shindig.apache.org > Subject: RE: Use of CI Systems at the ASF > > > > > -Original Message- > > From: Paul Lindner [mailto:lind...@inuus.com] > > Sent: We

Re: Code review request for View Enhancements To Open Gadgets and URLs (issue4641058)

2011-07-07 Thread rbaxter85
Thanks for making a first pass Paul. Is this the tool your referring to? http://code.google.com/p/closure-linter/source/browse/trunk/closure_linter/gjslint.py?r=2 On 2011/07/07 16:03:37, Paul Lindner wrote: First pass -- didn't look at tests or examples closely. Please run the js code throug

Re: Review Request: Fixed the error which comes when trying oauth example gadgets in the trunk

2011-07-07 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1029/#review994 --- http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/jav

Re: Call For Reviewers

2011-07-07 Thread Ryan J Baxter
Yes that's correct Henry. We just wanted to have the updates spec changes there incase anyone wanted to see the APIs in the spec as well. -Ryan Email: rjbax...@us.ibm.com Phone: 978-899-3041 developerWorks Profile From: Henry Saputra To: dev@shindig.apache.org, Date: 07/07/2011 01:

Re: Call For Reviewers

2011-07-07 Thread Henry Saputra
Ryan, The final patch set review for Action+Selection Features: http://codereview.appspot.com/4645056/ is actually contain change for the OpenSocial spec changes instead of Shindig. Should we review the patch set2? - Henry On Wed, Jul 6, 2011 at 5:26 PM, Ryan J Baxter wrote: > Shindig Committ

Re: Review Request: Common Container precludes synchronous rpc callbacks for handlers registered via Container.rpcRegister

2011-07-07 Thread Stanton Sievers
Mike, if there are no other questions or concerns here, can you commit this? Thanks, -Stanton From: Michael Hermanto To: Ryan Baxter , Cc: johnfa...@gmail.com, shindig , Stanton Sievers/Westford/IBM@Lotus Date: 07/06/2011 13:47 Subject:Re: Review Request: Common Containe

Re: embedded experiences patch (issue4631090)

2011-07-07 Thread igor1x
fixed a typo in the feature code. http://codereview.appspot.com/4631090/

Re: embedded experiences patch (issue4631090)

2011-07-07 Thread igor1x
without tabs this time. http://codereview.appspot.com/4631090/

Re: Code review request for View Enhancements To Open Gadgets and URLs (issue4641058)

2011-07-07 Thread lindner
First pass -- didn't look at tests or examples closely. Please run the js code through gjslint, that will catch most of the issues I pointed out. http://codereview.appspot.com/4641058/diff/1/content/samplecontainer/examples/commoncontainer/cconviews.js File content/samplecontainer/examples/comm

Re: Handling Certificates

2011-07-07 Thread Paul Lindner
The default http fetcher is based on apache httpclient 4.x. There's some talk of this over here: http://stackoverflow.com/questions/2703161/apache-httpclient-4-0-ignore-ssl-certificate-errors However I recommend that you do NOT do this as it could expose you to man in the middle attacks. Keytoo

Re: Handling Certificates

2011-07-07 Thread Ryan J Baxter
Doug did you try using gadgets.makeRequest? Did you have the same problem? -Ryan Email: rjbax...@us.ibm.com Phone: 978-899-3041 developerWorks Profile From: "Davies,Douglas" To: , Date: 07/07/2011 01:11 AM Subject:Re: Handling Certificates We had the same situation. The

Review Request: Fixed the error which comes when trying oauth example gadgets in the trunk

2011-07-07 Thread Sumedha Kodithuwakku
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1029/ --- Review request for shindig, Ryan Baxter and Agustin Casiva. Summary --- Alt

Re: Review Request: Fixed the error which comes when trying oauth example gadgets in the trunk

2011-07-07 Thread Sumedha Kodithuwakku
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1029/ --- (Updated 2011-07-07 08:45:04.703624) Review request for shindig, Ryan Baxter and

Re: OAuth Error with Shindig

2011-07-07 Thread Sumedha Sanjeewa
Done. Also I came up with a another patch which would be much appropriate.I had use that in the review. Link to the review : https://reviews.apache.org/r/1029/ On Wed, Jul 6, 2011 at 7:31 PM, Ryan J Baxter wrote: > Could you please create a code review request using the Apache code review > to