---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1179/#review1264
---
been trying to apply this patch but I'm seeing endtoend tests fail..
I'm seeing this as well. I'll look into this today.
From: Paul Lindner lind...@inuus.com
To: shindig dev@shindig.apache.org, Dan Dumont/Westford/IBM@Lotus,
Paul Lindner lind...@inuus.com,
Date: 08/02/2011 07:05
Subject:Re: Review Request: Enable closure compiler by default
On Tue, Aug 2, 2011 at 1:46 AM, Craig McClanahan craig...@gmail.com wrote:
Yes, I understand all about rapidly evolving code,
but I'd be happy with enough documentation that magicians (not even
necessarily mere mortals) that haven't memorized the codebase might get an
idea what is possible
Dan,
Have you seen an timing issues with this setpref implementation? I am
seeing strange things. I'm using the horoscope gadget which renders
differently if the user preferences have been set (it shows your horoscope
based on a uid). Sometimes this works and sometimes it doesn't. What's
Ok. Thanks.
A little more info.
Here¹s my code that works
var content = document.createElement( 'DIV' );
content.id = 'app-x';
document.getElementById( 'gadget-wrapper' ).appendChild( content
);
var gadgetSite = container.newGadgetSite( content );
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1179/#review1269
---
Looks pretty good to me, w/ the caveat that Shindig's default JDK
On 2011-08-02 20:06:10, johnfargo wrote:
Looks pretty good to me, w/ the caveat that Shindig's default JDK still is
1.5 :|
Were you able to compile it without any test failures?
Paul and Stanton both said they had end-to-end test failures after applying the
patch. I had no errors
Re: testing, I haven't done so -- just commenting on the code alone. Re:
var, removing it probably fixes our issue. I'm checking it out ;)
On Tue, Aug 2, 2011 at 1:38 PM, Dan Dumont ddum...@us.ibm.com wrote:
On 2011-08-02 20:06:10, johnfargo wrote:
Looks pretty good to me, w/ the caveat
