> On 2011-08-02 20:06:10, johnfargo wrote: > > Looks pretty good to me, w/ the caveat that Shindig's default JDK still is > > 1.5 :|
Were you able to compile it without any test failures? Paul and Stanton both said they had end-to-end test failures after applying the patch. I had no errors when building, but I hadn't synced your latest exports patches before I left. > On 2011-08-02 20:06:10, johnfargo wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/globals/globals.js, > > line 23 > > <https://reviews.apache.org/r/1179/diff/3/?file=27025#file27025line23> > > > > FMI, can you explain the drop of "var"? We were seeing some issues > > recently w/ this initialization on IE and I'm wondering if the motivation > > for your dropping it has to do with that, or is related somehow. I did it mainly for consistency, and because they are globals and are treated as such everywhere else. By convention, I've never used 'var' when assigning a global. I'm have no problem with leaving it if it causes other problems. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1179/#review1269 ----------------------------------------------------------- On 2011-07-26 14:11:17, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1179/ > ----------------------------------------------------------- > > (Updated 2011-07-26 14:11:17) > > > Review request for shindig. > > > Summary > ------- > > Enable closure with simple optimizations turned on. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/js/CompilationProcessorTest.java > 1150920 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js > 1150288 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties > 1150920 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/JsCompileMode.java > 1150920 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/CompilationProcessor.java > 1150920 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/js/JsCompilerModule.java > 1150920 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java > 1150920 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/globals/globals.js > 1150920 > > Diff: https://reviews.apache.org/r/1179/diff > > > Testing > ------- > > Existing js tests pass > > > Thanks, > > Dan > >
