Re: Securing RPC

2011-08-23 Thread John Hjelmstad
When you say export, do you mean the JS symbol name or the service ID registered by g.rpc.register(...)? I'm assuming the latter based on context... the implemented strategy is to export when the feature registers it. Am I understanding that your ask is to register lazily, only upon the first call

Re: Securing RPC

2011-08-23 Thread Ryan J Baxter
John, quick question for you on using exports with type="rpc"was the intent to export the rpc name when the feature registers it or when a feature calls it? I want to use it for when a feature calls it, I just want to make sure that was the intent. -Ryan Email: rjbax...@us.ibm.com Phone:

Re: Review Request: Selection feature implementation does not match spec

2011-08-23 Thread Matthew Hatem
> On 2011-08-24 00:22:17, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js, > > line 96 > > > > > > How does this ever get called?

Re: Review Request: Selection feature implementation does not match spec

2011-08-23 Thread Ryan Baxter
> On 2011-08-24 00:22:17, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js, > > line 96 > > > > > > How does this ever get called?

Re: Review Request: Selection feature implementation does not match spec

2011-08-23 Thread Matthew Hatem
> On 2011-08-24 00:22:17, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js, > > line 96 > > > > > > How does this ever get called?

Re: Review Request: Selection feature implementation does not match spec

2011-08-23 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1615/#review1604 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Re: Review Request: EE sample gadget doesn't work out of box if deployed with context other than root or deployed on port other than 8080

2011-08-23 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1616/#review1603 --- One more thing Li, please create a JIRA and attach the patch to it. T

Review Request: Selection feature implementation does not match spec

2011-08-23 Thread Matthew Hatem
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1615/ --- Review request for shindig and Ryan Baxter. Summary --- https://issues.apac

Re: Review Request: EE sample gadget doesn't work out of box if deployed with context other than root or deployed on port other than 8080

2011-08-23 Thread li xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1616/ --- (Updated 2011-08-23 21:47:22.758827) Review request for shindig, Paul Lindner, H

Re: Review Request: EE sample gadget doesn't work out of box if deployed with context other than root or deployed on port other than 8080

2011-08-23 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1616/#review1598 --- Overall this looks good! Thanks for doing this. Only small nits on e

Re: Review Request: RPC calls coming from iFrames within the same domain when using the same site id fail

2011-08-23 Thread Ryan Baxter
> On 2011-08-22 22:09:28, johnfargo wrote: > > This solution looks pretty good to me. Removing from the map in the > > gadgetSite.close() sounds like a reasonable solution to me. Another is just > > to remove the sameDomain function map from rpc. > > > > The potential downside to the latter is

Re: [osgs] OAuth 2.0 Service Provider in Shindig - Documentation Available

2011-08-23 Thread Matthew Marum
At the moment, we've actually been developing using a public fork of Shindig within github that I've been periodically syncing with trunk. I think in the longer term it is appropriate to refactor the code into shindig extras, but if people are interested in seeing what we've done so far can visit

Re: RE: [osgs] Incremental preloading of gadget metadata and security tokens

2011-08-23 Thread Mark W.
+1 Andrew, is this something we need to add to the incubating section "2.0 next" spec? If so, I can open that up so we can start working on it.

Re: Call For Implementors

2011-08-23 Thread Mark W.
I know Bastian was the PHP champion b/c of the work he's doing at VZ. Bastian, is this something that's on the plate for you and your team? We've also got to think about the C# implementation that MySpace put into open source. Chris, I know you are departing MySpace, is there any talk of gettin

Re: [osgs] OAuth 2.0 Service Provider in Shindig - Documentation Available

2011-08-23 Thread Mark W.
Can we put it in shidig extras so folks can start looking at it?