Re: Review Request: Generate and check ETags using the proper syntax

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1648/#review1623 --- Ship it! Good cleanups and fixes. Multiple Etags eh... Etag = the new

Re: Review Request: Generate and check ETags using the proper syntax

Hi Jacobo, Could you please create a JIRA issue for this and attach the patch or link the review to it. Thanks, - Henry On Wed, Aug 24, 2011 at 5:37 PM, Jacobo Tarrío wrote: > > --- > This is an automatically generated e-mail. To reply, v

Review Request: Generate and check ETags using the proper syntax

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1648/ --- Review request for shindig and johnfargo. Summary --- According to the RFC,

Re: Review Request: Issue in recent callSameDomain rpc changes when not using same domain

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1635/#review1622 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Re: Review Request: EE sample gadget doesn't work out of box if deployed with context other than root or deployed on port other than 8080

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1616/#review1620 --- Ship it! Committed revision 1161323. Please close the JIRA as well.

Re: Review Request: EE sample gadget doesn't work out of box if deployed with context other than root or deployed on port other than 8080

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1616/ --- (Updated 2011-08-24 20:14:29.491196) Review request for shindig, Paul Lindner, H

Re: Review Request: Issue in recent callSameDomain rpc changes when not using same domain

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1635/ --- (Updated 2011-08-24 17:56:11.813508) Review request for shindig. Changes -

Review Request: Issue in recent callSameDomain rpc changes when not using same domain

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1635/ --- Review request for shindig. Summary --- I ran into an issue loading the con

Review Request: Common container currently doesnt include the siteId (moduleId) in any of it's security token processing/handling

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1632/ --- Review request for shindig. Summary --- Common container currently doesn't

Re: Review Request: Selection feature implementation does not match spec

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1615/#review1618 --- Ship it! Committed revision 1161102. Please close the JIRA with this

Re: Review Request: Selection feature implementation does not match spec

> On 2011-08-24 00:22:17, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js, > > line 84 > > > > > > Shouldn't there be a test for remov

Re: Securing RPC

I mean in the feature.xml . rpc_service_id I am wondering whether the above export is used to export the service id when a feature calls g.rpc.register('rpc_service_id') or when a feature calls g.rpc.call('rpc_service_id')? It sounds like it used when a feature registers a servic