Re: Review Request: Locked domain cleanup and shared-domain-locking feature

2011-10-03 Thread Ryan Baxter
> On 2011-10-03 19:04:01, Jesse Ciancetta wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java, > > line 315 > > > > > > You could co

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

2011-10-03 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/ --- (Updated 2011-10-03 19:58:37.102473) Review request for shindig, Paul Lindner, j

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

2011-10-03 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/ --- (Updated 2011-10-03 19:18:41.510554) Review request for shindig, Paul Lindner, j

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

2011-10-03 Thread Jesse Ciancetta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/#review2269 --- Ship it! I found two small nits that you could take or leave which I

Re: Review Request: Review Request--patch to org.apache.shindig.gadgets.servlet.GadgetsHandlerApi.Location. Overriding the default toString() method.

2011-10-03 Thread Igor Belakovskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2144/ --- (Updated 2011-10-03 15:53:29.823897) Review request for shindig and Henry Saputr

Re: Review Request: Potential test failure in GadgetHandlerTest

2011-10-03 Thread Ryan Baxter
> On 2011-10-03 16:07:31, Paul Lindner wrote: > > For the future: since you're a committer and have CLA on file I'd just go > > ahead and submit non-feature related fixes like this directly. Less time > > clicking in jira == more time coding :) > > Thanks Paul. We would all like more time co

Re: Review Request: Potential test failure in GadgetHandlerTest

2011-10-03 Thread Paul Lindner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2149/#review2264 --- Ship it! For the future: since you're a committer and have CLA on fil

Review Request: Potential test failure in GadgetHandlerTest

2011-10-03 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2149/ --- Review request for shindig, Henry Saputra and Dan Dumont. Summary --- Gadge

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

2011-10-03 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/ --- (Updated 2011-10-03 14:30:19.987345) Review request for shindig, Paul Lindner, j

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

2011-10-03 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/ --- (Updated 2011-10-03 14:26:22.765398) Review request for shindig, Paul Lindner, j

AUTO: Simon Hewett is out of the office. (returning 10/04/2011)

2011-10-03 Thread simon_hewett
I am out of the office until 10/04/2011. I will respond to your message when I return. Please contact Wei-Lee Jamrog or Sarah Lachance (Mac) if urgent action is required. Note: This is an automated response to your message "Review Request: Review Request--patch to org.apache.shindig.gadgets